Monday, August 26, 2024
6 changes · saas-17.4
Resolved issues and error corrections
This fixes an internal quality check that was silently failing when reviewing translated text patterns in code. The change helps developers catch translation-related mistakes reliably before they reach customers, reducing the chance of inconsistent or hard-to-maintain language handling.
Original PR description
2e130cf97532cbf773820b74997f31fd7862b67c broke the gettext-variable lint check. The `value` attribute exists only on `astroid.Const` nodes. If a variable is passed to gettext (which is what this check is supposed to detect), the node is an instance of `astroid.Name`. Trying to read the value attribute on an instance of `astroid.Name` caused the check to silently crash. This commit fixes the problem by ensuring that the node is an instance of `astroid.Const` before attempting to read the value attribute. It also adds a bunch of tests to make sure this kind of bug doesn't go undetected in the future. Task-4132201
The translation option is now shown correctly when users focus or hover over HTML fields. This makes it easier to translate rich text content directly in forms, improving usability for multilingual workflows.
Original PR description
The focus/hover does not work the same way for html fields (filiation is different) So, the icon is always hidden currently. Let's add specific logic for these html fields --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes a usability issue in the Appraisals settings screen. It helps HR teams configure appraisal options more smoothly and reduces confusion during setup.
Original PR description
task-4063399
This update fixes how VoIP call data is updated so calls remain consistent after changes in the underlying system. It also makes related automated tests run much faster, helping future VoIP fixes and updates be validated more efficiently.
Original PR description
The voip model was overriding `static insert` method as if this works on a single record. For some time, this method works on multiple records, and its implementation detail has changed so assuming it does `get() ?? new()` is no longer guaranteed. The intent of override was to enrich data after them being assigned. This has been converted to an override of `update()`, which guarantees it being called whenever fields are updated on record, without making too much assumption in implementation details of records. This commit also speeds up tests of VOIP, which were awaiting input that contains a value. This is not observed by mutation observer, so these tests took 3 seconds to execute. This PR puts the value in `data-value`, so that this is a mutation that can be observed by contains, thus reducting time of such test to mere dozens of ms. community: https://github.com/odoo/odoo/pull/177212
Marketing campaign activity cards now only open the activity when users click the activity title, preventing accidental openings from clicks elsewhere on the card. The add child activity button also keeps the expected cursor behavior, making the campaign setup screen feel more predictable.
Original PR description
Purpose ======= Fix the "open record" action for the activities kanban in the marketing campaign form. The record can be opened when clicking anywhere on the kanban article, it should only be opened…
Purpose ======= Fix the "open record" action for the activities kanban in the marketing campaign form. The record can be opened when clicking anywhere on the kanban article, it should only be opened when clicking on the title of the acitvity. Specification ============= Following this commit https://github.com/odoo/odoo/commit/d52fc5ae69a9ca55df22f416a26c1ea5f5484ac9 the kanban arch parser has been updated changing the condition to open the record from this 'this.allowGlobalClick' to this 'this.props.archInfo.canOpenRecords'. It was previously only opening the record when the user clicked on the element with the 'oe_kanban_action' class (i.e. the activity title) but is now opening the record no matter where the click is on the kanban article. Fixing the issue by adding the new 'can_open' attribute on the kanban and setting it to false bringing back the old behavior. Also adding the 'user-select-none' class on the 'Add child activity' button so that the cursor isn't changed to the selector one when hovering the text. Task-4089001
This fix prevents purchase order budget calculations from failing when they reference analytic account records that no longer exist. It improves reliability by checking that related records are still available before using them during recalculation.
Original PR description
Browse mehtod of orm only returns a recordset for the ids provided but it never checks if those ids exist, which with recompute of analytic_json field can lead to this error: 'odoo.exceptions.MissingError: Record does not exist or has been deleted.'