- Have an one2may or a many2many on a setting (with some data in them);
- Edit/toggle any setting;
- Click on an action button or navigate to another view;
- On the "Unsaved changes" dialog, select "Discard".

Before this commit, the `discard` function of the relational model,
didn't take into account the initial commands, and replace the x2many
with an empty list of commands.
The issue is that the settings need to be saved (after discarding the
changes) when leaving, throws an action's button. This is done, to
create a res_id, that is most of the time mandatory to perform the
action (see [1])
 So if the `discard` function, empty the x2many, the setting will be
 modified, and the x2many will be emptied.

Now, the `discard` function of the relational model take into account
the x2many initial commands, therefore the x2many setting will stay
unchanged.

[1] : https://github.com/odoo/odoo/commit/9b81ddb993e4d56aba5aae637d160522d3af1d30

opw-4050990
opw-4092267
opw-4100926

Co-authored-by: Aaron Bohy <aab@odoo.com>

Forward-Port-Of: odoo/odoo#177883

Enterprise PR: https://github.com/odoo/enterprise/pull/68087

A user without any accounting access right set get an error when creating an invoice from a sale order. The user should be able to see the draft invoice when clicking on the 'Create Invoice' from a sale order, as it is the case without the l10n_cl_edi module.

### Steps to reproduce:
- Install the 'l10n_cl_edi' module
- As admin go to Settings > Manage Users, click on a User and, in Access Rights, change Accounting > Invoicing to nothing
- (Make sure the User Type is Internal User)
- Switch to this user
- Go to Sales and create a new Quotation, confirm
- Click on the 'Create Invoice' button
- An access error appears because of 'l10n_cl.account.invoice.reference'

### Cause:
The records of `l10n_cl.account.invoice.reference` are only readable by Accounting groups.

### Solution:
Make the records of `l10n_cl.account.invoice.reference` accessible to all internal users. This will raise another access error for `l10n_latam.document.type`, so we also need to make them accessible (in community).

### Note:
I noticed the access right of `l10n_cl.account.invoice.reference` were giving rights to `account.group_account_invoice` twice, where I think the second time was supposed to be `account.group_account_manager`. I don't know if this is wanted, but it doesn't make sense to have two lines for the same model and user group.
I decided to only change `group_account_invoice` to `group_account_manager` so this PR is removing the write, create, unlink rights of `account.group_account_invoice`.

opw-4078302

Forward-Port-Of: odoo/odoo#175988

Currently, a traceback occurs when the user `posts journal entries` with `multiple expenses` 
in which one of the expense doesn't have a `date`.

To reproduce this issue:

1) Install `Expense`
2) Create an expense report(expense sheet) with multiple expense lines 
3) Remove one of the expense's date
4) Click Submit to Manager> Approve> Post Journal Entries

Error:
```
TypeError: '>' not supported between instances of 'datetime.date' and 'bool'
  File "odoo/http.py", line 2248, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1823, in _serve_db
    return self._transactioning(_serve_ir_http, readonly=ro)
  File "odoo/http.py", line 1843, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1821, in _serve_ir_http
    return self._serve_ir_http(rule, args)
  File "odoo/http.py", line 1828, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 2053, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 220, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 756, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 42, in call_button
    action = self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 34, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 458, in call_kw
    result = getattr(recs, name)(*args, **kwargs)
  File "home/odoo/src/enterprise/saas-17.2/hr_expense_extract/models/hr_expense.py", line 199, in action_sheet_move_create
    return super().action_sheet_move_create()
  File "addons/hr_expense/models/hr_expense_sheet.py", line 558, in action_sheet_move_create
    self._do_create_moves()
  File "addons/sale_expense/models/hr_expense_sheet.py", line 119, in _do_create_moves
    return super()._do_create_moves()
  File "addons/hr_expense/models/hr_expense_sheet.py", line 700, in _do_create_moves
    moves = self.env['account.move'].create([sheet._prepare_bills_vals() for sheet in own_account_sheets])
  File "addons/hr_expense/models/hr_expense_sheet.py", line 700, in <listcomp>
    moves = self.env['account.move'].create([sheet._prepare_bills_vals() for sheet in own_account_sheets])
  File "addons/hr_expense/models/hr_expense_sheet.py", line 728, in _prepare_bills_vals
    **self._prepare_move_vals(),
  File "addons/hr_expense/models/hr_expense_sheet.py", line 749, in _prepare_move_vals
    'date': self.accounting_date or max(self.expense_line_ids.mapped('date')) or fields.Date.context_today(self),
```


When the user clicks on the `Post Journal Entries` Button, it tries to create an expense report in which `_prepare_move_vals` method triggers.

In this method, the `max` function is used to get the date from `expense_line_ids`. 
If any one of the expense lines doesn't have a date(date is not required) it leads to a traceback.

https://github.com/odoo/odoo/blob/607e454f65c2c60c4ee5169bc53706f24a8bc625/addons/hr_expense/models/hr_expense_sheet.py#L725-L732

After applying this commit, it will resolve this issue by filtering records with date and then the max function is used to get the maximum date.

sentry-5616738740

Forward-Port-Of: odoo/odoo#173613

**Current behavior:**
Having a batch transfer with 2+ delivery pickings, opening the choose package wizard and filling out the package type will not accurately display the shipping weight for the whole batch.

**Expected behavior:**
The weight displayed on the wizard form should reflect the weight of the package plus all product that will be put inside it from the batch.

**Steps to reproduce:**
1. Enable packs in settings, create a package type with a base weight of 1 unit and some product with a weight of 1 unit

2. Create two delivery transfers with some carrier (e.g, local delivery) each with 1 of the created product

3. Add the two pickings to a new batch, on the batch click the `Put in Pack` button and select the created package type

4. Observe that in the form, only one of the products from the batch transfer has been used to calculate the shipping weight

**Cause of the issue:**
In `shipping_weight`'s compute function in the
`ChooseDeliveryPackage` wizard, we don't account for a batch package (like what is done in `action_put_in_pack()` defined on this wizard). Thus, one of the move lines in the batch is not used in the weight calculation.

**Fix:**
Look at the context to see if the user is packing a batch and if so, get all the involved move lines from it.

opw-4077546

Forward-Port-Of: odoo/odoo#177022

Stock quants are not meant to be duplicated. This commit ensures that it is not possible to copy such records.

opw-4035690

(cherry picked from commit 044210f6c7c4e539b8ebd41082c737e8bc91fd4e)

---

In PR https://github.com/odoo/odoo/pull/172376 it was decided to not completely forbid quant duplication due to potential third party modules that could potentially use this feature.

However, we see an increment of customer with an incorrect quantity in past history, or a discrepancy in valuation and accounting because of this error.
Unfortunately, it is incredibly easy to duplicate the quants by mistake, for example by miss-clicking when trying to export or update the inventory qty to 0 ...

![image](https://github.com/user-attachments/assets/ef74c5fa-16f4-4532-a5ac-686c32056f29)

Hence, even if it breaks some third party modules, it is imperative to prevent further quants duplication.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#177584

Community PR: https://github.com/odoo/odoo/pull/175988

A user without any accounting access right set get an error when creating an invoice from a sale order. The user should be able to see the draft invoice when clicking on the 'Create Invoice' from a sale order, as it is the case without the l10n_cl_edi module.

### Steps to reproduce:
- Install the 'l10n_cl_edi' module
- As admin go to Settings > Manage Users, click on a User and, in Access Rights, change Accounting > Invoicing to nothing
- (Make sure the User Type is Internal User)
- Switch to this user
- Go to Sales and create a new Quotation, confirm
- Click on the 'Create Invoice' button
- An access error appears because of 'l10n_cl.account.invoice.reference'

### Cause:
The records of `l10n_cl.account.invoice.reference` are only readable by Accounting groups.

### Solution:
Make the records of `l10n_cl.account.invoice.reference` accessible to all internal users. This will raise another access error for `l10n_latam.document.type`, so we also need to make them accessible (in community).

### Note:
I noticed the access right of `l10n_cl.account.invoice.reference` were giving rights to `account.group_account_invoice` twice where I think the second time was supposed to be `account.group_account_manager`. I don't know if this is wanted but it doesn't make sense to have two lines for the same model and user group.
I decided to only change `group_account_invoice` to `group_account_manager` so this PR is removing the write, create, unlink rights of `account.group_account_invoice`.

opw-4078302

Forward-Port-Of: odoo/enterprise#68087

Before this commit, the salesmen did not had the right group and the test crashed with the following error when the test was run without demo data:

```
FAIL: TestCommissions.test_commission_plan_rules_with_template
Traceback (most recent call last):
  File "/data/build/enterprise/partner_commission/tests/test_commissions.py", line 221, in test_commission_plan_rules_with_template
    form.sale_order_template_id = so_template
  File "/data/build/odoo/odoo/tests/form.py", line 326, in __setattr__
    self[field_name] = value
  File "/data/build/odoo/odoo/tests/form.py", line 331, in __setitem__
    assert field_info is not None, f"{field_name!r} was not found in the view"
AssertionError: 'sale_order_template_id' was not found in the view
```

runbot task:  70916 and 73195
https://runbot.odoo.com/web/#id=70916&view_type=form&model=runbot.build.error&menu_id=405&cids=1 https://runbot.odoo.com/web/#id=73195&view_type=form&model=runbot.build.error&menu_id=405&cids=1

Forward-Port-Of: odoo/enterprise#68829