Wednesday, August 28, 2024
9 changes · master
Enhancements to existing features
The spreadsheet pivot details side panel has been adjusted to better handle overflowing content. This should make detailed pivot information easier to view and reduce layout issues for users working with spreadsheets.
Spreadsheet filter side panels now use the shared side panel component from the spreadsheet engine instead of a separate Odoo-specific version. This keeps the experience visually consistent while reducing duplicated maintenance work.
Original PR description
After the revamping of the side panels, the component `SidePanelCollapsible` of o-spreadsheet now have the same style as the one we have in Odoo. We can remove the odoo's implementation and use the one from o-spreadsheet. Task: [4105418](https://www.odoo.com/web#id=4105418&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)
Resolved issues and error corrections
Products added from a field service task now appear at the end of the related sales order, matching the expected line order. This prevents confusion for sales and operations teams when reviewing or updating orders after field service work.
Original PR description
Steps: - Create a SO with 2 SOL, among which one creates a task in fsm project upon SO confirmation. - Comfirm the SO and go to the related task. - Add a product and go back to the SO. Issue: - There's a new SOL, but it is in 2nd place, whereas it should be last. Cause: When you had SOLs directly in the SO, the 1st SOL of the SO has a sequence of 10, the 2nd - 11, etc. But when you had products via the task, it creates SOLs with sequence 10, which will always result in those lines starting in 2nd position, as they are ordered by sequence > id. Fix: Give the SOLs that are created from adding a product on the task the sequence of the last SOL. task-3768178
Code cleanup and technical improvements
This update tidies the Mail mobile code by improving documentation, aligning files with coding guidelines, and fixing linting issues. It helps make the module easier to maintain and reduces technical risk ahead of the upcoming major version freeze.
Miscellaneous changes
Forward-Port-Of: odoo/enterprise#68837
Original PR description
Forward-Port-Of: odoo/enterprise#68837
The voip model was overriding `static insert` method as if this works on a single record. For some time, this method works on multiple records, and its implementation detail has changed so assuming it does `get() ?? new()` is no longer guaranteed. The intent of override was to enrich data after them being assigned. This has been converted to an override of `update()`, which guarantees it being called whenever fields are updated on record, without making too much assumption in implementation d
Original PR description
The voip model was overriding `static insert` method as if this works on a single record. For some time, this method works on multiple records, and its implementation detail has changed so assuming it does `get() ?? new()` is no longer guaranteed. The intent of override was to enrich data after them being assigned. This has been converted to an override of `update()`, which guarantees it being called whenever fields are updated on record, without making too much assumption in implementation details of records. This commit also speeds up tests of VOIP, which were awaiting input that contains a value. This is not observed by mutation observer, so these tests took 3 seconds to execute. This PR puts the value in `data-value`, so that this is a mutation that can be observed by contains, thus reducting time of such test to mere dozens of ms. community: https://github.com/odoo/odoo/pull/177212 Forward-Port-Of: odoo/enterprise#68605
[IMP] account_online_synchronization: Show banner when fail connecting to existing account Issue: Sometimes the connection with the bank breaks for some reasons either the user remove the connection from the bank dashboard etc. And when the user press on 'fetch_transaction' in odoo, We will ask him to add the bank again without showing him anything to indicate the reason. Solution: Adding a banner in the widget to report that we are facing an issue connecting to the bank-account and show
Original PR description
[IMP] account_online_synchronization: Show banner when fail connecting to existing account Issue: Sometimes the connection with the bank breaks for some reasons either the user remove the connection from the bank dashboard etc. And when the user press on 'fetch_transaction' in odoo, We will ask him to add the bank again without showing him anything to indicate the reason. Solution: Adding a banner in the widget to report that we are facing an issue connecting to the bank-account and show it whenever the user face a problem connecting to existing account through the '_handle_odoofin_redirect_exception' which handle open the iframe whenever we face an issue connecting to an existing bank account Task-3355270 odoofin PR: https://github.com/odoo/odoofin/pull/263 Forward-Port-Of: odoo/enterprise#60184
Before this commit, the salesmen did not had the right group and the test crashed with the following error when the test was run without demo data: ``` FAIL: TestCommissions.test_commission_plan_rules_with_template Traceback (most recent call last): File "/data/build/enterprise/partner_commission/tests/test_commissions.py", line 221, in test_commission_plan_rules_with_template form.sale_order_template_id = so_template File "/data/build/odoo/odoo/tests/form.py", line 326, in __set
Original PR description
Before this commit, the salesmen did not had the right group and the test crashed with the following error when the test was run without demo data: ``` FAIL:…
Before this commit, the salesmen did not had the right group and the test crashed with the following error when the test was run without demo data:
```
FAIL: TestCommissions.test_commission_plan_rules_with_template
Traceback (most recent call last):
File "/data/build/enterprise/partner_commission/tests/test_commissions.py", line 221, in test_commission_plan_rules_with_template
form.sale_order_template_id = so_template
File "/data/build/odoo/odoo/tests/form.py", line 326, in __setattr__
self[field_name] = value
File "/data/build/odoo/odoo/tests/form.py", line 331, in __setitem__
assert field_info is not None, f"{field_name!r} was not found in the view"
AssertionError: 'sale_order_template_id' was not found in the view
```
runbot task: 70916 and 73195
https://runbot.odoo.com/web/#id=70916&view_type=form&model=runbot.build.error&menu_id=405&cids=1 https://runbot.odoo.com/web/#id=73195&view_type=form&model=runbot.build.error&menu_id=405&cids=1
Forward-Port-Of: odoo/enterprise#68863
Forward-Port-Of: odoo/enterprise#68829As per section 34(2) of CGST Act 2017, credit notes for invoices from the financial year cannot be included in GSTR after November 30th. With this commit, if any credit note is created after November 30th of the financial year, an alert will be displayed above the report with action which redirects to all those credit notes list so the user can easily remove tax from those credit notes. POT file also added for `l10n_in_reports`. **task**-3915664 Forward-Port-Of: odoo/enterprise#66824
Original PR description
As per section 34(2) of CGST Act 2017, credit notes for invoices from the financial year cannot be included in GSTR after November 30th. With this commit, if any credit note is created after November 30th of the financial year, an alert will be displayed above the report with action which redirects to all those credit notes list so the user can easily remove tax from those credit notes. POT file also added for `l10n_in_reports`. **task**-3915664 Forward-Port-Of: odoo/enterprise#66824