Wednesday, August 28, 2024
15 changes · saas-17.1
Miscellaneous changes
This PR fixes issues linked to the fact that the sliding of carousels is an asynchronous operation. Indeed, the options and the history of the carousels were not taking this into account. - [FIX] website: always set the first carousel slide as the active one - [FIX] website: make the `Carousel` options atomic - [FIX] website: prevent recording sliding of some carousels in history - [FIX] website: add a tour to test the `Carousel` options task-3744613 related to opw-3675019 Forward-Po
Original PR description
This PR fixes issues linked to the fact that the sliding of carousels is an asynchronous operation. Indeed, the options and the history of the carousels were not taking this into account. - [FIX] website: always set the first carousel slide as the active one - [FIX] website: make the `Carousel` options atomic - [FIX] website: prevent recording sliding of some carousels in history - [FIX] website: add a tour to test the `Carousel` options task-3744613 related to opw-3675019 Forward-Port-Of: odoo/odoo#173684 Forward-Port-Of: odoo/odoo#153892
Before this commit, the user was not able to see the caret icon to indicate autocomplete dropdown in many2one and many2many values. Steps to reproduce: - open documents and then navigate to actions from the configuration. - click on any action and add a rule for any many2many field. - then try to add many2many values to that rule. Observed behavior: No caret is displayed when adding the many2many values. Expected behavior: Now a caret is displayed on hover indicating a dropdown
Original PR description
Before this commit, the user was not able to see the caret icon to indicate autocomplete dropdown in many2one and many2many values. Steps to reproduce: - open documents and then navigate to actions from the configuration. - click on any action and add a rule for any many2many field. - then try to add many2many values to that rule. Observed behavior: No caret is displayed when adding the many2many values. Expected behavior: Now a caret is displayed on hover indicating a dropdown while adding many2many and many2one values. After this commit, the user will be able to see the caret icon to indicate autocomplete dropdown in many2one and many2many values. Task-3777903 Forward-Port-Of: odoo/odoo#158292
Issue ----- If an image has a width or height of 1, crop_resize will fail if we are trying to resize it to a vertical format (max_height/max_width > 1) if the original image has a height of 1, or to a horizontal format if the original image has a width of 1. This is because the calculated new_w/new_h of the cropped image will be 0. Steps to reproduce ----- The issue typically happens when a mail includes spacer images with a height or width of 1 and they get uploaded as documents and
Original PR description
Issue ----- If an image has a width or height of 1, crop_resize will fail if we are trying to resize it to a vertical format (max_height/max_width > 1) if the original image has a height of 1, or to a horizontal format if the original image has a width of 1. This is because the calculated new_w/new_h of the cropped image will be 0. Steps to reproduce ----- The issue typically happens when a mail includes spacer images with a height or width of 1 and they get uploaded as documents and a thumbnail is generated. An easier way to reproduce in v16.0 (in v15.0 we resize to a square format): 1. Install Documents. 2. Upload an image with a width of 1. -> Error 500 opw-4053926 Forward-Port-Of: odoo/odoo#177885 Forward-Port-Of: odoo/odoo#176632
* PROPBLEM: since https://github.com/odoo/odoo/pull/173719 we have moved from init to post_init which will make timesheet_task_id of hr.leave.type can't set value because in post_init company.leave_timesheet_task_id will be set * SOLUTION: fill it in post_init instead Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Fo
Original PR description
* PROPBLEM: since https://github.com/odoo/odoo/pull/173719 we have moved from init to post_init which will make timesheet_task_id of hr.leave.type can't set value because in post_init company.leave_timesheet_task_id will be set * SOLUTION: fill it in post_init instead Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177605 Forward-Port-Of: odoo/odoo#177008
When using a fiscal position that map account. If you use automatic stock valuation and make an order in the PoS, the account used where not mapped correctly for all the account move lines. Steps to reproduce: ------------------- * Turn on automatic stock valuation for the category `All` * The category use account A and account B for expense and income * Create a fiscal position that matches account A and B to any other account * Open PoS and make an order > Observation: Go back to the
Original PR description
When using a fiscal position that map account. If you use automatic stock valuation and make an order in the PoS, the account used where not mapped correctly for all the account move lines. Steps to reproduce: ------------------- * Turn on automatic stock valuation for the category `All` * The category use account A and account B for expense and income * Create a fiscal position that matches account A and B to any other account * Open PoS and make an order > Observation: Go back to the order and look at the move lines linked to the order. One of the lines still use an account that hasn't been mapped Why the fix: ------------ We make sure that when creating the stock valuation lines the account are correctly mapped using `order_id.fiscal_position_id.map_account` opw-4086609 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177557 Forward-Port-Of: odoo/odoo#177369
No visual bug, just a small coding mistake made with [1]. [1]: https://github.com/odoo/odoo/commit/e2cd6940bd29670ea0e76cd4bb95489a12588f55 Related to task-3957198 Forward-Port-Of: odoo/odoo#178059
Original PR description
No visual bug, just a small coding mistake made with [1]. [1]: https://github.com/odoo/odoo/commit/e2cd6940bd29670ea0e76cd4bb95489a12588f55 Related to task-3957198 Forward-Port-Of: odoo/odoo#178059
Before this commit, recurrent events created with the 'All Day' option were duplicating the first event of the recurrence in Google side. This was happening because we wrongly synchronized the single event with Google before the synchronization of its recurrence (which already synchronize the events in Google side itself). After this commit, the recurrence is created normally using the 'All Day' option. We achieve that by skipping the useless synchronization we were doing in the single event:
Original PR description
Before this commit, recurrent events created with the 'All Day' option were duplicating the first event of the recurrence in Google side. This was happening because we wrongly synchronized the single event with Google before the synchronization of its recurrence (which already synchronize the events in Google side itself). After this commit, the recurrence is created normally using the 'All Day' option. We achieve that by skipping the useless synchronization we were doing in the single event: only the recurrence must be synchronized in this specific flow. task-3768121 Forward-Port-Of: odoo/odoo#177073 Forward-Port-Of: odoo/odoo#166885
Before this commit when being in a branches environment, creating an account group on the main company was not propagated to the account of the child companies opw: 4055582 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173634
Original PR description
Before this commit when being in a branches environment, creating an account group on the main company was not propagated to the account of the child companies opw: 4055582 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173634
Before this commit the tax grid of the tax was wrong. The value of this tax should be put in the total sales of goods and services in Field C in the tax report. link to documentation: https://skat.dk/erhverv/moms/moms-ved-handel-med-udlandet/moms-ved-handel-med-virksomheder/moms-ved-handel-med-lande-uden-for-eu/moms-ved-salg-af-varer-og-ydelser-i-lande-uden-for-eu task: 4132444 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Po
Original PR description
Before this commit the tax grid of the tax was wrong. The value of this tax should be put in the total sales of goods and services in Field C in the tax report. link to documentation: https://skat.dk/erhverv/moms/moms-ved-handel-med-udlandet/moms-ved-handel-med-virksomheder/moms-ved-handel-med-lande-uden-for-eu/moms-ved-salg-af-varer-og-ydelser-i-lande-uden-for-eu task: 4132444 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177566
Issue: ====== Can't add content at the end/start of button Steps to reproduce the issue: ============================= - Use chrome - Install events - Go to website/events/conference for architects (demo data) - Open editor and edit - Put the cursor at the end of the "Get The direction" button - Try to add some text, nothing happens Note: it works in firefox Origin of the issue: ==================== Chrome doesn't support the following case correctly when the selection is at
Original PR description
Issue: ====== Can't add content at the end/start of button Steps to reproduce the issue: ============================= - Use chrome - Install events - Go to website/events/conference for architects (demo data) - Open editor and edit - Put the cursor at the end of the "Get The direction" button - Try to add some text, nothing happens Note: it works in firefox Origin of the issue: ==================== Chrome doesn't support the following case correctly when the selection is at the start or at the end of the text. ``` <div contenteditable="false"> <a contenteditable="true" href="http://www.example.com"> <p> abcde </p> </a> </div> ``` The `p` element inside the `a` was introduced in [1]. Solution: ========= Unwrap the content of the `p` elements inside `a` element the same way we do for `li` elements. opw-3878459 [1]: https://github.com/odoo/odoo/commit/4a890e1f92a665dd53f17ee57b4e7792c33da7db Forward-Port-Of: odoo/odoo#169765
While the format for the guid is the right in the xml, for the CSV, we should add double quotes, as asked by the format. The 2 zip should really be separated, with one for the csv and the other for the attachments Renamed the 2 buttons to indicate more clearly what they are about. The csv only expects a single attachment per move. We should then only export the message_main_attachment_id task-4131986 Forward-Port-Of: odoo/enterprise#68862 Forward-Port-Of: odoo/enterprise#68794
Original PR description
While the format for the guid is the right in the xml, for the CSV, we should add double quotes, as asked by the format. The 2 zip should really be separated, with one for the csv and the other for the attachments Renamed the 2 buttons to indicate more clearly what they are about. The csv only expects a single attachment per move. We should then only export the message_main_attachment_id task-4131986 Forward-Port-Of: odoo/enterprise#68862 Forward-Port-Of: odoo/enterprise#68794
This commit ensures that the caret is not displayed on hover in `RecordSelector` , `MultiRecordSelector` components when they are present in sidebars and report editors. Displaying the caret in sidebar RecordSelectors creates an awkward and visually unappealing effect. This issue arises because, in sidebars, the entire input area is a RecordAutocomplete with padding and margin. Task-3777903 Forward-Port-Of: odoo/enterprise#68772
Original PR description
This commit ensures that the caret is not displayed on hover in `RecordSelector` , `MultiRecordSelector` components when they are present in sidebars and report editors. Displaying the caret in sidebar RecordSelectors creates an awkward and visually unappealing effect. This issue arises because, in sidebars, the entire input area is a RecordAutocomplete with padding and margin. Task-3777903 Forward-Port-Of: odoo/enterprise#68772
**Current behavior:** When adding an unplanned move line to a transfer in barcode, if the line is added to an existing move which is a subcontract transfer, it will not take the subcontract location as its source location value. Rather, it will use whatever value is defined on the picking. **Expected behavior:** Use the more precise location defined on the move rather than the picking. **Steps to reproduce:** 1. Create a product with a subcontract BOM 2. Create a receipt for that pro
Original PR description
**Current behavior:** When adding an unplanned move line to a transfer in barcode, if the line is added to an existing move which is a subcontract transfer, it will not take the subcontract location…
**Current behavior:** When adding an unplanned move line to a transfer in barcode, if the line is added to an existing move which is a subcontract transfer, it will not take the subcontract location as its source location value. Rather, it will use whatever value is defined on the picking. **Expected behavior:** Use the more precise location defined on the move rather than the picking. **Steps to reproduce:** 1. Create a product with a subcontract BOM 2. Create a receipt for that product from the subcontractor 3. Open the transfer in Barcode and manually add another line for the same product -> validate 4. In the receipt form, look at the move lines (detailed operations) and group by location to see the discrepancy **Cause of the issue:** When creating a move line here, it does not initially get a `move_id` value. Later when the move is written to the line, we would not generally want to override whatever value is on the line already because it (normally) is more precise/was purposely changed later than what value is on the move. **Fix:** In the case of lines which are created and then linked to a subcontract move, take the `location_id` of the move rather than whatever value is on the MoveLine. opw-4007423 Forward-Port-Of: odoo/enterprise#68032
**[FIX] documents: skip spreadsheets while toggling preview in FileViewer** Issue: - preview any document that can be previewed. - toggle the preview to make the FileViewer preview a spreadsheet. - as the spreadsheet lacks a preview, a blank preview is seen when the FileViewer lands on the spreadsheet. Reason: - while preparing the `documentsRecords` there is actually a filter present to filter out only previewable records. please refer --- https://github.com/odoo/enterprise/
Original PR description
**[FIX] documents: skip spreadsheets while toggling preview in FileViewer** Issue: - preview any document that can be previewed. - toggle the preview to make the FileViewer preview a spreadsheet. -…
**[FIX] documents: skip spreadsheets while toggling preview in FileViewer** Issue: - preview any document that can be previewed. - toggle the preview to make the FileViewer preview a spreadsheet. - as the spreadsheet lacks a preview, a blank preview is seen when the FileViewer lands on the spreadsheet. Reason: - while preparing the `documentsRecords` there is actually a filter present to filter out only previewable records. please refer --- https://github.com/odoo/enterprise/blob/17.0/documents/static/src/views/hooks.js#L311 - but for some reason the function `[isRecordPreviewable]` is not passed as a parameter from neither the `DocumentsKanbanController` nor the `DocumentsListController` and as a result, rendered the `.filter()` useless. Fix: - We migrate the `isRecordPreviewable()` method to the `DocumentsSpreadsheetControllerMixin` so that it overrides the newly created `isRecordPreviewable()` method in the `DocumentsKanbanController`, which is then accessed by the `.filter()` mentioned above. Task-4029257
[IMP] account_online_synchronization: Show banner when fail connecting to existing account Issue: Sometimes the connection with the bank breaks for some reasons either the user remove the connection from the bank dashboard etc. And when the user press on 'fetch_transaction' in odoo, We will ask him to add the bank again without showing him anything to indicate the reason. Solution: Adding a banner in the widget to report that we are facing an issue connecting to the bank-account and show
Original PR description
[IMP] account_online_synchronization: Show banner when fail connecting to existing account Issue: Sometimes the connection with the bank breaks for some reasons either the user remove the connection from the bank dashboard etc. And when the user press on 'fetch_transaction' in odoo, We will ask him to add the bank again without showing him anything to indicate the reason. Solution: Adding a banner in the widget to report that we are facing an issue connecting to the bank-account and show it whenever the user face a problem connecting to existing account through the '_handle_odoofin_redirect_exception' which handle open the iframe whenever we face an issue connecting to an existing bank account Task-3355270 odoofin PR: https://github.com/odoo/odoofin/pull/263 Forward-Port-Of: odoo/enterprise#60184