Wednesday, August 28, 2024
3 changes
1 change
Resolved issues and error corrections
Project setup checks now ensure milestones are enabled before running guided tours. This prevents tour failures in databases without demo data and makes project-related testing more reliable.
Original PR description
Some project tours rely on the milestones feature being enabled. While this is the case when demo data are installed, it's not when they aren't, and the tours fail. To solve this issue, and prevent future ones from being created, PR enables the feature before each tour. Task-4132639
1 change
Resolved issues and error corrections
Products added from a field service task now appear at the end of the related sales order, matching the expected line order. This prevents confusion for sales and operations teams when reviewing or updating orders after field service work.
Original PR description
Steps: - Create a SO with 2 SOL, among which one creates a task in fsm project upon SO confirmation. - Comfirm the SO and go to the related task. - Add a product and go back to the SO. Issue: - There's a new SOL, but it is in 2nd place, whereas it should be last. Cause: When you had SOLs directly in the SO, the 1st SOL of the SO has a sequence of 10, the 2nd - 11, etc. But when you had products via the task, it creates SOLs with sequence 10, which will always result in those lines starting in 2nd position, as they are ordered by sequence > id. Fix: Give the SOLs that are created from adding a product on the task the sequence of the last SOL. task-3768178
1 change
Resolved issues and error corrections
This update fixes a test in the Peru stock reports module that was failing unpredictably due to inconsistent data ordering. By standardizing the order of data processing, the test now runs reliably every time, improving the stability of our quality assurance process.
Original PR description
Trying the test from l10n_pe_reports_stock, it failed locally, but somehow we are lucky it did not fail on runbot. The problem is that the order is not fixed and by fixing the order we avoid the indeterministic failing.