Thursday, August 29, 2024
9 changes · saas-17.4
Resolved issues and error corrections
This change corrects an automated website setup test so it looks in the right place for a language selection popup. It helps keep website creation checks stable and reduces false test failures without changing the user-facing website experience.
Original PR description
[FIX] website: avoid to check for duplicated modal Since [1], the `extra_trigger` key has been removed from the tests. Due to it, the `automatic_editor_on_new_website` test fails as the `.modal div[name="lang_ids"]...` selector is used in a `trigger` element and not in `extra_trigger` anymore. Indeed, at the contrary of `extra_trigger`, the `trigger` element directly searches in the main modal, leading the `.modal` in the selector to be duplicated. To solve the problem, `in_modal: false` is added to indicate to the system that the search does not have to be done in the main modal. [1]: https://github.com/odoo/odoo/commit/68a92cb0dd2ea06102df7cb44ae9121a61575ae1 runbot-69009
Saving a map block on an event registration page no longer triggers an error that blocks further editing. This keeps website editors from getting stuck when adding location information to event sign-up pages.
Original PR description
In the register page of the events, when you add a map block, and save it, you'll get an UncaughtPromiseError. To Reproduce on Runbot: 1. Go to the events page. 2. Click on one of the events. 3. Go to /register page 4. Go to Editor and add a map block 5. Save it Upon saving, you'll encounter the error, and further cannot make any edits. The issue is due to calling _manageIframeSrc on the element where there is no iframeEl defined yet. So, we'll add the iframeEl first and call _manageIframeSrc. opw-4104300
This fixes an issue in guided website tours where the cursor appeared outside the snippet area during drag-and-drop steps. The change helps automated tours and demonstrations behave correctly when users interact with website editor snippets.
Original PR description
Fix the tour cursor being displayed out of the website snippets when the step is to drag and drop a snippets from the website editor. Adding the '.o_we_draggable' class to the tour compiler so that the drag event is correctly handled in the editor. Related commit: odoo/odoo@5a990d8d8ba2ec2999f84d2f1dae7aeec0f2d9b5 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The chat message editor is now easier to use when editing an existing message in a small chat window. Spacing was reduced and action buttons were moved so users have more room to type and review their changes.
Original PR description
In chat window, editing message composer is too narrow. This commit fixes the issue as follow: 1. Reduce spacing in message and composer while editing a message 2. Move actions to bottom Before / After <img width="363" alt="004-before" src="https://github.com/user-attachments/assets/ef80af40-710c-4de2-a5ed-185a68580ffc">  https://github.com/odoo/enterprise/pull/68573
This update fixes an internal employee leave test so it matches a recent naming change in the allocation workflow. It helps keep automated checks reliable and reduces false failures in quality validation, with no direct change for end users.
Original PR description
Since pr https://github.com/odoo/odoo/pull/158829 holiday type has been moved to a wizard and it's name changed to allocation_mode. This pr corrects the test where we were using old naming. runbot issue-73015 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an error that could stop users from opening the Calendar when their profile had no timezone selected. The calendar now handles a missing timezone safely, improving reliability for users with incomplete profile settings.
Original PR description
When customer tries to open ```calendar``` without timezone, a traceback will appear. Steps to reproduce the error: - Go to My profile > In timezone, Select empty timezone - Install ```hr_calendar```…
When customer tries to open ```calendar``` without timezone,
a traceback will appear.
Steps to reproduce the error:
- Go to My profile > In timezone, Select empty timezone
- Install ```hr_calendar```
- Open ```Calendar```
Traceback:
```
AttributeError: 'bool' object has no attribute 'upper'
File "odoo/http.py", line 2373, in __call__
response = request._serve_db()
File "odoo/http.py", line 1903, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1966, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 134, in retrying
result = func()
File "odoo/http.py", line 1933, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2177, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 754, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 459, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "addons/hr_calendar/models/res_partner.py", line 99, in get_working_hours_for_all_attendees
return self._interval_to_business_hours(reduce(Intervals.__and__, schedule_by_partner.values()))
File "addons/hr_calendar/models/res_partner.py", line 105, in _interval_to_business_hours
"startTime": interval[0].astimezone(timezone(self.env.user.tz)).strftime("%H:%M"),
File "odoo/tools/_monkeypatches_pytz.py", line 129, in timezone
return original_pytz_timezone(name)
File "__init__.py", line 183, in timezone
if zone.upper() == 'UTC':
```
https://github.com/odoo/odoo/blob/3345a0b61630ee1ac11045b09717167744265a24/addons/hr_calendar/models/res_partner.py#L105
When user has an empty timezone and tries to open the ```calendar``` app,
It will give the traceback at the above line.
sentry-5707574801
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe message editing area in WhatsApp conversations is now wider, making it easier to review and update longer messages. This fixes a usability issue that could make editing feel cramped and less efficient.
Original PR description
https://github.com/odoo/odoo/pull/177084
Users editing a room booking will no longer see an incorrect warning that the booking was changed or deleted by someone else. The warning is now reserved for real conflicts caused by another user, reducing confusion and interruption during normal booking edits.
Original PR description
Purpose: ------- Currently when editing a booking from the frontend form view, a warning notification is shown, indicating that the booking being edited has been updated or deleted. This notification should only be shown when the booking being edited has been updated or deleted by another user (because in that case the user will be forced to leave the edition view without doing anything). Task-4104748
This fix ensures certain intercompany stock and purchase settings remain read-only where intended. It prevents configuration changes from being incorrectly passed through to company records, reducing the risk of inconsistent warehouse, delivery, or receipt behavior between companies.
Original PR description
Because of https://github.com/odoo/odoo/blob/e1fb54cb3d5db9c906946fa11ff49c1ca86d3722/odoo/fields.py#L620-L621, writing on a field which is `related` and `readonly=False` will effectively forward the new value on the parent field if this one is also `readonly=False`. This was not the case for fields + `intercompany_warehouse_id` + `intercompany_sync_delivery_receipt` + `intercompany_receipt_type_id` defined in res_company and related in res_config_setting As they are computed fields which implies that are `readonly=True` by default.