Friday, August 30, 2024
3 changes · 17.0
Resolved issues and error corrections
This fix corrects the bank reconciliation report to properly count both reconciled and unreconciled transactions that are not from a bank statement. Previously, the report was excluding reconciled entries, which caused incorrect account balances. The fix also addresses an issue with reconciliation rate calculations when there are no reconciled entries.
Original PR description
Before this commit, the section transaction without statement didn't count the reconciled entries, and so the balance of the account was wrong. To fix that we putted a new custom engine function that will trigger the _bank_reconciliation_report_custom_engine_common with False for the "from_statement" and False for the "unreconciled" variables. With that the query will get all the transaction reconciled or not that are not from a statement. There was also a problem if the reconcile rate was 0, which didn't when having only unreconciled entries but now that we can have that, it needed to be modified. task: 4110491
This fix ensures that when follow-up emails are sent automatically by the system, the designated follow-up responsible person is credited as the message author instead of the system bot. This means that when customers reply to automatic follow-up emails, the responsible person will be properly notified, matching the behavior of manually-sent follow-ups.
Original PR description
Have a partner in need of action with the followup level configured to Send an Email, with 'Automatic' enabled Case 1: - Send the followup manually - Reply to the follouwp mail - Message will be posted as log note but the system link the message with the previous one[1], where user is the author and will be automatically notified Case 2: - Wait for the cron to send followup automatically - Reply to the followup mail - Message will be posted as log note but since OdooBot is the author of the previous message no user will receive any notification With this commit we make use of the followup responsible when sending followup email automatically before defaulting to OdooBot [1] https://github.com/odoo/odoo/blob/fe4b2a6d08a450b281e7ac0676afd51a88dd6008/addons/mail/models/mail_thread.py#L1182 opw-4000835 Forward-Port-Of: odoo/enterprise#67391
This fix ensures that when users duplicate a pricelist, all recurring price rules and rental rules are now properly copied to the new pricelist. Previously, these special pricing rules were not being duplicated, which meant users had to manually recreate them in the duplicated pricelist.
Original PR description
Before this commit, when user duplicate pricelist then recurring price rule are not duplicated in new pricelist. After this commit, recurring price rule will be copied to new pricelist when user will duplicate pricelist. task-4035473