Saturday, August 31, 2024
9 changes · saas-17.1
Miscellaneous changes
This commit reverts dd331e7bb27c533808a01b53f80e0ee7f1dfed7f This change has caused a lot of issues recently, and despite some other fixes, we believe it's safer to revert it for now. opw-4126140 opw-4114139 opw-4115510 opw-4117520 opw-4109625 opw-4115415 opw-4143237 opw-4123382 opw-4136888 opw-4125807 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read
Original PR description
This commit reverts dd331e7bb27c533808a01b53f80e0ee7f1dfed7f This change has caused a lot of issues recently, and despite some other fixes, we believe it's safer to revert it for now. opw-4126140 opw-4114139 opw-4115510 opw-4117520 opw-4109625 opw-4115415 opw-4143237 opw-4123382 opw-4136888 opw-4125807 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178587
Some fixes already landed with 7cbf7f94263a31d316b9c5a0efad57ad357aa5a0, but if the address is incomplete, the user would still be redirected to a 403 page because he cannot update the warehouse address to fill the missing fields. This commit makes sure that for onsite flows, the warehouse address is considered complete. opw-4126140 opw-4114139 opw-4115510 opw-4117520 opw-4109625 opw-4115415 opw-4143237 opw-4123382 opw-4136888 opw-4125807 Forward-Port-Of: odoo/odoo#178521
Original PR description
Some fixes already landed with 7cbf7f94263a31d316b9c5a0efad57ad357aa5a0, but if the address is incomplete, the user would still be redirected to a 403 page because he cannot update the warehouse address to fill the missing fields. This commit makes sure that for onsite flows, the warehouse address is considered complete. opw-4126140 opw-4114139 opw-4115510 opw-4117520 opw-4109625 opw-4115415 opw-4143237 opw-4123382 opw-4136888 opw-4125807 Forward-Port-Of: odoo/odoo#178521
The vies check service may limit ip addresses when: - checking too many vat numbers per day - checking the same vat number multiple times - checking too many invalid number --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178219
Original PR description
The vies check service may limit ip addresses when: - checking too many vat numbers per day - checking the same vat number multiple times - checking too many invalid number --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178219
### Steps to reproduce: - Enable Multi-Step Routes in the settings - Go to Inventory > Configuration > Warehouse Management > Routes - Unarchive MTO - Create a storable product: - Routes: MTO, manufacture - With a bom - On hand qty: 10 - Create an SO for 15 units and validate - Go back to your product form > forecasted Report #### > Even thought 15 units are made to order 10 units are reported to be taken from stock to fulfill the SO ### Cause of the issue: The lines appe
Original PR description
### Steps to reproduce: - Enable Multi-Step Routes in the settings - Go to Inventory > Configuration > Warehouse Management > Routes - Unarchive MTO - Create a storable product: - Routes: MTO,…
### Steps to reproduce: - Enable Multi-Step Routes in the settings - Go to Inventory > Configuration > Warehouse Management > Routes - Unarchive MTO - Create a storable product: - Routes: MTO, manufacture - With a bom - On hand qty: 10 - Create an SO for 15 units and validate - Go back to your product form > forecasted Report #### > Even thought 15 units are made to order 10 units are reported to be taken from stock to fulfill the SO ### Cause of the issue: The lines appearing on the reported are computed by the `_get_report_lines` method. During this call, the quantity taken from stock is computed by comparing the demand of the out moves with the quantity currently in stock: https://github.com/odoo/odoo/blob/1fdccad664cad37a69dc960444aa0c318d1bf464/addons/stock/report/report_stock_forecasted.py#L218-L223 This is incorrect because the quantity taken from stock is null if the procure_method of the out move is make_to_stock. ### Note: The issue is not reproducible since 17.0 since the _get_report_lines has been refactored during the stockpocalypse. opw-4010785 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177867 Forward-Port-Of: odoo/odoo#176273
Since [1], applying a font-size on some snippet default text was not working properly anymore. As soon as the actual text was changed, the features were working again. Steps to reproduce: - Enter website edit mode. - Add a "Title" snippet. - Triple-click on the default text. - Hit the font-size "Default" button. => Nothing happens, you cannot restore the default title size. Other steps to reproduce: - Enter website edit mode. - Add a "Title" snippet. - Triple-click on the default
Original PR description
Since [1], applying a font-size on some snippet default text was not working properly anymore. As soon as the actual text was changed, the features were working again. Steps to reproduce: - Enter…
Since [1], applying a font-size on some snippet default text was not working properly anymore. As soon as the actual text was changed, the features were working again.
Steps to reproduce:
- Enter website edit mode.
- Add a "Title" snippet.
- Triple-click on the default text.
- Hit the font-size "Default" button.
=> Nothing happens, you cannot restore the default title size.
Other steps to reproduce:
- Enter website edit mode.
- Add a "Title" snippet.
- Triple-click on the default text.
- Choose a font-size (like "8").
=> It is applied but inside the pre-existing 62px environment instead of replacing it, meaning the DOM looks like this:
```xml
<font style="font-size: 62px;">
<font style="font-size: 8px;">Title</font>
</font>
```
While it seems insignificant, this creates vertical misalignment.
Depending on the use case, it might be problematic (e.g. a long
paragraph instead of a title: it would have a big line spacing for
no apparent reason). Note that this one is actually a more generic
problem already but [1] worsened it. We might fully solve that issue
in future versions.
To fix the issue, we now ensure that applying any editor command on some
default text makes it not-default text anymore.
opw-3957198
Forward-Port-Of: odoo/odoo#178286
Forward-Port-Of: odoo/odoo#178083In the accounting reconciliation tool: - Click in one of the 2 search inputs - Start typing - Single click on the second search input - Start typing - Notice it still types in the first search input instead of the second. The search input you choose first doesn't matter. You can start with the upper one or the bottom one, the issue is the same, just reversed. Before:  After:  After:  Forward-Port-Of: odoo/odoo#178238
On linux and Windows, CTRL + left clic on links, e.g. a customer on an invoice opens a new tab. This browser behavior is similar with regular links using Command + Left clic on MacOS. It wasn't working for many2one links in Odoo because the clic was captured and prevented the browser default behavior. It was not captured only for the `ctrlKey` currently. This revision adds the `metaKey` in addition to the `ctrlKey` to the non-capture condition. There are similar conditions a bit ev
Original PR description
On linux and Windows, CTRL + left clic on links, e.g. a customer on an invoice opens a new tab. This browser behavior is similar with regular links using Command + Left clic on MacOS. It wasn't…
On linux and Windows, CTRL + left clic on links, e.g. a customer on an invoice opens a new tab. This browser behavior is similar with regular links using Command + Left clic on MacOS. It wasn't working for many2one links in Odoo because the clic was captured and prevented the browser default behavior. It was not captured only for the `ctrlKey` currently. This revision adds the `metaKey` in addition to the `ctrlKey` to the non-capture condition. There are similar conditions a bit everywhere in the code: - https://github.com/odoo/odoo/blob/9beccc94ba6c140d6e1eb43c34d811c424f5ea2c/addons/barcodes/static/src/js/barcode_events.js#L170-L171 - https://github.com/odoo/odoo/blob/9beccc94ba6c140d6e1eb43c34d811c424f5ea2c/addons/mail/static/src/models/user_setting/user_setting.js#L163 - https://github.com/odoo/odoo/blob/9beccc94ba6c140d6e1eb43c34d811c424f5ea2c/addons/web/static/src/core/hotkeys/hotkey_service.js#L250 - https://github.com/odoo/odoo/blob/9beccc94ba6c140d6e1eb43c34d811c424f5ea2c/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js#L1705-L1710 - https://github.com/odoo/odoo/blob/9beccc94ba6c140d6e1eb43c34d811c424f5ea2c/addons/website_slides/static/src/js/slides_embed.js#L178 - https://github.com/odoo/enterprise/blob/6dc662dfca8e1d277df19aa377bcdc761f7e7bf3/documents/static/src/js/documents_controller_mixin.js#L975 - https://github.com/odoo/enterprise/blob/6dc662dfca8e1d277df19aa377bcdc761f7e7bf3/documents_spreadsheet/static/src/js/o_spreadsheet/o_spreadsheet.js#L31440 - https://github.com/odoo/enterprise/blob/6dc662dfca8e1d277df19aa377bcdc761f7e7bf3/timesheet_grid/static/src/js/timesheet_grid/timesheet_timer_grid_renderer.js#L301 - https://github.com/odoo/enterprise/blob/6dc662dfca8e1d277df19aa377bcdc761f7e7bf3/web_enterprise/static/src/webclient/home_menu/home_menu.js#L434 - https://github.com/odoo/enterprise/blob/6dc662dfca8e1d277df19aa377bcdc761f7e7bf3/web_gantt/static/src/js/gantt_renderer.js#L163 - https://github.com/odoo/enterprise/blob/6dc662dfca8e1d277df19aa377bcdc761f7e7bf3/web_gantt/static/src/js/gantt_row.js#L159 Unfortunately, given the nature of this behavior (requires a Command keystroke + check that a new tab is opened), it cannot really be tested in a unit test, not even a web tour. Forward-Port-Of: odoo/odoo#178314 Forward-Port-Of: odoo/odoo#178268
In commit [1], the carousel controls have been deactivated in edit mode, in order to control the carousel sliding manually so everything is done in the mutex. This was done to avoid asynchronous issues and to have a correct history when using the carousel options. However, these controls are also blocked in translate mode, because it is considered as if it was in edit mode, which should not be the case. This made it impossible to translate the other slides, since we cannot slide the carousel
Original PR description
In commit [1], the carousel controls have been deactivated in edit mode, in order to control the carousel sliding manually so everything is done in the mutex. This was done to avoid asynchronous issues and to have a correct history when using the carousel options. However, these controls are also blocked in translate mode, because it is considered as if it was in edit mode, which should not be the case. This made it impossible to translate the other slides, since we cannot slide the carousel anymore. This commit fixes this by not deactivating the carousel controls if we are in translate mode. Steps to reproduce: - Install an other language. - In edit mode, drop the "Carousel" or the "Quotes" snippet and save. - Change the language of the website and translate it. - Try to slide the carousel. => It is impossible. [1]: https://github.com/odoo/odoo/commit/93ec3ac285dc9ffd363e185a1dc238c6135d79dd opw-4134824 Forward-Port-Of: odoo/odoo#178252
[This commit] added in a new Carta Porte 3.0 PDF for Mexico in version saas-17.3 that inherits from the standard delivery slip, by removing all the tables related to the products etc. (for security reasons: the driver doesn't need to know what's in the cargo) and adding in some new required fields. This commit backports the report from saas-17.3 with the following changes: - We improved the layout a bit to make the report even clearer. - We corrected the "Num Reg ID Trib" and "Residencia Fi
Original PR description
[This commit] added in a new Carta Porte 3.0 PDF for Mexico in version saas-17.3 that inherits from the standard delivery slip, by removing all the tables related to the products etc. (for security reasons: the driver doesn't need to know what's in the cargo) and adding in some new required fields. This commit backports the report from saas-17.3 with the following changes: - We improved the layout a bit to make the report even clearer. - We corrected the "Num Reg ID Trib" and "Residencia Fiscal" of the "Figura"'s to use the right value and show them per figura. - We corrected the departure and arrival date (they were swapped). These changes will be forward-ported again to the upper versions. [This commit]: https://github.com/odoo/enterprise/commit/af14612ec5942acdc06584ec8ff9d8bf26998ae7 task-3990042 Forward-Port-Of: odoo/enterprise#68059 Forward-Port-Of: odoo/enterprise#65337