Odoo Changelog — 2024-09-02

Monday, September 2, 2024

2 changes · 17.0

Bug Fixes(2)

Resolved issues and error corrections

[FIX] spreadsheet_session: avoid concurrent updates

Enterprise17.0spreadsheet_editionMEDIUM

This fix resolves a timing issue that occurred when users left a spreadsheet, where thumbnail saving and data snapshots were happening simultaneously and causing unpredictable errors. The fix ensures these operations happen in the correct sequence, making spreadsheet sessions more stable and reliable.

Original PR description

Steps to reproduce (in odoo)
- Open a spreadsheet
- do something such that there's a least one revisions
- leave the spreadsheet

=> non-deterministic concurrent update because we save the thumbnail and we snapshot at the same time.

I'm able to reproduce more when my laptop power setting is on "performance" compared to "balanced"

Task: 4080148

#spreadsheet#stability#concurrent-updates

[FIX] l10n_fr_fec_import: enable importing partner with same name

PR #69148

Enterprise17.0l10n_fr_fec_importHIGH

This fix resolves a critical issue in the French FEC file import process where importing files containing multiple partners with identical names but different reference codes would cause the import to fail. Previously, the system would skip creating duplicate-named partners and then fail when trying to link accounting entries to the missing partner records. Now the import correctly creates all partners regardless of name duplication, ensuring all accounting data is properly linked.

Original PR description

Steps to reproduce:
- Have a FEC file (see ticket)
- Import it on a brand new db

Issue:
Crash. We try to create account move line with an xml id that does not exist because we didn't create the partner associated to the correct ref

The second issue is that we will link the move to the wrong customer since the second one is not created

Cause:
The first issue is caused because we bypass the creation of the second partner with the same name "PARTNER 01" but different ref "PARTNER02"
`ValueError: External ID not found in the system: l10n_fr_fec_import.89_partner_PARTNER02`

The reason is, when creating the move line, we assign the `partner_id` with an xml_id based on the partner_ref
https://github.com/odoo/enterprise/blob/ae3820059f6ff46b0dbcd64eabb2aae5caa98e18/l10n_fr_fec_import/wizard/import_wizard.py#L474-L490
Which of course does not exist.

opw-3932234

#FEC import#partner management#data integrity#France localization

Steps to reproduce (in odoo) - Open a spreadsheet - do something such that there's a least one revisions - leave the spreadsheet => non-deterministic concurrent update because we save the thumbnail and we snapshot at the same time. I'm able to reproduce more when my laptop power setting is on "performance" compared to "balanced" Task: 4080148

Steps to reproduce: - Have a FEC file (see ticket) - Import it on a brand new db Issue: Crash. We try to create account move line with an xml id that does not exist because we didn't create the partner associated to the correct ref The second issue is that we will link the move to the wrong customer since the second one is not created Cause: The first issue is caused because we bypass the creation of the second partner with the same name "PARTNER 01" but different ref "PARTNER02" `ValueError: External ID not found in the system: l10n_fr_fec_import.89_partner_PARTNER02` The reason is, when creating the move line, we assign the `partner_id` with an xml_id based on the partner_ref https://github.com/odoo/enterprise/blob/ae3820059f6ff46b0dbcd64eabb2aae5caa98e18/l10n_fr_fec_import/wizard/import_wizard.py#L474-L490 Which of course does not exist. opw-3932234