Monday, September 2, 2024
15 changes · saas-17.1
Resolved issues and error corrections
Installing the UK localization now also installs the related BACS payment support as expected. This ensures UK companies get the required bank payment setup automatically, avoiding manual follow-up configuration.
Original PR description
### Steps to reproduce: - Install the 'l10n_uk' module - The module "l10n_uk_bacs" is not installed, but it should ### Solution: Add a post init hook in `l10n_uk` to download `l10n_uk_bacs`. opw-4122475
Miscellaneous changes
*= event_crm_sale, website_event_crm * -Probably miss by script since https://github.com/odoo/odoo/pull/104741/commits/332c117f60a36f723c450f61ce2e0e7181d66c21 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177703
Original PR description
*= event_crm_sale, website_event_crm * -Probably miss by script since https://github.com/odoo/odoo/pull/104741/commits/332c117f60a36f723c450f61ce2e0e7181d66c21 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177703
When using a loyalty program that apply a discount on the cheapest line the combo "title" would always be selected as it's price is 0. And the reward would then not be applied. Steps to reproduce: ------------------- * Create a combo product with atleast 2 combo choices * Create a loyalty program that gives a discount on the cheapest line * Open a PoS and add the combo product > Observation: The reward cannot be applied Why the fix: ------------ When tryin to apply the discount, in
Original PR description
When using a loyalty program that apply a discount on the cheapest line the combo "title" would always be selected as it's price is 0. And the reward would then not be applied. Steps to reproduce: ------------------- * Create a combo product with atleast 2 combo choices * Create a loyalty program that gives a discount on the cheapest line * Open a PoS and add the combo product > Observation: The reward cannot be applied Why the fix: ------------ When tryin to apply the discount, in the `_getCheapestLine` function we make sure to filter lines that are combo "title" opw-4033960 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177062
backport of https://github.com/odoo/odoo/pull/176340 enterprise: https://github.com/odoo/enterprise/pull/69045 Forward-Port-Of: odoo/odoo#177705
Original PR description
backport of https://github.com/odoo/odoo/pull/176340 enterprise: https://github.com/odoo/enterprise/pull/69045 Forward-Port-Of: odoo/odoo#177705
In #97883, the Hungarian localization was translated from Hungarian into English. After that, some Hungarian translations for tax names, tax descriptions and tax report lines were lost. This commit aims at ensuring the translations are added and bringing Hungarian taxes in conformity with best practices. Specifically, this commit changes tax names in descriptions according to the tax naming conventions. task-4132407 --- I confirm I have signed the CLA and read the PR guidelines at
Original PR description
In #97883, the Hungarian localization was translated from Hungarian into English. After that, some Hungarian translations for tax names, tax descriptions and tax report lines were lost. This commit aims at ensuring the translations are added and bringing Hungarian taxes in conformity with best practices. Specifically, this commit changes tax names in descriptions according to the tax naming conventions. task-4132407 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178242 Forward-Port-Of: odoo/odoo#177928
There is an issue where the Mercado Pago terminal rejects a card payment, but Odoo accepts the payment. This is caused by a quirk in the Mercado Pago API, where the payment intent status is "FINISHED" despite the payment status being "rejected". This PR fixes the issue by checking the payment status explicitly by calling the API. task-4097968 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178386
Original PR description
There is an issue where the Mercado Pago terminal rejects a card payment, but Odoo accepts the payment. This is caused by a quirk in the Mercado Pago API, where the payment intent status is "FINISHED" despite the payment status being "rejected". This PR fixes the issue by checking the payment status explicitly by calling the API. task-4097968 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178386
Forward-Port-Of: odoo/odoo#178525
Original PR description
Forward-Port-Of: odoo/odoo#178525
Steps to reproduce: 1) Install hr_work_entry_contract_planning_attendance 2) Create planning-based contracts for employee 3) create a shift for the employee for 8 hours (Based on the working schedule) 4) create attendance more than shift hours 5) Open work entries and you get Extra Overtime work entry Cause: For the work entries, we defined date_generated_from and date_generated_to in contracts Based on these dates we are going to decide whether we need to create work entries for the sp
Original PR description
Steps to reproduce: 1) Install hr_work_entry_contract_planning_attendance 2) Create planning-based contracts for employee 3) create a shift for the employee for 8 hours (Based on the working schedule) 4) create attendance more than shift hours 5) Open work entries and you get Extra Overtime work entry Cause: For the work entries, we defined date_generated_from and date_generated_to in contracts Based on these dates we are going to decide whether we need to create work entries for the specific period working schedule as work entry source Fix: these dates are set for both types of contracts task-3646385 Forward-Port-Of: odoo/odoo#156432
This commit brings out some more improvement to the New Zealand localization. It will mostly be about translating a few terms, improving tax labels on invoices and mark invoices as "tax invoices". Task id #3753652 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165686
Original PR description
This commit brings out some more improvement to the New Zealand localization. It will mostly be about translating a few terms, improving tax labels on invoices and mark invoices as "tax invoices". Task id #3753652 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165686
We noticed that in production, eTIMS regularly fails to respond within the timeout of 30s when we send an invoice. Since this happens fairly often, this PR aims to improve the error message so that the user knows there is nothing they can do except wait for a bit and then retry. We also increase the timeout to 45s, on the off chance that this might improve things somewhat. taskid: none Forward-Port-Of: odoo/enterprise#69049
Original PR description
We noticed that in production, eTIMS regularly fails to respond within the timeout of 30s when we send an invoice. Since this happens fairly often, this PR aims to improve the error message so that the user knows there is nothing they can do except wait for a bit and then retry. We also increase the timeout to 45s, on the off chance that this might improve things somewhat. taskid: none Forward-Port-Of: odoo/enterprise#69049
* = documents_spreadsheet, website_helpdesk_livechat, whatsapp Enterprise counter-part. After a reset, the last id is always 0. backport of https://github.com/odoo/enterprise/pull/68302 community: https://github.com/odoo/odoo/pull/177705 Forward-Port-Of: odoo/enterprise#69045
Original PR description
* = documents_spreadsheet, website_helpdesk_livechat, whatsapp Enterprise counter-part. After a reset, the last id is always 0. backport of https://github.com/odoo/enterprise/pull/68302 community: https://github.com/odoo/odoo/pull/177705 Forward-Port-Of: odoo/enterprise#69045
…ew ro Version: 17.0 Steps: Click on the schedule feature in the rental module. Click on the 'New' to create the rental order. Issue : When a user clicks on the "Schedule" feature in the rental module and then clicks on "New" to create a rental order, the rental period feature is disabled, and the payment period appears instead. Cause : The issue is caused by the condition invisible="not is_rental_order" on the rental_start_date field. fix: To fix this issue, we remove the invis
Original PR description
…ew ro Version: 17.0 Steps: Click on the schedule feature in the rental module. Click on the 'New' to create the rental order. Issue : When a user clicks on the "Schedule" feature in the rental module and then clicks on "New" to create a rental order, the rental period feature is disabled, and the payment period appears instead. Cause : The issue is caused by the condition invisible="not is_rental_order" on the rental_start_date field. fix: To fix this issue, we remove the invisible="not is_rental_order" condition from the rental_start_date field definition. This ensures that the rental period feature is always visible when creating a new rental order. opw-4016866 Forward-Port-Of: odoo/enterprise#66904
### Steps to reproduce: - Install the module "l10n_ec" and switch to Ecuadorian company - Go to Accounting > Configuration > Ecuadorian SRI > Digital Certificates SRI - When uploading a p12 file with the country name "Ecuador" and not "EC" - An error pops up but does not tell the right reason ### Cause: The cryptography library only accepts country names in the form of 2 character country code, so it raises an error. If an error occurs during the loading of the file, the error message w
Original PR description
### Steps to reproduce: - Install the module "l10n_ec" and switch to Ecuadorian company - Go to Accounting > Configuration > Ecuadorian SRI > Digital Certificates SRI - When uploading a p12 file with the country name "Ecuador" and not "EC" - An error pops up but does not tell the right reason ### Cause: The cryptography library only accepts country names in the form of 2 character country code, so it raises an error. If an error occurs during the loading of the file, the error message will always be "Error loading certificate %s, check that password is correct and file type is p12". ### Solution: As we cannot display the error messages of external libraries (here the cryptography library), this commit adds the reason "The country name is not a 2 character country code." in the error message. opw-4116914 Forward-Port-Of: odoo/enterprise#69138 Forward-Port-Of: odoo/enterprise#68633
In this PR, one test case is added to ensure the behavior of the planning-based contract on work entries Task - 3646385 Forward-Port-Of: odoo/enterprise#66801
Original PR description
In this PR, one test case is added to ensure the behavior of the planning-based contract on work entries Task - 3646385 Forward-Port-Of: odoo/enterprise#66801
This commit brings out some more improvement to the New Zealand localization. It will mostly be about translating a few terms, improving tax labels on invoices and mark invoices as "tax invoices". Task id #3753652 Forward-Port-Of: odoo/enterprise#62591
Original PR description
This commit brings out some more improvement to the New Zealand localization. It will mostly be about translating a few terms, improving tax labels on invoices and mark invoices as "tax invoices". Task id #3753652 Forward-Port-Of: odoo/enterprise#62591