Monday, September 2, 2024
9 changes · saas-17.4
Resolved issues and error corrections
This fix restores both intended updates for website shop product snippets after one had accidentally replaced the other. It helps ensure the online store displays the correct snippet behavior consistently.
Original PR description
A previous oversight lead to _prepare_values to be overridden twice for 2 separate tasks The task that was merged last was functioning while the other one wasn't This commit merges the 2 functions together commit 1: 5bde2e42c8ec5e943a779ad4b3e1b7142f2d2fcf commit 2: 4ac43fbafc2899e296bf0593dcaef0c3b914928c --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The comments menu in Knowledge articles now keeps a consistent layout when the screen is narrowed. This prevents overlapping controls and makes commenting easier to use on smaller screens.
Original PR description
Steps to reproduce: 1. Open Knowledge 2. Select any text in an article 3. The menu will show 4. Click on comments 5. Write a log and shrink the screen 6. The comments menu breaks The display of comments is a little bit odd Removed 'flex-wrap' from the message header's CSS to prevent the menu from overlapping when the screen size is reduced. This ensures a consistent layout and better user experience on smaller screens. Task-4063810
Emoji names are now safely handled when translated, preventing certain non-English translations from breaking the emoji picker. This ensures users can reliably browse and insert emojis regardless of their selected language.
Original PR description
BUG: emojis were not loading in some non-English languages The issue was that the emojis were not escaped when translated, and in some languages, the translated emojis contained double quotes inside, which was originally curly quotes. FIX: escape the translated emoji names to avoid the double quotes breaking the JSON parsing. task-4139904 task-4143513 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The on-screen celebration message now remains visible even when its surrounding area has no size. This prevents users from missing positive feedback after completing certain actions.
Original PR description
In this commit, we fix the rainbowMan css so that it is visible through a container that is 0x0. To do this, we need to change the position to fixed instead of absolute. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where opening the manufacturing order overview could fail when a component quantity was set to a negative value. This prevents an error screen and keeps the manufacturing workflow usable in this edge case.
Original PR description
When the quantity of components is negative in mo and user clicks on the overview button. a traceback will appear. Steps to reproduce the error: - Install ```mrp``` and ```purchase``` - Create…
When the quantity of components is negative in mo and user clicks on
the overview button.
a traceback will appear.
Steps to reproduce the error:
- Install ```mrp``` and ```purchase```
- Create product A > In Purchase, add vendor > In Inventory, Select Buy and
Replenish on Order (MTO) in Routes > Save
- Create one MO > Select any product > In components, Select product A >
In To consume, Set 10 for ex. > Confirm
- Click on Purchases smart button > Confirm Order > Receive Products > Validate
- Go back to MO > Set negative value in Quantity (ex. -1) > Save
- Click on Overview
Traceback:
```
AssertionError: precision_digits must be a non-negative integer, got 0.01
File "odoo/http.py", line 2373, in __call__
response = request._serve_db()
File "odoo/http.py", line 1903, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1966, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 134, in retrying
result = func()
File "odoo/http.py", line 1933, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2177, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 754, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 459, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "addons/mrp/report/mrp_report_mo_overview.py", line 19, in get_report_values
'data': self._get_report_data(production_id),
File "addons/mrp/report/mrp_report_mo_overview.py", line 77, in _get_report_data
components = self._get_components_data(production, level=1, current_index='')
File "addons/mrp/report/mrp_report_mo_overview.py", line 416, in _get_components_data
replenish_data = self._get_replenishments_from_forecast(production, replenish_data)
File "addons/mrp/report/mrp_report_mo_overview.py", line 694, in _get_replenishments_from_forecast
forecast_lines = self._add_origins_to_forecast(forecast_lines)
File "addons/mrp/report/mrp_report_mo_overview.py", line 771, in _add_origins_to_forecast
if float_compare(move_out_qty, 0, line['move_out'].product_uom.rounding) <= 0:
File "odoo/tools/float_utils.py", line 181, in float_compare
rounding_factor = _float_check_precision(precision_digits=precision_digits,
File "odoo/tools/float_utils.py", line 39, in _float_check_precision
assert float(precision_digits).is_integer() and precision_digits >= 0,\
```
https://github.com/odoo/odoo/blob/2c89fae7bc3e026425a4f02c4a70e4a87083560d/addons/mrp/report/mrp_report_mo_overview.py#L771
Here, In the above line ```precision_rounding``` is missing.
So, it will lead to the above traceback.
This commit will prevent the negative quantity of component product.
Sentry-5729142241
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis fix restores a required hidden field used when importing translation files. Users can again export and re-import translation files, such as French sales app translations, without encountering the reported error.
Original PR description
There was no indication that the field was needed when it was removed. It is not added automatically by the orm because it is not a depend or an explicit modifier. It is being reintroduced with a comment. Issue: Settings > Translations > Export Translation > Select language as French > PO File > Export type module > Choose sales app as apps to export > Download the file > Import Translation > Add language name > Code fr_FR > Upload file > Overwrite existing terms checked > error message appears. The error was introduced by: https://github.com/odoo/odoo/commit/5639ed865c5a3b82bab25b0ecac28c68c02e9306 opw-4115861 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
ABA batch payment validation now correctly falls back to the standard process when a payment is not related to payroll. This prevents errors during payment file generation and helps Australian payroll/accounting teams process batches reliably.
Original PR description
The `_generate_export_file()` method was updated to handle payroll payments in ABA batch processing. However, the previous implementation lacked a proper fallback to the superclass method when the payment was not a payroll payment, leading to a traceback during ABA batch payment validation. opw-4106377
The Knowledge app comments menu now keeps a cleaner layout when the screen is narrowed. This prevents overlapping controls and makes commenting easier to use on smaller displays.
Original PR description
Steps to reproduce: 1. Open Knowledge 2. Select any text in an article 3. The menu will show 4. Click on comments 5. Write a log and shrink the screen 6. The comments menu breaks 7. The display of comments is a little bit odd Removed 'flex-wrap' from the message header's CSS to prevent the menu from overlapping when the screen size is reduced. This ensures a consistent layout and better user experience on smaller screens. Task-4063810
The Knowledge comments menu now stays properly aligned when the screen is narrowed. This prevents overlapping controls and makes commenting in articles easier to use on smaller displays.
Original PR description
Steps to reproduce: 1. Open Knowledge 2. Select any text in an article 3. The menu will show 4. Click on comments 5. Write a log and shrink the screen 6. The comments menu breaks 7. The display of comments is a little bit odd Removed 'flex-wrap' from the message header's CSS to prevent the menu from overlapping when the screen size is reduced. This ensures a consistent layout and better user experience on smaller screens. Task-4063810