Tuesday, September 3, 2024
10 changes · saas-17.4
Resolved issues and error corrections
Emptying the Discuss inbox no longer leaves a confusing “Jump to present” button on screen. This makes the inbox feel cleaner and avoids distracting users after they mark all messages as read.
Original PR description
Before this commit, when emptying inbox e.g. with "mark all as read" button, Inbox was showing the "Jump to present" at bottom of thread. Steps to reproduce: - With Mitchell Admin: set user…
Before this commit, when emptying inbox e.g. with "mark all as read" button, Inbox was showing the "Jump to present" at bottom of thread. Steps to reproduce: - With Mitchell Admin: set user preferences of notification to "Handle in Odoo" - With Marc Demo: send logged note in contact form view with `@Mitchell Admin` mentions - With Mitchell Admin: open Discuss app inbox then mark all messages as read => There's "Jump to present" at bottom of thread view of inbox This happens because when inbox is empty, it uses a special branching in template to display "Inbox is empty". In this branching, the invisible `span` "present-treshold" is not present, so by it being considered not visible it shows the bar. The `useVisible()` hook was resetting the value of `isVisible` to `false` when the ref.el changes, but it should actually be `undefined`. Which is what this commit fixes. This fixes the issue because condition to show "Jump to Present" relies on specific value `isVisible: false`, therefore `undefined` does not show the "Jump to Present" visual. <img width="982" alt="Screenshot 2024-09-02 at 16 03 08" src="https://github.com/user-attachments/assets/7dcc0e57-1b49-4d95-9dbd-24e76d7733f0">
Marketing card templates now handle longer text more reliably. This prevents text from being cut off or disappearing and ensures backgrounds continue to cover the full card, producing cleaner shared marketing visuals.
Original PR description
There are some layout issues when text is too long in card templates. Make some adjustments so it's better handled (background covers everything, text doesn't disappear beyond the line limit) task-4102438 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix hides profit and loss account fields on bank journals from users who should not see them. It also removes access to Analytic Report and Tax Report menus for non-accountants, reducing confusion and keeping accounting information limited to the appropriate roles.
Original PR description
The profit & loss accounts fields are visible on bank journals with only `account`/`account_accountant` installed. add a groups attribute, to remove these fields remove menus (Analytic Report & Tax Report) that should only be visible to accountants. Task-4130326
Forms opened in pop-up dialogs now wait for users to choose Save or Discard instead of saving changes automatically. This prevents accidental updates and makes the dialog behavior match the visible action buttons.
Original PR description
When a form view is in a dialog, there is a save and discard button. The current implementation would autosave the form. The autosave feature really doesn't make sense in that case. So now, form views in dialog do not autosave. Task ID: 3996654
The Inventory on Hand dashboard has been corrected to use the current product storage indicator. This ensures stock reporting includes the right storable products after a recent underlying product field change.
Original PR description
Since https://github.com/odoo/odoo/pull/165372 , the type = 'product' was replaced by a boolean field `is_storable` but this was not reflected in the dashboard 'Inventory on hand'. task-4154706 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes demo employee contract data so it uses the correct Belgian salary structure type. It prevents access errors when loading or using demo data, making evaluation and testing smoother for users.
Original PR description
In this commit, fixes demo contract assigned with belgian structure type. related task-3596938
This fixes an error that could occur when creating Mexican electronic invoices for down payments without a product. Invoice line names continue to show product names when available, while product-free down payment lines are now handled safely.
Original PR description
Description of the issue this commit addresses: While we tought mx could not have invoices without product, it is actually possible in down payments. Therefore a condition looking for whether there is a product or not is missing in the invoice line name's computation. --- Desired behavior after this commit is merged: The invoice line's name always contains the name of the product just as before but cases where there is no product are handled instead of raising an error. --- Note: While at it, the method computing the name is renamed to better fit the helpers present in the same file. --- opw-4156804
Fixed an issue where users could not start a signature request from the cog menu immediately after creating a new record. The action now uses the updated record information, so the signature workflow launches reliably without needing extra steps.
Original PR description
Before this commit, when a new record was just created, requesting a signature from the cog menu would not call the Signature Request action since we were fetching the record id from the wrong place (controller props). After this commit, when creating a new record, Signature request action is sucessfully called in newly created records since we fetch the record id from the controller state instead, which is mutable to record changes. task-4116177
The payroll setup walkthrough has been corrected to match the current employee contract screen layout. This helps HR users complete the guided process without getting blocked by a field that moved to a different place.
Original PR description
In this PR, fixes payroll tour as hr responsible field moves from notebook to main view. Note: target saas-17.4 related task-3621276
Users can now choose the Quote option from a retweet action without seeing an error. This keeps the social media workflow smoother and prevents interruptions when managing Twitter/X posts in Odoo.
Original PR description
Steps to reproduce: 1. Click on the retweet button. 2. Select Quote. 3. An error occurs. Technical Reason: The 'social.StreamPostCommentsOriginalPost' template receives 'undefined' in the 'state.isEditMode' variable, which is called from 'social_twitter.TwitterQuoteDialog'. After this Commit: No error will occur. Task-4072916