Odoo Changelog — 2024-09-05

Thursday, September 5, 2024

38 changes · saas-17.1

Bug Fixes(2)

Resolved issues and error corrections

[FIX] project: singleton error when view history revision

Coresaas-17.1project

This fixes an error that could appear when users tried to view a previous revision in a project task's history. It helps project teams review task changes without being interrupted by a technical failure.

Original PR description

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#project#task history#revision

[FIX] website_slides: prevent traceback when clicking add tag button

PR #178908

Coresaas-17.1website_slides

Creating a new course and clicking the Add tag button on the website no longer triggers an error. This improves the course setup experience by allowing users to add tags smoothly from the start.

Original PR description

Steps to reproduce:
1. Create a new course
2. Go to front-end.
3. Click on the "Add tag" button.
4. Throws a traceback

Technical Reason:
When creating a website slide for the first time, channelTagIds are undefined, causing JSON.parse to throw an error.

After this Commit:
No traceback will occur.

Task-4154899

#courses#tags#website

Other(36)

Miscellaneous changes

[FW][FIX] account: prevent error while foreign taxes creation

PR #179121

Coresaas-17.1l10n_at

Original PR description

Currently, an error occurs when creating foreign taxes for 'Austria'.

Steps to produce:

- Installing the 'account' module.
- Go to Invoicing / Configuration / Accounting / Fiscal Positions.
- Create a Fiscal Position, Set the Country as 'Austria', and enter an 'FR23334175221'(For example) as 'Foreign Tax ID'.
- And Create the taxes for this country.

Stack Trace:

```
KeyError: 'children_tax_ids'
  File "odoo/http.py", line 2374, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1904, in _serve_db
    return self._transactioning(
  File "odoo/http.py", line 1967, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1934, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 2178, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 755, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 40, in call_button
    action = call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 459, in call_kw
    result = getattr(recs, name)(*args, **kwargs)
  File "addons/account/models/partner.py", line 289, in action_create_foreign_taxes
    self.env["account.chart.template"]._instantiate_foreign_taxes(self.country_id, self.company_id)
  File "addons/account/models/chart_template.py", line 929, in _instantiate_foreign_taxes
    children_taxes = tax_data['children_tax_ids'].split(',')
```

An error occurs when the system tries to get a 'children_tax_ids' key from tax data at [1] while foreign tax creation, But it is not available.

link [1]: https://github.com/odoo/odoo/blob/4c79aceb3a6c08453f9ec66131e1bc525eae140c/addons/account/models/chart_template.py#L936

To resolve the issue, make small changes into tax data where 'amount_type' = 'percent' instead of 'amount_type' ='group'.

Sentry-5730875398

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#178939
Forward-Port-Of: odoo/odoo#178058

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Steps to reproduce: 1. Create a new course 2. Go to front-end. 3. Click on the "Add tag" button. 4. Throws a traceback Technical Reason: When creating a website slide for the first time, channelTagIds are undefined, causing JSON.parse to throw an error. After this Commit: No traceback will occur. Task-4154899

Currently, an error occurs when creating foreign taxes for 'Austria'. Steps to produce: - Installing the 'account' module. - Go to Invoicing / Configuration / Accounting / Fiscal Positions. - Create a Fiscal Position, Set the Country as 'Austria', and enter an 'FR23334175221'(For example) as 'Foreign Tax ID'. - And Create the taxes for this country. Stack Trace: ``` KeyError: 'children_tax_ids' File "odoo/http.py", line 2374, in __call__ response = request._serve_db() File "odoo/http.py", line 1904, in _serve_db return self._transactioning( File "odoo/http.py", line 1967, in _transactioning return service_model.retrying(func, env=self.env) File "odoo/service/model.py", line 134, in retrying result = func() File "odoo/http.py", line 1934, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 2178, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 755, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 40, in call_button action = call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 459, in call_kw result = getattr(recs, name)(*args, **kwargs) File "addons/account/models/partner.py", line 289, in action_create_foreign_taxes self.env["account.chart.template"]._instantiate_foreign_taxes(self.country_id, self.company_id) File "addons/account/models/chart_template.py", line 929, in _instantiate_foreign_taxes children_taxes = tax_data['children_tax_ids'].split(',') ``` An error occurs when the system tries to get a 'children_tax_ids' key from tax data at [1] while foreign tax creation, But it is not available. link [1]: https://github.com/odoo/odoo/blob/4c79aceb3a6c08453f9ec66131e1bc525eae140c/addons/account/models/chart_template.py#L936 To resolve the issue, make small changes into tax data where 'amount_type' = 'percent' instead of 'amount_type' ='group'. Sentry-5730875398 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178939 Forward-Port-Of: odoo/odoo#178058

Version: 16 Description of the issue/feature this PR addresses: A third party check received in a customer payment with journal with type "Cash" and Incoming payment method "New Third Party Checks" is not on hand in menu "Accounting / Customers / Third Party Checks" if journal doesn't has "Existing Third Party Checks" incoming payment method. Steps to reproduce: 1) Log in with admin on runbot odoo enterprise 16 instance and install l10n_latam_check (Third Party and Deferred/Electronic Checks Management) module. 2) Go to "Accounting / Configuration /Accounting / Journals" and create a new journal of type "Cash" and add incoming payment method "New Third Party Checks". ![image](https://github.com/user-attachments/assets/a600542a-8e35-473a-b5a6-66b6d6cbc15b) 3) Create a new customer payment with journal created on step 2 and "New Third Party Checks" payment method and confirm. ![image](https://github.com/user-attachments/assets/4036ef78-03d1-4993-aa66-a49ae7174069) 4) Go to menu Third Party Checks and the check received on step 3 is not on hand. ![image](https://github.com/user-attachments/assets/84fe2ffb-3ce4-42df-9cd6-c31dd81c84dd) Current behavior before PR: A third party check received in a customer payment with journal with type "Cash" and Incoming payment method "New Third Party Checks" is not on hand on tree view in "Accounting / Customers / Third Party Checks" if the journal doesn't has "Existing Third Party Checks" incoming payment method. Desired behavior after PR is merged: A third party check received in a customer payment with journal with type "Cash" and Incoming payment method "New Third Party Checks" is on hand on tree view in "Accounting / Customers / Third Party Checks" if the journal doesn't has "Existing Third Party Checks" incoming payment method. Ticket Adhoc side: 77887 Task Latam side: 1234 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#174283

Currently, a log error is generated when the user tries to import a module that is not the same as the current Odoo version. Stack Trace: ``` ValueError: Invalid version '17.0.1.0.0'. Modules should have a version in format `x.y`, `x.y.z`, `saas~17.2.x.y` or `saas~17.2.x.y.z`. File "addons/base_import_module/models/ir_module.py", line 253, in _import_zipfile self.sudo()._import_module(mod_name, path, force=force, with_demo=with_demo) File "addons/base_import_module/models/ir_module.py", line 81, in _import_module values['latest_version'] = adapt_version(terp['version']) File "odoo/modules/module.py", line 423, in adapt_version raise ValueError(f"Invalid version {base_version!r}. Modules should have a version in format `x.y`, `x.y.z`," ``` The error was caught on log because at [1] `_logger.exception()` was used, and this log error was not useful because after the printing, the log `UserError` was raised, which shows the user what's wrong with its custom module. This commit removes the logger exception because the `UserError` shows what is wrong with the custom modules. [1]-https://github.com/odoo/odoo/blob/b95edd874ce904ef231c295790a003992db002e3/addons/base_import_module/models/ir_module.py#L255-L258 sentry-4931285432 Forward-Port-Of: odoo/odoo#160274

[FIX] website_sale: Avoid collect sale orders confirmed in backend This happens when, during a payment process, when the order is confirmed from the backend and in Website the cart icon is clicked. What causes the error is that the request is still pinned in the session, so it identifies that certain values should not be loaded and deletes them. The cart() method identifies if it's not a draft order, and in that case it clears the session order to continue with a new one. That causes undesired modifications in modules that inherit cart() and execute before calling super(), such as website_sale_delivery, that removes carrier from order. With this motification the method sale_get_order() will now discriminate the orders that are completed and clear ir from the session, avoiding losses of information. Description of the issue/feature this PR addresses: This error was detected because the carrier_id was eliminated when following the aforementioned flow. The problem is that clicking on the cart retrieves the order that is in the session, but if it has been confirmed from the backend it should not collect it since at that moment it is not a "cart". A way to see this clearly is with the 'delivery_auto_refresh' module. This module shows the carrier_id field in sale order view (that exists but is not visible), which is collected at website. The flow that exists nowadays remove this value when we follow this steps: [Grabación de pantalla desde 16-08-24 10:41:50.webm](https://github.com/user-attachments/assets/9ec82b67-3e73-4083-b65b-be8d59db6a5a) In this video: 1. Customer starts an order 2. An user confirms the order at backend 3. Customer acceses to /shop/cart 4. Some fields of the sale order can be deleted, such as the delivery carrier If we confirm the order at backend and then follow the flow shown, the value of this field will dissapear. This happens because, as I said before, clicking the cart icon recovers the confirmed sale order (which is no longer a 'cart') and deletes many values of it. Current behavior before PR: If you confirm an order in process from website at backend and then click on the cart icon, certain fields are eliminated. Desired behavior after PR is merged: The cart button identifies whether the order is in confirmed status (or quote sent), and if so removes it from the session before the fields are cleared, thus starting a new order. FL-650-982 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178953 Forward-Port-Of: odoo/odoo#176718

When the user tries to unarchive the multiple views, a traceback will appear. Steps to reproduce the error: - Install 'website' - Go to Settings > Technical > Views - Open archived views > unarchive multiple views Traceback: ``` ValueError: Expected singleton: ir.ui.view(534, 535, 537) File "odoo/http.py", line 2248, in __call__ response = request._serve_db() File "odoo/http.py", line 1823, in _serve_db return self._transactioning(_serve_ir_http, readonly=ro) File "odoo/http.py", line 1843, in _transactioning return service_model.retrying(func, env=self.env) File "odoo/service/model.py", line 134, in retrying result = func() File "odoo/http.py", line 1821, in _serve_ir_http return self._serve_ir_http(rule, args) File "odoo/http.py", line 1828, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 2053, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 220, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 756, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 38, in call_kw return self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 34, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 458, in call_kw result = getattr(recs, name)(*args, **kwargs) File "odoo/models.py", line 5771, in action_unarchive return self.filtered(lambda record: not record[self._active_name]).toggle_active() File "odoo/models.py", line 5759, in toggle_active (self - active_recs)[self._active_name] = True File "odoo/models.py", line 6619, in __setitem__ return self._fields[key].__set__(self, value) File "odoo/fields.py", line 1376, in __set__ records.write({self.name: write_value}) File "addons/website/models/theme_models.py", line 366, in write return super().write(vals) File "addons/website/models/ir_ui_view.py", line 95, in write return super(View, self).write(vals) File "odoo/addons/base/models/ir_ui_view.py", line 529, in write self._validate_fields(['arch_db']) File "odoo/models.py", line 1484, in _validate_fields check(self) File "odoo/addons/base/models/ir_ui_view.py", line 371, in _check_xml view=self.key or self.id, File "odoo/fields.py", line 1202, in __get__ record.ensure_one() File "odoo/models.py", line 5856, in ensure_one raise ValueError("Expected singleton: %s" % self) ``` https://github.com/odoo/odoo/blob/9be0c5348bfeb338bcba95b2a9c01e0d7dd14306/odoo/addons/base/models/ir_ui_view.py#L379 Here, self is used in place of view. So it will lead to the above traceback. sentry-5604174783 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173117

Steps to reproduce: - Settings > Enable 'Consolidate subscriptions billing' - Contact > Create a company - Contacts & Addresses tab > Add - Add an invoice address on the company - Add an individual then duplicate it - Create a subscription with the indiviual as customer - Duplicate the subscription then set the duplicate contact as customer - Debug mode > Scheduled actions - Sale subscription: Generate recurring invoices and payments > Run manually The subsciptions are invoiced separately instead of having one invoice for both. The consolidated billing should produce only one invoice since the invoicing address is the same. This behavior works as intended if using the create invoices action on both subscriptions at once. Here, the recurring invoice creation for subscriptions uses its own grouping function using partner_id as a key instead of partner_invoice_id which is 'parent invoice address id if any, else partner_id'. Because this grouping is performed before creating the invoices, we end up processing sale orders that should have belonged to the same group separarately and thus create the invoices one by one. This means we don't let _create_invoices do the grouping since we only pass it one SO at a time, this fix will make it so _create_invoices is called on the grouped SOs instead. opw-4114035 Forward-Port-Of: odoo/enterprise#69277

Before this PR: There are two problems: first, if you have a line discount like this: <img width="350" alt="Captura de pantalla 2024-03-27 a la(s) 09 48 55" src="https://github.com/odoo/enterprise/assets/382893/7564b133-c6e9-4bab-97f3-d8a0a2634fe5"> The calculation made by Odoo is: 319319 * 21.35 / 100 = 68175 which does not match the amount placed in "DescuentoMonto". In this case, it is 68173 (difference of 2 CLP) which is why it is better to prioritize the discount amount instead of the percentage in the XML, which is already rounding, leading to a problem. The second: if you have a surcharge in the line, like this: <img width="354" alt="Captura de pantalla 2024-03-27 a la(s) 09 52 40" src="https://github.com/odoo/enterprise/assets/382893/5a7ffa96-a2d9-498f-acf3-7003c95aa789"> Odoo ignores it. After the PR: The first issue is fixed by giving priority to the "DescuentoMonto" tag. The second issue is added as an improvement. Since Odoo does not have a column to show the surcharge separated in the line, we are taking advantage of the feature that supports negative discounts in the line to put that surcharge as negative. Forward-Port-Of: odoo/enterprise#65842 Forward-Port-Of: odoo/enterprise#59532

Bug Fixes(2)

[FIX] project: singleton error when view history revision

[FIX] website_slides: prevent traceback when clicking add tag button

Other(36)

[FW][FIX] account: prevent error while foreign taxes creation

Bug Fixes(2)

[FIX] project: singleton error when view history revision

[FIX] website_slides: prevent traceback when clicking add tag button

Other(36)

[FW][FIX] account: prevent error while foreign taxes creation

[FW][15.0][IMP] calendar: Send reminder to all attendees (even if one of them is the organizer)

[FW][FIX] l10n_it_edi_ndd: community bug

[FW][FIX] website: fix highlighted text added to view

[FW][FIX] website_sale_stock_wishlist: "Temporarily out of stock"

[FW][FIX] website_sale: save phone on shipping address in express checkt

[FW][FIX] payment_(adyen,stripe): map the Cash App Pay PM to the correct code

[FW][FIX] sale, sale_loyalty: refine the sale_order_line domain

[FW][FIX] web: list: clarify "select all" feature

[FW][FIX] l10n_latam_check: received third party check not "on hand"

[FW][FIX] account: Catching TaxClosingNonPostedDependingMovesError when p…

[FW][FIX] account: report field availability_condition should be set to country only if country_id is set

[FW][FIX] account: Write onboarding step with sudo

[FW][FIX] l10n_be_pos_sale: force invoice for intracom

[FW][FIX] hr_expense: add tags to caba taxes in company expenses

[FW][FIX] base_import_module: remove logger exception

[FW][FIX] point_of_sale: raise a warning when opening session with superuser

[FW][REF] hw_drivers: save iot config files in odoo.conf

[FW][FIX] website_sale_delivery: Avoid collect sale orders confirmed in backend

[FW][ADD] l10n_kw: Add localization package for kuwait

[FW][FIX] mail: bring activity highlight back

[FW][FIX] website_sale: ecommerce categories margin behavior on hover

[FW][FIX] base: prevent singletonerror when unarchiving views

[FW][FIX] l10n_fr_invoice_addr: Correct print format for the Customer Address column

[FW][IMP] l10n_pe_reports: Add support for CAR in journal

[FW][FIX] documents: preview closes when adding tags

[FW][FIX] l10n_es_reports: do not impact all countries for generic tax

[FW][FIX] sale_subscription: consolidate billing by invoice address

[FW][REF] account_reports: Moved TaxClosingNonPostedDependingMovesError to account

[FW][FIX] industry_fsm_sale : Avoid modifying invoice_status after invoicing SO

[FW][FIX] industry_fsm_sale: modify the so item domain

[FW][FIX] l10n_cl_edi: fix line discounts giving priority for discount am…

[FW][IMP] pos_iot: add module icon

[FW][FIX] l10n_fr_fec_import: enable importing partner with same name

[FW][ADD] l10n_uy_edi: new module

[FW][FIX] account_reports: allow Monaco to be considered in the EC list