Monday, September 9, 2024
36 changes · saas-17.2
Enhancements to existing features
This update refreshes internal automated tests for planning holidays and Gantt scheduling tools to make them easier to read and broaden validation of newer test helper behavior. There is no expected direct change for end users, but it helps maintain product quality and reduces risk in future updates.
Original PR description
New PR: https://github.com/odoo/enterprise/pull/69728
The Australian payroll accounting module now allows for the additional database queries introduced by recent payroll field calculations. This keeps automated performance checks aligned with the current system behavior and helps prevent false test failures.
Original PR description
In this pr: https://github.com/odoo/odoo/pull/171795 we added some computed fields which caused an increase on the query count of the l10n_au_hr_payroll_account module, this commit will increase that. task: 4127269
This update moves Odoo's web test pages to the newer testing system and keeps legacy test pages available separately. It also fixes several testing-tool behaviors around clicks, touch events, screen sizing, and sidebar layout, helping teams validate web changes more reliably.
Original PR description
New PR: https://github.com/odoo/odoo/pull/179660
Resolved issues and error corrections
Worksheet template generation now records identifiers for generated fields, matching how generated models are already handled. This makes future module imports and updates more reliable by allowing those fields to be found and updated consistently.
Original PR description
When a worksheet template is generated, it creates models and fields but only registers xmlids for the models. This inconsistency makes it harder to updated those fields when importing a module. This commit simply registers the xmlids for the fields as well.
Miscellaneous changes
Description: - This PR introduces an Rs. 1 tolerance for amount matching to prevent unnecessary bill creation for minor discrepancies (e.g., paisa differences). It also improves bill reference number matching by handling special characters and comparing numerically as text. Impact: - Reduces unnecessary bill creation. - Enhances accuracy in matching bill reference numbers. Task ID: 3975209 Forward-Port-Of: odoo/enterprise#66121
Original PR description
Description: - This PR introduces an Rs. 1 tolerance for amount matching to prevent unnecessary bill creation for minor discrepancies (e.g., paisa differences). It also improves bill reference number matching by handling special characters and comparing numerically as text. Impact: - Reduces unnecessary bill creation. - Enhances accuracy in matching bill reference numbers. Task ID: 3975209 Forward-Port-Of: odoo/enterprise#66121
A missing print reference was added to IoT print requests sent through the live messaging service. This prevents errors when printing and helps keep printer workflows reliable for users.
Original PR description
Starting as from `saas-17.2`, PrinterDriver's default action requires a `print_id`, which was not provided by the longpolling service action method. We added the missing parameter to avoid the traceback created by this error.
This update adds automated tests for inter-company purchase-to-sales flows. It helps ensure related company transactions continue to work correctly after recent underlying changes, reducing the risk of regressions.
Original PR description
Add tests for the community side changes in https://github.com/odoo/odoo/pull/167235, as these changes mostly impact inter-company transaction flows. task-3853055
Updates the website editor's automated checks to better catch issues during page editing. This helps reduce the chance of regressions reaching users and supports more reliable website publishing workflows.
Original PR description
TODO runbot-60056
The /help command in Discuss now includes canned response guidance, matching the behavior users already had in live chat. This makes the feature easier to discover and use wherever canned responses are available.
Original PR description
Since the canned response settings is introduced in Discuss, the usage of canned responses is not limited to livechat only, so that the /help message should be available in the Disucss as well. after:  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Odoo now handles mailing list contacts without a name when an email fails to send. This prevents a traceback when users open the contact record after a failed mailing, improving reliability for mass mailing workflows.
Original PR description
Steps to reproduce: --- 1. Install mass_mailing 2. Create a wrong outgoing mail server 3. ip 127.0.0.1 port 1234 4. Create a mailing list 5. Create a mailing list contact without name 6. Make the contact join the list 7. Create a mailing, set the new mailing list 8. Click on send > "1 email(s) not sent." 9. Open the mailing list contact 10. Traceback Cause of the issue: --- Caused by: https://github.com/odoo/odoo/commit/5102328c3dd6e4e751ca8f906e7bd16e190fc386 `this.originThread?.name` can be `False` instead of `Undefined` opw-4054564 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Before this commit: When a user with Billings rights scans a QR code using the vendor QR scan feature, an ir.act.window access error appears. After this commit: We fix the access error. And the QR scan feature works correctly as intended. Forward-Port-Of: odoo/enterprise#69700
Original PR description
Before this commit: When a user with Billings rights scans a QR code using the vendor QR scan feature, an ir.act.window access error appears. After this commit: We fix the access error. And the QR scan feature works correctly as intended. Forward-Port-Of: odoo/enterprise#69700
### Steps to reproduce: - Enable packages in the inventory settings - Create a storable product tracked by Lot and put 4 units in stock: - 2 Units for "LOT001" - 2 Units for "LOT002" - Create and confirm a sale order for 2 units - Go to the barcode app > Operations > Delivery orders > your Delivery Order - Register "LOT002" manually > One unit will be added to your delivery moves. - Put in pack > You can unroll the move to see that one move line was created for 1 unit with a package a
Original PR description
### Steps to reproduce: - Enable packages in the inventory settings - Create a storable product tracked by Lot and put 4 units in stock: - 2 Units for "LOT001" - 2 Units for "LOT002" - Create and…
### Steps to reproduce: - Enable packages in the inventory settings - Create a storable product tracked by Lot and put 4 units in stock: - 2 Units for "LOT001" - 2 Units for "LOT002" - Create and confirm a sale order for 2 units - Go to the barcode app > Operations > Delivery orders > your Delivery Order - Register "LOT002" manually > One unit will be added to your delivery moves. - Put in pack > You can unroll the move to see that one move line was created for 1 unit with a package and 1 unit is still missing. - Register a second unit of "LOT002" manually to put in an other pack > The line is updated to 2 units instead of 1 so that the additional unit can not be packed in an other pack ### Expected behavior: You should be able to pack units of the same lot in different packages. ### Cause of the issue: To determine which line is going to be updated by our lot registration the `_findLine` method is called. This method look for each line in pageLines and when it finds a candidate move line it continues to find a better candidate. However, fully packed moves should not be considered as valid candidates. opw-4068334 Forward-Port-Of: odoo/enterprise#69022 Forward-Port-Of: odoo/enterprise#68535
Forward-Port-Of: odoo/enterprise#69591
Original PR description
Forward-Port-Of: odoo/enterprise#69591
Issue ----- [website_sale_renting] In case there is already a rental product in the cart, it is still possbile to open the date range picker by clicking the calendar button and selecting a new period, which will have no effect as the rental period can only be changed from the cart. Change ----- Disable the date picker but keep the calendar button as it contains a help message. opw-4076088 Forward-Port-Of: odoo/enterprise#67645
Original PR description
Issue ----- [website_sale_renting] In case there is already a rental product in the cart, it is still possbile to open the date range picker by clicking the calendar button and selecting a new period, which will have no effect as the rental period can only be changed from the cart. Change ----- Disable the date picker but keep the calendar button as it contains a help message. opw-4076088 Forward-Port-Of: odoo/enterprise#67645
The CAR (Código de Anotación de Registro) is an alphanumeric identifier composed of payment voucher data. It includes: - RUC number of the issuer: 11 numeric digits. - Type of payment voucher: 2 numeric digits. - Payment voucher series: 4 alphanumeric digits. - Payment voucher number: 10 alphanumeric digits.  Previously, support for SIRE reports was added. This change updates the general ledger t
Original PR description
The CAR (Código de Anotación de Registro) is an alphanumeric identifier composed of payment voucher data. It includes: - RUC number of the issuer: 11 numeric digits. - Type of payment voucher: 2…
The CAR (Código de Anotación de Registro) is an alphanumeric identifier composed of payment voucher data. It includes: - RUC number of the issuer: 11 numeric digits. - Type of payment voucher: 2 numeric digits. - Payment voucher series: 4 alphanumeric digits. - Payment voucher number: 10 alphanumeric digits.  Previously, support for SIRE reports was added. This change updates the general ledger to ensure compatibility. Adjusted the format of the 'book' field to include zero-padded and truncated document types, series, and folio numbers. Legal reference: https://www.sunat.gob.pe/legislacion/superin/2021/anexo-112-2021.pdf  Resolutions: [Resolución de Superintendencia N.° 112-2021](https://drive.google.com/file/d/19iWgqTeTn5WNIg3RpfAyHtF6xSIFL2rH/view?usp=sharing) Forward-Port-Of: odoo/enterprise#68808 Forward-Port-Of: odoo/enterprise#67911
Since the convertion of the gantt view to OWL in saas-16.1 the search_default_* type context is no longer passed from the gantt view to the gantt.form dialog window of a record, thus the "I am unavailable" button couldn't appear anymore replaced the search_default domain by 'my_planning_action' in planning gantt view and transmited the corresponding context through the openDialog method in the planning_gantt_controller Task-3819134 Forward-Port-Of: odoo/enterprise#59226
Original PR description
Since the convertion of the gantt view to OWL in saas-16.1 the search_default_* type context is no longer passed from the gantt view to the gantt.form dialog window of a record, thus the "I am unavailable" button couldn't appear anymore replaced the search_default domain by 'my_planning_action' in planning gantt view and transmited the corresponding context through the openDialog method in the planning_gantt_controller Task-3819134 Forward-Port-Of: odoo/enterprise#59226
Steps to reproduce: [l10n_be] - Create a customer from Spain with the following VAT: A12345674 - Create an invoice with the customer - Go to EC Sales report Issue: The country code used in the report is "A1" Solution: Instead of inferring the country code from the VAT, we use the country code per se; to be a bit more defensive we fall back on the initial flow in case there is no country code. opw-4080828 Forward-Port-Of: odoo/enterprise#69125
Original PR description
Steps to reproduce: [l10n_be] - Create a customer from Spain with the following VAT: A12345674 - Create an invoice with the customer - Go to EC Sales report Issue: The country code used in the report is "A1" Solution: Instead of inferring the country code from the VAT, we use the country code per se; to be a bit more defensive we fall back on the initial flow in case there is no country code. opw-4080828 Forward-Port-Of: odoo/enterprise#69125
When exporting GL in datev format, the receivable/payable accounts were not well formatted. Steps: - duplicate the Receivable Account (A) - create a customer C with receivable set as A - create and confirm an invoice for C - go to GL and export datev file -> column konto is account code of A, it should be 1000000 + C.id, according to datev (starting by 1 for customers and 7 for Vendors) Before this commit, we were making the distinction between the customers that had the "original" rece
Original PR description
When exporting GL in datev format, the receivable/payable accounts were not well formatted. Steps: - duplicate the Receivable Account (A) - create a customer C with receivable set as A - create and confirm an invoice for C - go to GL and export datev file -> column konto is account code of A, it should be 1000000 + C.id, according to datev (starting by 1 for customers and 7 for Vendors) Before this commit, we were making the distinction between the customers that had the "original" receivable account and the others, and we were displaying the account code in the second case. It should be the datev format in any case. opw-4117993 Forward-Port-Of: odoo/enterprise#69573
This PR fixes a wrong documentation link in the helpdesk team form view. Task-4102472 Forward-Port-Of: odoo/enterprise#68101
Original PR description
This PR fixes a wrong documentation link in the helpdesk team form view. Task-4102472 Forward-Port-Of: odoo/enterprise#68101
If we have two bills with the same bill ref and two different partner, one with NIF and the other without it, the schedule action to process SII response might fail since the code expect a NIF in the SII response when there is not (bill with partner without NIF). Technical example: ```py >>> partner_info # Candidate invoice in odoo {'IDOtro': {'ID': 'NO_DISPONIBLE', 'IDType': '06', 'CodigoPais': 'ES'}} >>> respl_partner_info # SII response {'NIF': '12345678K', 'IDOtro': None} ``` This
Original PR description
If we have two bills with the same bill ref and two different partner, one with NIF and the other without it, the schedule action to process SII response might fail since the code expect a NIF in the…
If we have two bills with the same bill ref and two different partner, one with NIF and the other without it, the schedule action to process SII response might fail since the code expect a NIF in the SII response when there is not (bill with partner without NIF).
Technical example:
```py
>>> partner_info # Candidate invoice in odoo
{'IDOtro': {'ID': 'NO_DISPONIBLE', 'IDType': '06', 'CodigoPais': 'ES'}}
>>> respl_partner_info # SII response
{'NIF': '12345678K', 'IDOtro': None}
```
This causes a rollback and no bills at all are processed in Odoo's side.
Steps to reproduce:
1/ Create a l10n_es company with l10n_es_edi_sii in test mode
2/ Create a bill with a bill reference 10001, some lines (ex: negative lines)
that will trigger an error from SII and a partner with a NIF
3/ Copy the partner and remove the NIF
4/ Copy the first bill, keep the same bill reference and change the partner to
copied one
5/ Post both bills
6/ Trigger the schedule action "EDI : Perform web services operations" => Traceback with
ValueError: <class 'AttributeError'>: "'NoneType' object has no attribute 'ID'" while evaluating
Now, a default value is set when the key is not found in respl_partner_info.IDOtro .
opw-4102638
Forward-Port-Of: odoo/odoo#177902Currently, when adding product rewards to an order, you are rewarded with the maximum amount of products you can get with you current points. If you change the quantity of the reward product, the reward lines does not update. Steps to reproduce: ------------------- * Go to the **Point of sale** App * Open Shop session * Select a customer that has plenty of loyalty points * Put any product in the order * Add the reward `Simple pen` (you'll havelike 230 of them) * Try changing the reward
Original PR description
Currently, when adding product rewards to an order, you are rewarded with the maximum amount of products you can get with you current points. If you change the quantity of the reward product, the…
Currently, when adding product rewards to an order, you are rewarded with the maximum amount of products you can get with you current points. If you change the quantity of the reward product, the reward lines does not update. Steps to reproduce: ------------------- * Go to the **Point of sale** App * Open Shop session * Select a customer that has plenty of loyalty points * Put any product in the order * Add the reward `Simple pen` (you'll havelike 230 of them) * Try changing the reward quantity to 1 > Observation: The quantity of the simple pen changes to 1 but the negative reward line still shows 230. Thus, the order can have a negative amount since 229 pens are still being deducted from the order even though they are not present. Why the fix: ------------ This commit https://github.com/odoo/odoo/commit/de45ff3c9f23decdab176bc1511b3356d19844a8 passes the quantity and cost (in points) to the `_applyReward` function. This was done because when recomputing reward lines, if two lines came from the same reward, the quantity would be merged even though they would not apply on the same product. In our case, this causes problems as we are using the function `_getRewardLineValuesProduct` to update the reward quantity but the quantity (230) is given as an argument and is then used as the quantity to set. https://github.com/odoo/odoo/blob/775827b8f7fa95f2afd77a9b42d6cd8e436ea690/addons/pos_loyalty/static/src/overrides/models/loyalty.js#L1548-L1566 `args["quantity"] || freeQuantity` will always use `args["quantity"]` if given, bypassing the maximum quantity that is available to give. `freeQuantity || args["quantity"]` will never use `args["quantity"]`. Since we do not want to reward more than what is available, we add the arguments inside the `Math.min` function. opw-4103833 Forward-Port-Of: odoo/odoo#178805
Current behavior before PR: 1. When we attempt to paste an H1 element into a P element, the H1 element gets converted to a P element. 2. When pasting from GDocs, nested UL or OL is a direct child of its parent UL or OL, rather than being child of LI with class `oe-nested`. 3. Copy/pasting multiple paragraphs into a list does not convert it to list. 4. When pasting content that begins with a list and includes other tags below it into a new list, only the list is pasted, resulting in a loss
Original PR description
Current behavior before PR: 1. When we attempt to paste an H1 element into a P element, the H1 element gets converted to a P element. 2. When pasting from GDocs, nested UL or OL is a direct child of…
Current behavior before PR: 1. When we attempt to paste an H1 element into a P element, the H1 element gets converted to a P element. 2. When pasting from GDocs, nested UL or OL is a direct child of its parent UL or OL, rather than being child of LI with class `oe-nested`. 3. Copy/pasting multiple paragraphs into a list does not convert it to list. 4. When pasting content that begins with a list and includes other tags below it into a new list, only the list is pasted, resulting in a loss of the other content. 5. Copy/pasting one list over another bullets does not get transformed. 6. When copying a checklist from Google Docs, the check options are pasted as images. Desired behavior after PR is merged: 1. When we attempt to paste an H1 element onto a P element, the H1 element will remain as an H1 element. 2. When pasting from GDocs, nested UL or OL are contained within an LI element with class `oe-nested`. 3. Copy/pasting multiple paragraphs into a list gets converted to list. 4. Pasting content with a list and other tags should no longer result in the loss of content. 5. Copy/pasting one list over another bullets get transformed. 6. Check options copied as image from Google Docs will no longer be pasted as images; instead the images should be removed and class `o_checklist` should be add to the closest list. task-2956048 Co-authored-by: Deependra Solanki <deso@odoo.com> --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179159 Forward-Port-Of: odoo/odoo#115019
Partners can have multiple Bank accounts in an active database, some being even added automatically on Bank reconciliation. But usually, only some specific accounts that are used for outgoing payments will be marked as "trusted". Currently, when you select a Vendor on a draft Vendor Bill, the first account of the partner is taken, whether or not the account is trusted. This Pr will give priority to the accounts that are trusted. task: 4166740 --- I confirm I have signed the CLA a
Original PR description
Partners can have multiple Bank accounts in an active database, some being even added automatically on Bank reconciliation. But usually, only some specific accounts that are used for outgoing payments will be marked as "trusted". Currently, when you select a Vendor on a draft Vendor Bill, the first account of the partner is taken, whether or not the account is trusted. This Pr will give priority to the accounts that are trusted. task: 4166740 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179365
Steps to reproduce: * install `l10n_mx` * Create a partner * duplicate it * upload an invoice/bill xml with the duplicated partner Issue: A new duplication of the partner will be created Cause: If no partner is found, we will create another one https://github.com/odoo/enterprise/blob/c66a452661c1e5ff9f837e7e1e21e068fec4c124/l10n_mx_edi/models/account_move.py#L2524-L2545 Solution: The VAT should be a sufficiently distinctive criterion to link a partner Ticket [link](https://www
Original PR description
Steps to reproduce: * install `l10n_mx` * Create a partner * duplicate it * upload an invoice/bill xml with the duplicated partner Issue: A new duplication of the partner will be created Cause: If no partner is found, we will create another one https://github.com/odoo/enterprise/blob/c66a452661c1e5ff9f837e7e1e21e068fec4c124/l10n_mx_edi/models/account_move.py#L2524-L2545 Solution: The VAT should be a sufficiently distinctive criterion to link a partner Ticket [link](https://www.odoo.com/odoo/project/967/tasks/4124253) opw-4124253 Forward-Port-Of: odoo/odoo#178078
This commit fixes the error that was triggered when trying to assign a responsible user for a picking batch from the kanban view of batches. The error was thrown because the `user_id` field depends on `company_id` field in its domain, which was not existent in the kanban view. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179179
Original PR description
This commit fixes the error that was triggered when trying to assign a responsible user for a picking batch from the kanban view of batches. The error was thrown because the `user_id` field depends on `company_id` field in its domain, which was not existent in the kanban view. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179179
Issue : 17.0 When a global discount is applied on a sale order with tax included in the price, the discount was incorrectly calculated based on the tax-excluded price. This resulted in inaccurate discount amounts and incorrect tax calculations. steps to reproduce: - Create a tax with included in price (e.g. 10% incl). - Create a sale order with the 10% incl tax. - Now, apply a global discount (e.g. 10%) Cause : When applying a global discount, the system incorrectly calculates the d
Original PR description
Issue : 17.0 When a global discount is applied on a sale order with tax included in the price, the discount was incorrectly calculated based on the tax-excluded price. This resulted in inaccurate discount amounts and incorrect tax calculations. steps to reproduce: - Create a tax with included in price (e.g. 10% incl). - Create a sale order with the 10% incl tax. - Now, apply a global discount (e.g. 10%) Cause : When applying a global discount, the system incorrectly calculates the discount based on the tax-excluded price rather than the unit price. Fix : Ensure the total amount is calculated useing price_unit(price_unit) instead of subtotal. This corrects the discount application and maintains accurate pricing. opw-4018841 Forward-Port-Of: odoo/odoo#174678
Steps to reproduce ================== - Go to Sales > Quotation - Open any record - Open studio - Switch to the x2many list view - Insert a new html field - Exist studio - Type some text in the html field - Select a portion of it - Click on the bold button => Nothing happens Solution ======== Don't unselect the current row when clicking inside the editor toolbar opw-4064662 Forward-Port-Of: odoo/odoo#178189 Forward-Port-Of: odoo/odoo#175880
Original PR description
Steps to reproduce ================== - Go to Sales > Quotation - Open any record - Open studio - Switch to the x2many list view - Insert a new html field - Exist studio - Type some text in the html field - Select a portion of it - Click on the bold button => Nothing happens Solution ======== Don't unselect the current row when clicking inside the editor toolbar opw-4064662 Forward-Port-Of: odoo/odoo#178189 Forward-Port-Of: odoo/odoo#175880
We don't need `point_of_sale` module on the IoT Box: we only need configuration files in it. We don't load it anymore to prevent from having error messages on service start. We also added a new alias to simplify pip usage and removed unused pyotp package. Forward-Port-Of: odoo/odoo#179308
Original PR description
We don't need `point_of_sale` module on the IoT Box: we only need configuration files in it. We don't load it anymore to prevent from having error messages on service start. We also added a new alias to simplify pip usage and removed unused pyotp package. Forward-Port-Of: odoo/odoo#179308
Before this commit, copying an automation rule did not copy its actions. After, it will. Task: 4055597 Forward-Port-Of: odoo/odoo#179350
Original PR description
Before this commit, copying an automation rule did not copy its actions. After, it will. Task: 4055597 Forward-Port-Of: odoo/odoo#179350
### Description of the issue/feature this PR addresses: Wrong account on tax definition. Taxes should not have related payable and receivable accounts. ### Current behavior before PR: VAT 0% Exempt taxes has a payable account, this not valid one and will result on error when creating an invoice with that tax. We resolve the problem by changing the account used on the tax definition with new accounts, one for Sales (Current liabilities) and another for Purchase (Current Aseste), the sam
Original PR description
### Description of the issue/feature this PR addresses: Wrong account on tax definition. Taxes should not have related payable and receivable accounts. ### Current behavior before PR: VAT 0% Exempt taxes has a payable account, this not valid one and will result on error when creating an invoice with that tax. We resolve the problem by changing the account used on the tax definition with new accounts, one for Sales (Current liabilities) and another for Purchase (Current Aseste), the same way is made for the VAT 22% and VAT 10%) ### Desired behavior after PR is merged: Taxes has the proper account and we are able to create invoices/bills with tax 0% without problem ADHOC ticket 76475 - task 34060 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170773
In makeAsyncHandler and makeButtonHandler have been modified in commit fcb16a3b1bd373726ffb54f0fbe41fb6d1784769 to remove guardedCatch. However, in both cases, if result is rejected, Promise.resolve(result) will (quite unexpectedly because of the name of the method) be rejected too. Calling finally on this promise will indeed call the callback, but it will still let the exception bubble up, eventually resulting in a second unhandledrejection for the same original exception. With this commi
Original PR description
In makeAsyncHandler and makeButtonHandler have been modified in commit fcb16a3b1bd373726ffb54f0fbe41fb6d1784769 to remove guardedCatch. However, in both cases, if result is rejected,…
In makeAsyncHandler and makeButtonHandler have been modified in commit fcb16a3b1bd373726ffb54f0fbe41fb6d1784769 to remove guardedCatch. However, in both cases, if result is rejected, Promise.resolve(result) will (quite unexpectedly because of the name of the method) be rejected too. Calling finally on this promise will indeed call the callback, but it will still let the exception bubble up, eventually resulting in a second unhandledrejection for the same original exception. With this commit, we instead call then(callback, callback) on that Promise, so that the rejection is caught and callback is indeed called in both cases. To reproduce this issue in saas-17.4, raise a UserError in the route /website_sale/should_show_product_configurator and add a Drawer to your cart: the exception message is displayed twice. This reproduction doesn't work in 17.0 because the promise is a dialog.opened() that crashes and never resolves, masking the issue (but there is a hint of this, because the loading effect is also never removed from the button (meaning that the callback of makeButtonHandler is never called). Many thanks to MCM to help me understand what was happening here. Forward-Port-Of: odoo/odoo#179512
[FIX] project: restrict access to project in email sent Before this commit, when the `Project Stages` feature is enabled and the user set an email template on a project stage, if the user moves a project to that stage with the email template, an email is sent to the customer (if set on the project) and the customer can click on the project name to see all tasks inside that project even if the project is private. This commit makes sure the project name displayed in the template is only
Original PR description
[FIX] project: restrict access to project in email sent Before this commit, when the `Project Stages` feature is enabled and the user set an email template on a project stage, if the user moves a…
[FIX] project: restrict access to project in email sent Before this commit, when the `Project Stages` feature is enabled and the user set an email template on a project stage, if the user moves a project to that stage with the email template, an email is sent to the customer (if set on the project) and the customer can click on the project name to see all tasks inside that project even if the project is private. This commit makes sure the project name displayed in the template is only clickable is the project visibility is 'portal' (`Invited portal users and all internal users`). Steps to reproduce: ------------------ 1. Install project 2. Go to Project > Configuration > Settings 3. Enable Project Stages feature 4. Set email template to project stage 5. Create a project with a customer set and project visibility is not set to "Invited portal users and all internal users". 6. Move the project to the project stage with the email template set. Current behavior: ---------------- An email is sent based on the email template set but the project name is clickable to allow the customer to see the tasks of the project in the portal even if the project is not public. Expected behavior: ----------------- The project name should not be clickable inside the email sent when the project visibility is not "Invited portal users and all internal users". Close #175396 Forward-Port-Of: odoo/odoo#178260 Forward-Port-Of: odoo/odoo#178171
Following commit https://github.com/odoo/odoo/pull/171765/files# multi-currencies are not supported anymore by our edi engine. Using a currency other than euro leads to an invalid XML file. Steps to reproduce: 1. install Italian E-invoicing 2. make sure your have access to another currency, along with EUR 3. create a partner outside of Europe (e.g. US-based - using USD) 4. create an invoice for that partner 5. confirm + send and print the invoice (generate XML file) 6. go to https
Original PR description
Following commit https://github.com/odoo/odoo/pull/171765/files# multi-currencies are not supported anymore by our edi engine. Using a currency other than euro leads to an invalid XML file. Steps to reproduce: 1. install Italian E-invoicing 2. make sure your have access to another currency, along with EUR 3. create a partner outside of Europe (e.g. US-based - using USD) 4. create an invoice for that partner 5. confirm + send and print the invoice (generate XML file) 6. go to https://www.fatturacheck.it/ to verify the XML 7. Error 2.2.2.5 should be returned opw-4038850 opw-4129380 opw-4123758 opw-4095910 Forward-Port-Of: odoo/odoo#175996
### Steps to reproduce: - In the settings: - Change the Barcode Nomenclature to Default gs1 - Enable Promotions, Coupons, ... on Point of sale - Create a prodcut with barcode 95412427100283 - Point of Sale > Product > Discount & Loyalty - Create a new discount and change the conditional rule to set your product and a min purchase of 0 - Open a new pos session - Scan the gs1 barcode 0195412427100283 #### > the product is found but the discount is not applied ### Expected behav
Original PR description
### Steps to reproduce: - In the settings: - Change the Barcode Nomenclature to Default gs1 - Enable Promotions, Coupons, ... on Point of sale - Create a prodcut with barcode 95412427100283 - Point…
### Steps to reproduce: - In the settings: - Change the Barcode Nomenclature to Default gs1 - Enable Promotions, Coupons, ... on Point of sale - Create a prodcut with barcode 95412427100283 - Point of Sale > Product > Discount & Loyalty - Create a new discount and change the conditional rule to set your product and a min purchase of 0 - Open a new pos session - Scan the gs1 barcode 0195412427100283 #### > the product is found but the discount is not applied ### Expected behavior: Just as if you scanned the barcode 95412427100283 directly the discount should be applied. Cause of the issue: When a barcode is scanned in the pos, the ` _scan` method is called to parse the barcode and to trigger the associated action: https://github.com/odoo/odoo/blob/775827b8f7fa95f2afd77a9b42d6cd8e436ea690/addons/point_of_sale/static/src/app/barcode/barcode_reader_service.js#L69-L79 This flow use to not update the rewards after a product scanned and was fixed by commit 21392ab when the barcode associated action is `_barcodeProductAction` because fo these lines: https://github.com/odoo/odoo/blob/775827b8f7fa95f2afd77a9b42d6cd8e436ea690/addons/pos_loyalty/static/src/overrides/components/product_screen/product_screen.js#L105-L107 however, if the code is identified to be gs1 Howecver, if the barcode is identified to be of the gs1 nomenclature it will trigger the `_barcodeGS1Action` which still does not update the rewards. ### Fix: Inspired by commit 21392ab opw-3813858 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178600
Loyalty programs discount could be applied on specific products through a domain. When putting a domain with a True or False as a third operand (e.g. ('is_available_in_pos', '=', True)), the PoS was crashing at launch because the domain goes through a json.dumps that changes the Boolean to lower case and then through ast.literal_eval that doesn't accept lower case Boolean. The change is to replace lower case Boolean to upper case Boolean in the domain before the ast.literal_eval. --- I co
Original PR description
Loyalty programs discount could be applied on specific products through a domain. When putting a domain with a True or False as a third operand (e.g. ('is_available_in_pos', '=', True)), the PoS was crashing at launch because the domain goes through a json.dumps that changes the Boolean to lower case and then through ast.literal_eval that doesn't accept lower case Boolean.
The change is to replace lower case Boolean to upper case Boolean in the domain before the ast.literal_eval.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#175805Problem: While merging two partners in the contact app using the _update_foreign_keys method, the foreign keys are merged using SQL instead of ORM. The issue is that the partner_share field is computed based on the user_ids field and is stored. If we update using SQL, it will not trigger the _compute_partner_share method, which will set the latest value. Other problems might arise for fields that are computed based on foreign keys updated using SQL during a merge. Steps to reproduce: I
Original PR description
Problem: While merging two partners in the contact app using the _update_foreign_keys method, the foreign keys are merged using SQL instead of ORM. The issue is that the partner_share field is computed based on the user_ids field and is stored. If we update using SQL, it will not trigger the _compute_partner_share method, which will set the latest value. Other problems might arise for fields that are computed based on foreign keys updated using SQL during a merge. Steps to reproduce: In a new database, create a basic contact (individual, with name and email). Merge this contact with another contact who has document access (e.g., Marc Demo). Go to any product page. Add a log note and tag the new contact. The contact will receive an email without the "View product" button. opw-3864317 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#175966