Odoo Changelog — 2024-09-09

Monday, September 9, 2024

46 changes · saas-17.4

Bug Fixes(7)

Resolved issues and error corrections

[FIX] base: only log wkhtmltoimage stderr in case of error

Coresaas-17.4base

This fix stops successful report image conversions from being treated as problems just because they produced warning messages. It helps keep system logs cleaner and makes real conversion errors easier to spot.

Original PR description

There may have warnings on stderr, even in case of success.

#reports#logging#image-conversion

[FIX] base: deletion of duplicate device session

PR #179274

Coresaas-17.4base

This fixes an issue where duplicate device session records could cause an error when a user changed their language. The change helps keep user settings updates reliable even when multiple devices share the same session details.

Original PR description

[FIX] base: deletion of duplicate device session

Steps:
- Have 2 devices log with the same last_activity, platform, browser, ip, session, user
- Try to change the language of the user

Actual result:
- Missing record The record does not exist or has been deleted.
(Record: res.device(X,), user: Y)

Expected result:
- No error, SQL view have distinct setup

See:
https://github.com/odoo/odoo/pull/162168
https://github.com/odoo/odoo/pull/177233

opw-4148761

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#device sessions#user settings#language

[FIX] base: prevent indeterministic device ids

PR #179620

Coresaas-17.4base

This fix makes user device records return consistent identifiers during the same operation. It prevents intermittent errors where a device record appeared to disappear, improving reliability when editing user information.

Original PR description

Issue: ------ Within the same transaction, the ids of the `res.device` model (non-materialised view) may not be consistent. This inconsistency triggers the error: ``` Record does not exist or has…

Issue:
------
Within the same transaction, the ids of the `res.device` model (non-materialised view) may not be consistent. This inconsistency triggers the error:
```
Record does not exist or has been deleted.
```

This behaviour can occur during an onchange on the `res.user` model, for example. We will determine the ids of the `device_ids` linked to the user with the following query (A):
```
SELECT id, user_id FROM res_device WHERE user_id=<user_id> ORDER BY id
```
We will obtain the ids of the devices linked to the user. However, for a given device, it is possible to perform a fetch to retrieve the field values. A query (B) of the following form is used:
```
SELECT <field_to_fetch> FROM res_device WHERE id=<id>
```
Unfortunately, it can happen that the id is no longer present in the `res_device` table. If we look at the query plans (in the appendices), postgresql takes the decision to remove the `user_id` from the `DISTINCT ON` clause when it is used in a `WHERE` clause (which influences the internal logic of Postgresql).

In practice, we sometimes get different results because of the sorting, which can be indeterministic depending on (d.session_identifier, d.platform, d.browser, d.last_activity DESC). In fact, there is a scenario (multiple workers) in which a device will create two logs with the same `last_activity`.

Solution:
---------
Add the `id` to the `ORDER BY` to obtain a deterministic sort.

Appendices:
-----------
Query A:
```
explain select id, user_id from res_device where user_id=2;
                                        QUERY PLAN
-------------------------------------------------------------------------------------------
 Subquery Scan on res_device  (cost=39.39..42.13 rows=125 width=8)
   ->  Unique  (cost=39.39..40.88 rows=125 width=233)
         ->  Sort  (cost=39.39..39.76 rows=149 width=233)
               Sort Key: d.session_identifier, d.platform, d.browser, d.last_activity DESC
               ->  Seq Scan on res_device_log d  (cost=0.00..34.01 rows=149 width=233)
                     Filter: ((NOT revoked) AND (user_id = 2))
```

Query B:
```
explain select id, user_id from res_device;
                                              QUERY PLAN
------------------------------------------------------------------------------------------------------
 Subquery Scan on res_device  (cost=39.29..42.52 rows=128 width=8)
   ->  Unique  (cost=39.29..41.24 rows=128 width=233)
         ->  Sort  (cost=39.29..39.68 rows=156 width=233)
               Sort Key: d.user_id, d.session_identifier, d.platform, d.browser, d.last_activity DESC
               ->  Seq Scan on res_device_log d  (cost=0.00..33.61 rows=156 width=233)
                     Filter: (NOT revoked)
```

[FIX] point_of_sale: remove obsolete `getUTCString` method

PR #178065

Coresaas-17.4point_of_salepos_razorpay

The Point of Sale code was updated to remove an outdated date-handling method that is no longer used by the current payment flow. This reduces maintenance risk and helps keep payment-related behavior consistent without changing the cashier experience.

Original PR description

This commit removes the `getUTCString` method from PoS, as it is no longer relevant to the current implementation.

opw-4109126

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#point of sale#payments#maintenance

[FIX] mail: save edited message on the first click

PR #179532

Coresaas-17.4mail

This fixes an issue where saving or cancelling an edited chatter note required two clicks. Users can now complete message edits immediately, reducing confusion and extra clicks in daily communication workflows.

Original PR description

Problem:
Elements inside `CANCEL_OR_SAVE_EDIT_TEXT` are created twice, which interferes with event handling. To fix this, the element is now created in the setup method.

Steps to reproduce:

- Open the chatter.
- Log a note.
- Edit the note.
- Now, if you click Save or Cancel, both actions will only work on the second click.

opw-4119283


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#chatter#message editing#usability

[FIX] account: alias group label

PR #179110

Coresaas-17.4account

The accounting journal setup now shows wording that matches the type of journal being configured. For miscellaneous journals, email-based creation is labeled as creating entries instead of invoices, reducing confusion for users.

Original PR description

When going on a misc journal, the title of the group is "create invoices upon emails" but in the case of a misc journal we don't want to create an invoice but an entry. We will duplicate the group and change the invisible conditions to
 make it work.

 task: 4160550




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#journals#email alias#labels

[FIX] auth_signup : pr_BR email template

PR #175298

Coresaas-17.4auth_signup

Description of the issue/feature this PR addresses: When we try to send an invitation email with the pr_BR template it crashes because it tries to access the `signup_url` through `object`, but instead it should be accessed through `object.partner_id._get_signup_url()` Current behavior before PR: When you try to send an invitation email with language Portuguese (BR) / Português (BR) under Localization, it crashes. Desired behavior after PR is merged: When you try to send an invitation em

Original PR description

Description of the issue/feature this PR addresses:
When we try to send an invitation email with the pr_BR template it crashes because it tries to access the `signup_url` through `object`, but instead it should be accessed through `object.partner_id._get_signup_url()`

Current behavior before PR:
When you try to send an invitation email with language Portuguese (BR) / Português (BR) under Localization, it crashes.

Desired behavior after PR is merged:
When you try to send an invitation email with language Portuguese (BR) / Português (BR) under Localization, it works.



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Other(39)

Miscellaneous changes

[FW][FIX] mail,*: /help has canned response in discuss

PR #179705

Coresaas-17.4im_livechatmail

Since the canned response settings is introduced in Discuss, the usage of canned responses is not limited to livechat only, so that the /help message should be available in the Disucss as well. after: ![1948421007](https://github.com/user-attachments/assets/ff9a3cb6-c734-4f43-a876-632041a97f30) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179502

Original PR description

Since the canned response settings is introduced in Discuss,
the usage of canned responses is not limited to livechat only,
so that the /help message should be available in the Disucss as well.

after:
![1948421007](https://github.com/user-attachments/assets/ff9a3cb6-c734-4f43-a876-632041a97f30)


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#179502

[FIX] base: deletion of duplicate device session Steps: - Have 2 devices log with the same last_activity, platform, browser, ip, session, user - Try to change the language of the user Actual result: - Missing record The record does not exist or has been deleted. (Record: res.device(X,), user: Y) Expected result: - No error, SQL view have distinct setup See: https://github.com/odoo/odoo/pull/162168 https://github.com/odoo/odoo/pull/177233 opw-4148761 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Issue: ------ Within the same transaction, the ids of the `res.device` model (non-materialised view) may not be consistent. This inconsistency triggers the error: ``` Record does not exist or has been deleted. ``` This behaviour can occur during an onchange on the `res.user` model, for example. We will determine the ids of the `device_ids` linked to the user with the following query (A): ``` SELECT id, user_id FROM res_device WHERE user_id=<user_id> ORDER BY id ``` We will obtain the ids of the devices linked to the user. However, for a given device, it is possible to perform a fetch to retrieve the field values. A query (B) of the following form is used: ``` SELECT <field_to_fetch> FROM res_device WHERE id=<id> ``` Unfortunately, it can happen that the id is no longer present in the `res_device` table. If we look at the query plans (in the appendices), postgresql takes the decision to remove the `user_id` from the `DISTINCT ON` clause when it is used in a `WHERE` clause (which influences the internal logic of Postgresql). In practice, we sometimes get different results because of the sorting, which can be indeterministic depending on (d.session_identifier, d.platform, d.browser, d.last_activity DESC). In fact, there is a scenario (multiple workers) in which a device will create two logs with the same `last_activity`. Solution: --------- Add the `id` to the `ORDER BY` to obtain a deterministic sort. Appendices: ----------- Query A: ``` explain select id, user_id from res_device where user_id=2; QUERY PLAN ------------------------------------------------------------------------------------------- Subquery Scan on res_device (cost=39.39..42.13 rows=125 width=8) -> Unique (cost=39.39..40.88 rows=125 width=233) -> Sort (cost=39.39..39.76 rows=149 width=233) Sort Key: d.session_identifier, d.platform, d.browser, d.last_activity DESC -> Seq Scan on res_device_log d (cost=0.00..34.01 rows=149 width=233) Filter: ((NOT revoked) AND (user_id = 2)) ``` Query B: ``` explain select id, user_id from res_device; QUERY PLAN ------------------------------------------------------------------------------------------------------ Subquery Scan on res_device (cost=39.29..42.52 rows=128 width=8) -> Unique (cost=39.29..41.24 rows=128 width=233) -> Sort (cost=39.29..39.68 rows=156 width=233) Sort Key: d.user_id, d.session_identifier, d.platform, d.browser, d.last_activity DESC -> Seq Scan on res_device_log d (cost=0.00..33.61 rows=156 width=233) Filter: (NOT revoked) ```

This commit removes the `getUTCString` method from PoS, as it is no longer relevant to the current implementation. opw-4109126 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Problem: Elements inside `CANCEL_OR_SAVE_EDIT_TEXT` are created twice, which interferes with event handling. To fix this, the element is now created in the setup method. Steps to reproduce: - Open the chatter. - Log a note. - Edit the note. - Now, if you click Save or Cancel, both actions will only work on the second click. opw-4119283 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

When going on a misc journal, the title of the group is "create invoices upon emails" but in the case of a misc journal we don't want to create an invoice but an entry. We will duplicate the group and change the invisible conditions to make it work. task: 4160550 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

In makeAsyncHandler and makeButtonHandler have been modified in commit fcb16a3b1bd373726ffb54f0fbe41fb6d1784769 to remove guardedCatch. However, in both cases, if result is rejected, Promise.resolve(result) will (quite unexpectedly because of the name of the method) be rejected too. Calling finally on this promise will indeed call the callback, but it will still let the exception bubble up, eventually resulting in a second unhandledrejection for the same original exception. With this commit, we instead call then(callback, callback) on that Promise, so that the rejection is caught and callback is indeed called in both cases. To reproduce this issue in saas-17.4, raise a UserError in the route /website_sale/should_show_product_configurator and add a Drawer to your cart: the exception message is displayed twice. This reproduction doesn't work in 17.0 because the promise is a dialog.opened() that crashes and never resolves, masking the issue (but there is a hint of this, because the loading effect is also never removed from the button (meaning that the callback of makeButtonHandler is never called). Many thanks to MCM to help me understand what was happening here. Forward-Port-Of: odoo/odoo#179563 Forward-Port-Of: odoo/odoo#179512

When the user changes the language in My Profile and tries to save, a traceback will appear. Steps to reproduce the error: - Install ```account_accountant``` and ```hr``` module - Activate multi languages - Go to accounting > Dashboard > New Invoice - Click on the profile icon > My Profile > Change language > Save Traceback: ``` ValueError: too many values to unpack (expected 1) File "odoo/models.py", line 5851, in ensure_one _id, = self._ids ValueError: Expected singleton: account.move('n', 'e', 'w') File "odoo/http.py", line 2254, in __call__ response = request._serve_db() File "odoo/http.py", line 1829, in _serve_db return self._transactioning(_serve_ir_http, readonly=ro) File "odoo/http.py", line 1849, in _transactioning return service_model.retrying(func, env=self.env) File "odoo/service/model.py", line 134, in retrying result = func() File "odoo/http.py", line 1827, in _serve_ir_http return self._serve_ir_http(rule, args) File "odoo/http.py", line 1834, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 2059, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 220, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 740, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/action.py", line 96, in load_breadcrumbs display_names.append(Model.browse(record_id).display_name) File "odoo/fields.py", line 1202, in __get__ record.ensure_one() File "odoo/models.py", line 5854, in ensure_one raise ValueError("Expected singleton: %s" % self) ``` https://github.com/odoo/odoo/blob/59985860264f7fbd2726a51ff15d7e5101ae8234/addons/web/controllers/action.py#L97 Here, when the user changes the language and tries to save the record. we received record_id as ('n', 'e', 'w'), when it tries to access display_name So it will lead to the above traceback. This issue is similar to https://github.com/odoo/odoo/pull/163087 sentry-5135218331 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167492

[FIX] project: restrict access to project in email sent Before this commit, when the `Project Stages` feature is enabled and the user set an email template on a project stage, if the user moves a project to that stage with the email template, an email is sent to the customer (if set on the project) and the customer can click on the project name to see all tasks inside that project even if the project is private. This commit makes sure the project name displayed in the template is only clickable is the project visibility is 'portal' (`Invited portal users and all internal users`). Steps to reproduce: ------------------ 1. Install project 2. Go to Project > Configuration > Settings 3. Enable Project Stages feature 4. Set email template to project stage 5. Create a project with a customer set and project visibility is not set to "Invited portal users and all internal users". 6. Move the project to the project stage with the email template set. Current behavior: ---------------- An email is sent based on the email template set but the project name is clickable to allow the customer to see the tasks of the project in the portal even if the project is not public. Expected behavior: ----------------- The project name should not be clickable inside the email sent when the project visibility is not "Invited portal users and all internal users". Close #175396 Forward-Port-Of: odoo/odoo#178260 Forward-Port-Of: odoo/odoo#178171

Current behavior before PR: 1. When we attempt to paste an H1 element into a P element, the H1 element gets converted to a P element. 2. When pasting from GDocs, nested UL or OL is a direct child of its parent UL or OL, rather than being child of LI with class `oe-nested`. 3. Copy/pasting multiple paragraphs into a list does not convert it to list. 4. When pasting content that begins with a list and includes other tags below it into a new list, only the list is pasted, resulting in a loss of the other content. 5. Copy/pasting one list over another bullets does not get transformed. 6. When copying a checklist from Google Docs, the check options are pasted as images. Desired behavior after PR is merged: 1. When we attempt to paste an H1 element onto a P element, the H1 element will remain as an H1 element. 2. When pasting from GDocs, nested UL or OL are contained within an LI element with class `oe-nested`. 3. Copy/pasting multiple paragraphs into a list gets converted to list. 4. Pasting content with a list and other tags should no longer result in the loss of content. 5. Copy/pasting one list over another bullets get transformed. 6. Check options copied as image from Google Docs will no longer be pasted as images; instead the images should be removed and class `o_checklist` should be add to the closest list. task-2956048 Co-authored-by: Deependra Solanki <deso@odoo.com> --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179159 Forward-Port-Of: odoo/odoo#115019

Version: 16 Description of the issue/feature this PR addresses: A third party check received in a customer payment with journal with type "Cash" and Incoming payment method "New Third Party Checks" is not on hand in menu "Accounting / Customers / Third Party Checks" if journal doesn't has "Existing Third Party Checks" incoming payment method. Steps to reproduce: 1) Log in with admin on runbot odoo enterprise 16 instance and install l10n_latam_check (Third Party and Deferred/Electronic Checks Management) module. 2) Go to "Accounting / Configuration /Accounting / Journals" and create a new journal of type "Cash" and add incoming payment method "New Third Party Checks". ![image](https://github.com/user-attachments/assets/a600542a-8e35-473a-b5a6-66b6d6cbc15b) 3) Create a new customer payment with journal created on step 2 and "New Third Party Checks" payment method and confirm. ![image](https://github.com/user-attachments/assets/4036ef78-03d1-4993-aa66-a49ae7174069) 4) Go to menu Third Party Checks and the check received on step 3 is not on hand. ![image](https://github.com/user-attachments/assets/84fe2ffb-3ce4-42df-9cd6-c31dd81c84dd) Current behavior before PR: A third party check received in a customer payment with journal with type "Cash" and Incoming payment method "New Third Party Checks" is not on hand on tree view in "Accounting / Customers / Third Party Checks" if the journal doesn't has "Existing Third Party Checks" incoming payment method. Desired behavior after PR is merged: A third party check received in a customer payment with journal with type "Cash" and Incoming payment method "New Third Party Checks" is on hand on tree view in "Accounting / Customers / Third Party Checks" if the journal doesn't has "Existing Third Party Checks" incoming payment method. Ticket Adhoc side: 77887 Task Latam side: 1234 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#174283

### Steps to reproduce the issue: 1. Create two Taxes, one with Fixed "Tax Computation" and one with Percentage of Price. 2. Set "Included in Price" to True and and "Affect Base of Subsequent Taxes" to False for both. 3. Create an Invoice with one line, add both Taxes to it, make sure each Tax has a different amount. 4. Change the order of the Taxes in the Taxes menu 5. Refresh the Invoice Line (e.g.: remove and put back one of the taxes) 6. The amount of the "percent" Tax has changed along with the Untaxed Amount of the Invoice ### Explanation: In `_prepare_taxes_computation`, taxes are preprocessed with a priority set on fixed taxes, then taxes with `price_include` set to True, both in descending order and lastly, taxes with `price_include` set to False in ascending order. In `_propagate_extra_taxes_base`, the currently preprocessed tax is also added to the base of other taxes depending on the specifications of those taxes. When `price_include` is set to True, taxes are never being added to the base of the ones with a higher sequence, it should only be the case if `include_base_amount` is set to True as well. ### Fix reasoning: The computation should be consistent regardless of the order of the taxes, as they are not supposed to have an influence on each other. The special modes computation are changed accordingly. The change to the `total_included` special mode for non `_original_price_include` batches fixes an inconsistency when all taxes are excluded, added a test for it. opw-4068781 Forward-Port-Of: odoo/odoo#176150

If we have two bills with the same bill ref and two different partner, one with NIF and the other without it, the schedule action to process SII response might fail since the code expect a NIF in the SII response when there is not (bill with partner without NIF). Technical example: ```py >>> partner_info # Candidate invoice in odoo {'IDOtro': {'ID': 'NO_DISPONIBLE', 'IDType': '06', 'CodigoPais': 'ES'}} >>> respl_partner_info # SII response {'NIF': '12345678K', 'IDOtro': None} ``` This causes a rollback and no bills at all are processed in Odoo's side. Steps to reproduce: 1/ Create a l10n_es company with l10n_es_edi_sii in test mode 2/ Create a bill with a bill reference 10001, some lines (ex: negative lines) that will trigger an error from SII and a partner with a NIF 3/ Copy the partner and remove the NIF 4/ Copy the first bill, keep the same bill reference and change the partner to copied one 5/ Post both bills 6/ Trigger the schedule action "EDI : Perform web services operations" => Traceback with ValueError: <class 'AttributeError'>: "'NoneType' object has no attribute 'ID'" while evaluating Now, a default value is set when the key is not found in respl_partner_info.IDOtro . opw-4102638 Forward-Port-Of: odoo/odoo#177902

Bug Fixes(7)

[FIX] base: only log wkhtmltoimage stderr in case of error

[FIX] base: deletion of duplicate device session

[FIX] base: prevent indeterministic device ids

[FIX] point_of_sale: remove obsolete `getUTCString` method

[FIX] mail: save edited message on the first click

[FIX] account: alias group label

[FIX] auth_signup : pr_BR email template

Other(39)

[FW][FIX] mail,*: /help has canned response in discuss

Bug Fixes(7)

[FIX] base: only log wkhtmltoimage stderr in case of error

[FIX] base: deletion of duplicate device session

[FIX] base: prevent indeterministic device ids

[FIX] point_of_sale: remove obsolete `getUTCString` method

[FIX] mail: save edited message on the first click

[FIX] account: alias group label

[FIX] auth_signup : pr_BR email template

Other(39)

[FW][FIX] mail,*: /help has canned response in discuss

[FW][FIX] base: allow merged contacts to retain product link access in emails

[FW][FIX] discuss: welcome page

[FW][FIX] sale, sale_loyalty: refine the sale_order_line domain

[FW][FIX] web: fix double unhandledrejection in make*Handler

[FW][FIX] {test_}base_automation: copy with actions

[FW][FIX] web: prevent error while changing the language

[FW][FIX] stock_barcode_mrp: not redirect to backend from barcode backorder

[FW][FIX] project: restrict access to project in email sent

[FW][FIX] l10n_uy: wrong account payable on taxes

[FW][FIX] web_editor: allow interacting with toolbar in list view

[FW][FIX] l10n_it_edi: foreign currencies produce invalid XML

[FW][IMP] point_of_sale: iot update aliases, odoo.conf and packages

[FW][FIX] sale: apply discount correctly on unit price with tax included

[FW][FIX] account: enable retrieval of duplicated partners based on vat

[FW][FIX] website: fix highlighted text added to view

[FW][FIX] hr_expense: add tags to caba taxes in company expenses

[FW][FIX] web_editor: on pasting nested list should convert to another

[FW][FIX] l10n_latam_check: received third party check not "on hand"

[FW][IMP] account: recipient bank selection

[FW][FIX] account: make fixed and percent included taxes independent

[FW][ADD] l10n_vn_edi: Vietnamese E-Invoicing

[FW][FIX] website_sale: ecommerce categories margin behavior on hover

[FW][FIX] l10n_es_edi_sii: avoid traceback when same bill reference

[FW][IMP] l10n_in_reports_gstr: improve GSTR 2B Matching

[FW][FIX] l10n_in_qr_code_bill_scan: prevent access errror for users having Billing rights

[FW][FIX] industry_fsm_sale: modify the so item domain

[FW][FIX] sign: allow to drag & drop buttons on firefox

[FW][FIX] stock_barcode_mrp: not redirect to backend from barcode backorder

[FW][IMP] l10n_ke_edi_oscu: allow to put invoice values manually

[FW][FIX] l10n_uy_edi: neutralize

[FW][IMP] l10n_pe_reports: Add support for CAR in journal

[FW][FIX] account_reports: prevent wrong country code

[FW][FIX] website_sale_renting: disable date picker if exisiting rental period

[FW][FIX] helpdesk: fix knowledge link on team form view

[FW][FIX] sale_subscription: prevent uninvoiced subscription renewal

[FW][IMP] helpdesk_stock: enable returns for delivery main partners in helpdesk

[FW][IMP] l10n_au_hr_payroll_account: query count

[FW][FIX] mrp_workorder: fix save in ShopFloor