Tuesday, September 10, 2024
14 changes · 17.0
Resolved issues and error corrections
This fix makes configuration option names consistent on the POSBox homepage. It prevents settings from being missed or misread because the same option was written in different ways.
Original PR description
Some keys were named using `-` to separate words some place and `_` some other place.
The spreadsheet share action now handles cases where the browser blocks automatic copying after a delay. Instead of crashing, users can still access the share link and use the copy button manually.
Original PR description
Steps to reproduce ================== - Use Epiphany (a webkit based browser, like Safari) - Add `time.sleep(3)` inside `action_get_share_url` to simulate a slow network as it isn't possible inside the epiphany devtools - Go to dashboard - Click on Share => NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission. Cause of the issue ================== The delay between the user click and the actual copy is to slow for the trused event to be recognized as the origin of the copy. It is thus not allowed. Note that it also fails in Chrome if the document is out of focus in the meantime. Solution ======== Wrap the copy in a try catch. If it fails, the user can always use the copy button. opw-4144551
This update adjusts internal tests so they do not run a notification-listening check when a custom database notification setup is in use. This helps avoid false test failures in customized deployments without changing business functionality.
Original PR description
When a custom postgresql function is used (`ODOO_NOTIFY_FUNCTION` environment variable is set), testing to listen to imbus should be skipped --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Point of Sale users can now open optional products from the product information popup without them being missed by the system. This prevents confusion during sales and helps staff access related products as expected.
Original PR description
Prior to this commit, clicking on an optional product within the product info popup would fail to locate the optional product due to product template filtering applied to product variants. This commit resolves the issue by applying product template filtering exclusively for variants, ensuring optional products are correctly displayed from the product info popup. opw-4097824 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Point of Sale users can now find customers by scanning or entering their barcode when using the extended customer search. This fixes a gap that previously prevented missing customer records from appearing, helping cashiers select the right customer faster.
Original PR description
Before this commit, searching for a missing partner using their barcode via the 'search more' button did not yield any results. opw-4154847 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The attendance kiosk PIN pad now handles the 0 key as a normal digit instead of treating it like a delete action. This prevents employees from being blocked or entering incorrect PINs when their attendance PIN contains a zero.
Original PR description
Change ----- Take into account the case where the key is 0, which is falsy. Currently 0 acts the same as backspace. Steps ----- 1. Enable PIN identification in Attendances settings. 2. Attendances > Kiosk mode > Identify manually. opw-4155987
This update corrects a layout issue in the HR Payroll module where the "Availability in Structure" field was displayed in the wrong position. The fix ensures the field appears in the correct location alongside other input type settings, improving the user interface organization and usability.
Original PR description
This commit fix a design issue in the hr_payroll where the "Availability in Structure" field was incorrectly positioned among other input types. task-4050183 Forward-Port-Of: odoo/enterprise#67532
This update fixes failing automated tests in the Colombian EDI website sales module. The tests were breaking due to an incorrect stepDelay argument in the test code. This fix ensures that the automated testing process runs smoothly without errors.
Original PR description
The stepDelay argument in the l10n_co_edi_website_sale tour tests fails when loading the js for the tours https://runbot.odoo.com/web/#id=77298&menu_id=424&cids=1&action=573&model=runbot.build.error&view_type=form
Miscellaneous changes
Currently, a traceback is occurring when the user tries to download multiple e-Faktur at a time. To reproduce this issue: 1) Install `l10n_id_efaktur` 2) Select multiple customer invoices from an accounting 3) Try to `Download e-Faktur` from actions Error:- ``` ValueError: Expected singleton: account.move(65, 57,) ``` This is because when the user selects multiple invoices, the `self` contains multiple recordsets. Which leads to a traceback when `l10n_id_need_kode_transaksi` is
Original PR description
Currently, a traceback is occurring when the user tries to download multiple e-Faktur at a time. To reproduce this issue: 1) Install `l10n_id_efaktur` 2) Select multiple customer invoices from an accounting 3) Try to `Download e-Faktur` from actions Error:- ``` ValueError: Expected singleton: account.move(65, 57,) ``` This is because when the user selects multiple invoices, the `self` contains multiple recordsets. Which leads to a traceback when `l10n_id_need_kode_transaksi` is accessing from self. https://github.com/odoo/odoo/blob/4f044aade6e2a461c854899a8854474e3b22b6d5/addons/l10n_id_efaktur/models/account_move.py#L134-L139 Already a loop is there in that method, so by just changing self with record we can resolve this issue. sentry-5809438159 Forward-Port-Of: odoo/odoo#179597
In this commit, we revert fd1d3f30521495acd6e1f73c1143c15116a1218e in which we removed a utility. We take advantage of this commit to remove unnecessary steps, use camelcase instead of snakecase and to improve comments. Forward-Port-Of: odoo/odoo#179730
Original PR description
In this commit, we revert fd1d3f30521495acd6e1f73c1143c15116a1218e in which we removed a utility. We take advantage of this commit to remove unnecessary steps, use camelcase instead of snakecase and to improve comments. Forward-Port-Of: odoo/odoo#179730
- install website_profile - open /profile/edit - BUG: see content overflow in mobile opw-4123897 Forward-Port-Of: odoo/odoo#179324
Original PR description
- install website_profile - open /profile/edit - BUG: see content overflow in mobile opw-4123897 Forward-Port-Of: odoo/odoo#179324
### Steps to reproduce issue: 1. Create new Expense 2. Give a positive Total Amount, add a Tax and Save 3. Set Total Amount to 0 4. Tax Amount did not nullify 5. In the List view, Total Amount still has the previous value ### Explanation: In `_convert_to_tax_base_line_dict`, `price_unit` is only passed if it has a strictly positive value, otherwise `total_amount_company` is used instead. Since `total_amount_company` is computed using this method, it can never be reset to 0. https:
Original PR description
### Steps to reproduce issue: 1. Create new Expense 2. Give a positive Total Amount, add a Tax and Save 3. Set Total Amount to 0 4. Tax Amount did not nullify 5. In the List view, Total Amount still has the previous value ### Explanation: In `_convert_to_tax_base_line_dict`, `price_unit` is only passed if it has a strictly positive value, otherwise `total_amount_company` is used instead. Since `total_amount_company` is computed using this method, it can never be reset to 0. https://github.com/odoo/odoo/blob/72b84435d69d098d615284d84ef136e8bcd2aaa0/addons/hr_expense/models/hr_expense.py#L226-L232 ### Suggested Fix: The fallback to `total_amount_company` is unnecessary. For `quantity`, the fallback to 1 should only be observed if the quantity is not set. Correcting `_inverse_total_amount` to avoid division by 0. opw-4049853 Forward-Port-Of: odoo/odoo#174484
Problem: When searching for a reference in contacts, the search checks for an exact match. However, the expected behavior is to use `ilike` to allow partial matches. Steps to reproduce: - Add a reference to any contact (e.g., crutest). - In the list of contacts, search for cru. - No contact will appear. opw-4133302 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179478 Forward-Port-Of: odoo/odoo#177864
Original PR description
Problem: When searching for a reference in contacts, the search checks for an exact match. However, the expected behavior is to use `ilike` to allow partial matches. Steps to reproduce: - Add a reference to any contact (e.g., crutest). - In the list of contacts, search for cru. - No contact will appear. opw-4133302 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179478 Forward-Port-Of: odoo/odoo#177864
**Current behavior:** Having a product produced via kit bom with FIFO & automated costing method and valuation in a sale order with delivery via dropship: When the orders and transfers are completed and the sale order is invoiced, the stock output and expense account on the invoice will have a credit and dedit (respectively) which is too high (the degree is proportional to the `product_qty` of each move in the dropship transfer). **Expected behavior:** The account entry lines should be a
Original PR description
**Current behavior:** Having a product produced via kit bom with FIFO & automated costing method and valuation in a sale order with delivery via dropship: When the orders and transfers are completed…
**Current behavior:** Having a product produced via kit bom with FIFO & automated costing method and valuation in a sale order with delivery via dropship: When the orders and transfers are completed and the sale order is invoiced, the stock output and expense account on the invoice will have a credit and dedit (respectively) which is too high (the degree is proportional to the `product_qty` of each move in the dropship transfer). **Expected behavior:** The account entry lines should be accurate to the cost of the kit components. **Steps to reproduce:** 1. Create a kit_product such that: - It has FIFO cost method and automated valuation - Has a component in a kit bom, also with FIFO and automated valuation as well as a vendor with non-zero price 2. Create a sale order for 2 of the kit product and set the SOL route to dropship 3. Confirm the sale order, purchase order, and validate the dropship transfer 4. Create an invoice for the sale order and confirm/post it 5. Observe that the stock output and expense accounts have a credit and debit (respectively) for 2x the correct amount **Cause of the issue:** The `product_qty` of each move in the dropship is errantly multiplied with the result of `_compute_average_price()`- this qty has already been taken into account. **Fix:** Remove this piece of the calculation. opw-4050777 Forward-Port-Of: odoo/odoo#176296