Thursday, September 12, 2024
6 changes · saas-17.4
Resolved issues and error corrections
Restricted users could see an access error when opening Contacts if Sales or Purchase was installed. The update hides order and lead count information from users without the right permissions and safely shows zero when they cannot access it.
Original PR description
Versions -------- - saas-17.4+ Steps ----- 1. Have Sales and/or Purchase installed; 2. log in as a user with restricted access rights; 3. open Contacts app. Issue ----- Access error. Cause ----- Commit 855560e simplified `res_partner` kanban views. In doing so, it removed the `groups` attribute from a couple of buttons. As a consequence, trying to access the `res_partner` kanban view will try to display computed fields the user may not have access to. Solution -------- Re-add the `groups` attributes to buttons for `sale_order_count` and `purchase_order_count`. opw-4145862
This fix ensures validated point-of-sale orders are moved to the receipt step when automatic printing is enabled. This prevents staff from accidentally validating the same order twice, reducing duplicate sales records and operational confusion.
Original PR description
Before this commit, enabling automatic printing allowed validated orders to remain in the order list, leading to potential duplicate validations when loading it. This commit addresses the issue by setting the screen data of validated orders to ReceiptScreen, preventing duplicate order validations. opw-4149302 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes the self-order flow so customers who cancel an online payment and reopen their order are sent back to the product page instead of being stuck in the cart. This helps customers continue adding items to a draft order without needing to restart the ordering process.
Original PR description
On the self order, if you cancel a payment you're redirected to the landing page. But if you click on "My Order" you redirected to the cart and you are not able to add new products to your order because you can't acces the product page. Steps to reproduce: ------------------- * Install self_order and the demo online payment method * Setup the self order to use the online payment method, and pay after each * Open the mobile menu * Make a new order, add some product go to pay but cancel payment * You're taken back to the landing page * Click on my order > Observation: You're redirected to the cart page and cannot add any new product to the order Note: --------------- Impossible to write a tour as when paying the tour setup is lost opw-4069046 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue that caused accounting reports to crash when users compared periods and the fiscal year started or ended on today's date. This helps users reliably use balance sheet and other account report comparisons without interruption.
Original PR description
Currently, a traceback is occurring when the user tries to compare `periodically` in account reports having a `fiscal year` of date today. To reproduce this issue: 1) Install Accounting 2) Enable…
Currently, a traceback is occurring when the user tries to compare `periodically` in account reports having a `fiscal year` of date today. To reproduce this issue: 1) Install Accounting 2) Enable fiscal year from accounting settings 3) Now create a fiscal year record with `start` and `end` dates as today 4) Open balance sheet report 5) Filter the comparison as `Previous Period` Error:- ``` TypeError: can't compare datetime.datetime to datetime.date ``` After the recent changes from this commit https://github.com/odoo/enterprise/pull/48530/commits/4f0432e86de6d6f4e8f78f11dbba1f8f2b4dafe5, this error is occurring. Because `period_date_from` is getting from `fiscal_year`, which is a `datetime.date` format. https://github.com/odoo/enterprise/blob/4c1947963be235f733a56ee3d04b9f8f64d213ea/account_reports/models/account_report.py#L4769-L4775 But here the `comparision_date_from` is of type `datetime.datetime`, which leads to a traceback when comparison is done between both. https://github.com/odoo/enterprise/blob/4c1947963be235f733a56ee3d04b9f8f64d213ea/account_reports/models/account_report.py#L4796-L4797 When the fiscal year record is there we can convert it to datetime.datetime, By doing this we can resolve this issue. sentry-5695535237
Rental stock planning now counts outgoing deliveries correctly when using a two-step shipping process. This prevents the system from underestimating ongoing rentals, helping teams keep availability and replenishment decisions accurate.
Original PR description
In two steps the outgoing shipment doesn't exist. So the computation on max ongoing rental is not correct. We fix it to correctly count the outgoing shipment
The production analysis report now calculates component unit costs using the bill of materials quantity instead of the manufacturing order output quantity. This makes cost analysis more accurate for businesses reviewing production costs and margins.
Original PR description
In the production analysis pivot table, the field 'component cost unit' was computed using the quantity produced by a MO, rather than the product quantity from the BOM. This commit corrects the computation. Now, the correct calculation for this field is done by summing all products within a BOM line and dividing by the product quantity in the BOM.