Odoo Changelog — 2024-09-13

Friday, September 13, 2024

40 changes · saas-17.4

Bug Fixes(7)

Resolved issues and error corrections

[FIX] web, website: fix page dependencies tooltip

Coresaas-17.4website

Fixes an issue where the Dependencies tooltip in website page properties could reappear empty after being opened more than once. This ensures users can reliably see which pages or items depend on a changed page URL, reducing confusion during website edits.

Original PR description

task-4179593

#website#page properties#tooltip

[FIX] web: duplicate include archived button

PR #180169

Coresaas-17.4web

This fixes an issue where the “include archived” option could show up twice when users built certain advanced filters. The change keeps the filter interface cleaner and avoids confusion when selecting archived records.

Original PR description

This commit fixes a bug where the include archived checkbox button would be duplicated when the "any" operator would be used. This was due to the fact that using this operator would spawn a sub TreeEditor component inside of itself carrying most of its props including the include archived Checkbox slot from the domain selector which was supposed to be unique. The fix is therefore to empty the slots from the sub TreeEditor component.

#filters#archived-records#user-interface

[FIX] web_editor: background color of banner in pdf

PR #178824

Coresaas-17.4web_editor

PDF quotes now correctly show banner background colors in terms and conditions. This keeps downloaded documents visually consistent with what users see in Odoo and avoids missing emphasis in customer-facing PDFs.

Original PR description

Issue:
======
Downloaded pdfs doesn't have the background color of banners.

Steps to reproduce the issue:
=============================
- Go to any sale order
- Add a banner in terms and conditions
- Print PDF Quote
- No background color of the banner

Origin of the issue:
====================
After the upgrade of bootstrap to 5.3 in [1], we changed the hardcoded colors to css variables of the alers.

We use wkhtmltopdf to render the pdf files but it doesn't support the css variables so we loose all the stylnig that was using those variables.

Solution:
=========
Add an override for alert classes to keep the old colors and styles as hardcoded to make sure they appear in the generated pdf

opw-4143779

[1]: https://github.com/odoo/odoo/commit/058212e12b5079eba870bde9775fe98f27928935

#pdf#banner#styling#quotes

[FIX] account: prevent error when duplicating multiple payments

PR #176169

Coresaas-17.4account

Users can now duplicate multiple customer payments from the Payments list without triggering an error. This prevents interruptions in invoicing workflows when handling several payments at once.

Original PR description

This Error occurs when a user tries to duplicate multiple payments from the 'Payments' list view. Steps to reproduce: - Install the 'account' module - Go to Invoicing / Customers / Payments and…

This Error occurs when a user tries to duplicate multiple payments from the 'Payments' list view.

Steps to reproduce:

- Install the 'account' module
- Go to Invoicing / Customers / Payments and create two payments.
- Come to the list view of 'Payments' and duplicate both of them.

Traceback:
```
ValueError: too many values to unpack (expected 1)
  File "odoo/models.py", line 5961, in ensure_one
    _id, = self._ids
ValueError: Expected singleton: account.payment(22, 11)
  File "odoo/http.py", line 2373, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1903, in _serve_db
    return self._transactioning(
  File "odoo/http.py", line 1966, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1933, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 2177, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 754, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 35, in call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 459, in call_kw
    result = getattr(recs, name)(*args, **kwargs)
  File "addons/account/models/account_payment.py", line 939, in copy
    if not self.is_internal_transfer:
  File "odoo/fields.py", line 1204, in __get__
    record.ensure_one()
  File "odoo/models.py", line 5964, in ensure_one
    raise ValueError("Expected singleton: %s" % self)

```

An error occurs at [1], where the system receives multiple records in 'self' as duplicating of multiple payments.

link [1]:https://github.com/odoo/odoo/blob/5e28dcf717a7184f226773b3c84b409da24c1336/addons/account/models/account_payment.py#L939

To resolve this issue, Add a loop to copy multiple records one by one.

Sentry-5689633522

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] account: handle multiple payment duplication

PR #178363

Coresaas-17.4account

This fixes an Accounting issue where duplicating more than one vendor payment at the same time caused an error. Users can now select and duplicate multiple payment records without interruption, improving reliability in day-to-day payment processing.

Original PR description

Problem:
After this [commit](https://github.com/odoo/odoo/pull/166494/commits/c61adb511d002d74ec763e7dd113d18734d861ff), attempting to copy multiple payments fails because the case where `self` contains multiple records is not handled.

Steps to reproduce:

- Go to Accounting > Vendors > Payments.
- Select two payment lines and duplicate them.
- Traceback occurs.

opw-4144848

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#payments#duplication#accounting

[FIX] web: Product field would show undesired scrollbar

PR #177756

Coresaas-17.4web

Invoice line product descriptions now resize their text area when the column width changes. This keeps the full label visible without an unwanted scrollbar, making invoice editing cleaner and easier to read.

Original PR description

On the invoice form view, if the product column of a previously saved invoice line was resized to be of a smaller width, an undesired scrollbar would show on the product label text area. This commit fixes this issue by making the label text area height adapts to changes in its width to always show its full content without the need for a scrollbar.

task-4034995


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#invoice#product-field#usability

[FIX] account_online_synchronization: Adapt access rights for invoice

PR #69931

Enterprisesaas-17.4account_online_synchronization

This fix updates access rights so enterprise users working in Invoicing can use the missing bank transactions part of bank synchronization. It completes a previous access-rights update and prevents users from being blocked in that workflow.

Original PR description

Since this commit [[1]], the bank synchronization flow is available in invoicing for enterprise user. It means that we have to update the access rights. It was done for the main flow but forgotten for the missing transactions flow.

[1]: https://github.com/odoo-dev/enterprise/commit/c00c23cca9760533f0578ba3c93e3b59979589ce

no task id

#invoicing#bank synchronization#access rights

Other(33)

Miscellaneous changes

[FW][IMP] l10n_ec: Improvements for EC general reports and ATS

PR #180237

Coresaas-17.4l10n_ecbase

- Change address format for all reports when a company is established with the country of Ecuador. - Add extra validation when getting the ats code from the contact, in case it is an Final Consumer. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179558

Original PR description

- Change address format for all reports when a company is established with the country of Ecuador.
- Add extra validation when getting the ats code from the contact, in case it is an Final Consumer.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#179558

[FW][FIX] web_editor: table picker opens at wrong position

This commit fixes a bug where the include archived checkbox button would be duplicated when the "any" operator would be used. This was due to the fact that using this operator would spawn a sub TreeEditor component inside of itself carrying most of its props including the include archived Checkbox slot from the domain selector which was supposed to be unique. The fix is therefore to empty the slots from the sub TreeEditor component.

Issue: ====== Downloaded pdfs doesn't have the background color of banners. Steps to reproduce the issue: ============================= - Go to any sale order - Add a banner in terms and conditions - Print PDF Quote - No background color of the banner Origin of the issue: ==================== After the upgrade of bootstrap to 5.3 in [1], we changed the hardcoded colors to css variables of the alers. We use wkhtmltopdf to render the pdf files but it doesn't support the css variables so we loose all the stylnig that was using those variables. Solution: ========= Add an override for alert classes to keep the old colors and styles as hardcoded to make sure they appear in the generated pdf opw-4143779 [1]: https://github.com/odoo/odoo/commit/058212e12b5079eba870bde9775fe98f27928935

This Error occurs when a user tries to duplicate multiple payments from the 'Payments' list view. Steps to reproduce: - Install the 'account' module - Go to Invoicing / Customers / Payments and create two payments. - Come to the list view of 'Payments' and duplicate both of them. Traceback: ``` ValueError: too many values to unpack (expected 1) File "odoo/models.py", line 5961, in ensure_one _id, = self._ids ValueError: Expected singleton: account.payment(22, 11) File "odoo/http.py", line 2373, in __call__ response = request._serve_db() File "odoo/http.py", line 1903, in _serve_db return self._transactioning( File "odoo/http.py", line 1966, in _transactioning return service_model.retrying(func, env=self.env) File "odoo/service/model.py", line 134, in retrying result = func() File "odoo/http.py", line 1933, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 2177, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 754, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 35, in call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 459, in call_kw result = getattr(recs, name)(*args, **kwargs) File "addons/account/models/account_payment.py", line 939, in copy if not self.is_internal_transfer: File "odoo/fields.py", line 1204, in __get__ record.ensure_one() File "odoo/models.py", line 5964, in ensure_one raise ValueError("Expected singleton: %s" % self) ``` An error occurs at [1], where the system receives multiple records in 'self' as duplicating of multiple payments. link [1]:https://github.com/odoo/odoo/blob/5e28dcf717a7184f226773b3c84b409da24c1336/addons/account/models/account_payment.py#L939 To resolve this issue, Add a loop to copy multiple records one by one. Sentry-5689633522 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Problem: After this [commit](https://github.com/odoo/odoo/pull/166494/commits/c61adb511d002d74ec763e7dd113d18734d861ff), attempting to copy multiple payments fails because the case where `self` contains multiple records is not handled. Steps to reproduce: - Go to Accounting > Vendors > Payments. - Select two payment lines and duplicate them. - Traceback occurs. opw-4144848 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

On the invoice form view, if the product column of a previously saved invoice line was resized to be of a smaller width, an undesired scrollbar would show on the product label text area. This commit fixes this issue by making the label text area height adapts to changes in its width to always show its full content without the need for a scrollbar. task-4034995 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Since this commit [[1]], the bank synchronization flow is available in invoicing for enterprise user. It means that we have to update the access rights. It was done for the main flow but forgotten for the missing transactions flow. [1]: https://github.com/odoo-dev/enterprise/commit/c00c23cca9760533f0578ba3c93e3b59979589ce no task id

Go to a kanban view (directly from a menu, s.t. it's the first item in the breadcrumb), open a record. Simulate a global network error (connection loss, server down, outdated session...). For instance, remove the session_id cookie. Click on the breadcrumb to go back to kanban. Before this commit, this caused an infinite loop of reloading the kanban and the form views. When the first rpc error occurs, we land into the onError handler in the action service. We detect that we are trying to restore a controller from the stack, which crashes. At that point, we would like to restore the controller which appears before the faulty one in the stack. In our case, there's no such controller (we are the first one). So we reach the other part of the error handling, which concerns controllers that are not yet in the stack. For that case, we try to restore the last controller of the stack (the form view). This one fails as well, so we land again in the onError handler, for a controller that is already in the stack, but not the first one this time. So we try to restore the one before it (the kanban), which fails, and so on. The issue has been introduced in [1], where we simply forgot to handle the case where the faulty controller is the first one of the stack, and that's exactly what we do in this commit. In that case, there's nothing to do but display the error (there's no controller to restore). [1] ad35b3069e2efc69b97a283476da4154d49dda8b Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179806

Before 020ddc3a we allowed any Python identifier as column names. The usual field definition `name = fields.FieldType(...)` restricts `name` to be a valid Python identifier. Forbidding it in 17.0 causes issues during upgrades. For example, with the model: ```py class CustomModel(models.Model): _name = 'mymodule.custom.model' _description = "custom" année = fields.Char() ``` In 17.0 before this patch we get errors like: ``` File "/home/odoo/src/odoo/17.0/odoo/tools/sql.py", line 150, in identifier assert IDENT_RE.match(name), f"{name!r} invalid for SQL.identifier()" ^^^^^^^^^^^^^^^^^^^^ AssertionError: 'année' invalid for SQL.identifier() ``` ### Possible issue during upgrade from < `17.0` to >= `17.0`: 1. Install fresh db in `16.0` 2. Add custom field `année` to the `res.users` with custom module 3. Go to `Settings --> Manage Users` add the field `année` in the list view by installing studio 4. Upgrade to `17.0` You will get error like this: ``` ('base.menu_action_res_users', 64, 'Settings > Users & Companies > Users', 70): Traceback (most recent call last): File "/tmp/tmpcmtylywh/migrations/base/tests/test_mock_crawl.py", line 256, in crawl_menu self.mock_action(action_vals) File "/tmp/tmpcmtylywh/migrations/base/tests/test_mock_crawl.py", line 429, in mock_action mock_method(model, view, fields_list, domain, group_by) File "/tmp/tmpcmtylywh/migrations/base/tests/test_mock_crawl.py", line 557, in mock_view_tree self.mock_web_search_read(model, view, [domain], fields_list) File "/tmp/tmpcmtylywh/migrations/base/tests/test_mock_crawl.py", line 591, in mock_web_search_read data = model.search_read(domain=domain, fields=fields_list, limit=80) File "/home/odoo/src/odoo/17.0/odoo/models.py", line 5756, in search_read records = self.search_fetch(domain or [], fields, offset=offset, limit=limit, order=order) File "/home/odoo/src/odoo/17.0/odoo/models.py", line 1648, in search_fetch return self._fetch_query(query, fields_to_fetch) File "/home/odoo/src/odoo/17.0/odoo/addons/base/models/res_users.py", line 545, in _fetch_query records = super()._fetch_query(query, fields) File "/home/odoo/src/odoo/17.0/odoo/models.py", line 3929, in _fetch_query sql = self._field_to_sql(self._table, field.name, query) File "/home/odoo/src/odoo/17.0/odoo/models.py", line 2863, in _field_to_sql return SQL.identifier(alias, fname) File "/home/odoo/src/odoo/17.0/odoo/tools/sql.py", line 153, in identifier assert IDENT_RE.match(subname), f"{subname!r} invalid for SQL.identifier()" AssertionError: 'année' invalid for SQL.identifier() ``` Actually, the issue can occur anywhere that the new `SQL.Identifier()` is used. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180011 Forward-Port-Of: odoo/odoo#179863

When the no-content helper is shown and the user clicks on the "New" button to create a new article, the sidebar lists the newly created article in the "workspace" and in the "private" section. This is an undesirable behavior as the newly created article should only appear in the "private" section. When no record is passed to the form view, the form view creates a virtual record. When the user clicks on the "New" button, the system will create a new article and open it using the `openArticle` function defined in the component environment. When calling the `openArticle` function, the function will check if the article has a title and, if it hasn't, it will fetch the first heading of the article and use it as title (see: `ensureArticleName`). If the record is not virtual, the function `openArticle` will then persist the changes made on the current record before opening the new record. For its part, the sidebar listens to the changes made on the loaded record (using a record observer) and updates its state based on the record changes. When calling the `ensureArticleName`, the title of the virtual record changes and the sidebar detects that change and adds a new entry for the virtual record. The sidebar will then add another entry for the newly created record. To fix the issue, the `openArticle` function will no longer call the `ensureArticleName` function when the current record is virtual. The virtual record state will hence no longer be updated when opening a new article. As a result, the sidebar will not detect any change and will no longer create an entry for the virtual record. Note that there was actually no reason to update the title of the virtual record as it gets discarded when leaving Knowledge. Steps to reproduce the issue: 1. Delete all articles from the database 2. Open the Knowledge editor (you should see the no-content helper) 3. Click on the "New" button => There is two entries for the new article: one in the "workspace" section and one in the "private" section. TO BE: There should only be one entry in the "private" section. task-4160386 Forward-Port-Of: odoo/enterprise#69438

Currently, the share panel cannot be closed once it has been opened. This commit resolves the issue by preventing the share panel from closing only when the active element is a modal. Steps to reproduce the issue: 1. Open Knowledge. 2. Click on the share button to open the share panel. 3. Click on the share button again to close the share panel. => The share panel remains open. TO BE: The share panel should close. Details: In the `KnowledgeTopbar` component, we added external event listeners to detect when the dropdown menu is opened, closed, or about to close. When the dropdown is about to close (i.e., when the `hide.bs.dropdown` event is triggered), we check if the active element is the HTML document. If the focus is on another element, we prevent the dropdown from closing. This mechanism was added to prevent the dropdown from closing when users are adding new members through the invite modal. Using the `useActiveElement` hook, the active element can change when a component is mounted. When the web editor in Knowledge is mounted, the active element becomes the editor toolbar. As a result, the active element is no longer the HTML document, and the event listener always prevents the dropdown from closing. To resolve this issue, we will now check if the active element is a modal before preventing the dropdown from closing. This ensures that the dropdown behaves as expected and the share panel can be closed when necessary. Reference: https://github.com/odoo/odoo/pull/175880 task-4179706 Forward-Port-Of: odoo/enterprise#69861

Bug Fixes(7)

[FIX] web, website: fix page dependencies tooltip

[FIX] web: duplicate include archived button

[FIX] web_editor: background color of banner in pdf

[FIX] account: prevent error when duplicating multiple payments

[FIX] account: handle multiple payment duplication

[FIX] web: Product field would show undesired scrollbar

[FIX] account_online_synchronization: Adapt access rights for invoice

Other(33)

[FW][IMP] l10n_ec: Improvements for EC general reports and ATS

[FW][FIX] web_editor: table picker opens at wrong position

Bug Fixes(7)

[FIX] web, website: fix page dependencies tooltip

[FIX] web: duplicate include archived button

[FIX] web_editor: background color of banner in pdf

[FIX] account: prevent error when duplicating multiple payments

[FIX] account: handle multiple payment duplication

[FIX] web: Product field would show undesired scrollbar

[FIX] account_online_synchronization: Adapt access rights for invoice

Other(33)

[FW][IMP] l10n_ec: Improvements for EC general reports and ATS

[FW][FIX] web_editor: table picker opens at wrong position

[FW][FIX] web_editor: prevent toolbar from always being the activeElement

[FW][FIX] web: dashboard's filter caret on hover

[FW][FIX] mail, im_livechat: download files crashes with guest user

[FW][FIX] sale: incorrect global discount

[FW][FIX] website: snippet documentation typos

[FW][FIX] analytic: Remove account dependencies from analytic tests

[FW][FIX] account{_audit_trail,_lock}: uninstall hook useful error message

[FW][FIX] web: support extra HTTP headers in RPC service

[FW][FIX] web: action service: prevent infinite reloading on error

[FW][FIX] mail, mass_mailing: don't load duplicate attachments

[FW][FIX] website_payment: cache currency for donation snippet

[FW][FIX] core: allow Python identifiers as field names

[FW][FIX] web: added `fullscreen` in size props of `Dialog` component

[FW][FIX] web: x2many: correct pager when receiving many commands 0

[FW][FIX] base: prevent rtlcss compilation errors

[FW][IMP] hw_drivers: blur pos display devices background

[FW][FIX] web_editor: placeholder loop when removing image

[FW][FIX] base: enable duplicating languages.

[FW][FIX] stock: display report warning in red

[FW][IMP] l10n_in_ewaybill_stock: delivery challan on pending e-waybill

[FW][IMP] l10n_sg: taxes update

[FW][FIX] l10n_au_hr_payroll_account: bump queryCount

[FW][FIX] account_reports: dashboard's filter caret on hover

[FW][FIX] account_reports: include Norther Ireland in EC Sales report

[FW][FIX] account_reports: key error consolidation report

[FW][FIX] *_spreadsheet_*: useless filter date granularity option

[FW][FIX] pos_settle_due: fix total due with pos orders from open session

[FW][FIX] iot: missing print_id on longpolling print action

[FW][FIX] knowledge: avoid sidebar entry for virtual record

[FW][FIX] knowledge: fix bug preventing the share panel from closing

[FW][FIX] l10n_uk_reports: tax report: correct super call in custom handler

[FW][FIX] _spreadsheet_: useless filter date granularity option