Friday, September 13, 2024
6 changes · saas-17.4
Resolved issues and error corrections
Invoices created from sales or purchase orders now include the product name on each invoice line, not just the description. This ensures customers see the correct product names on invoice PDFs, reducing confusion and improving invoice clarity.
Original PR description
Description of the issue this commit addresses: When creating an invoice from the sales or the purchase app, the product names are not picked and put in the name (label) of the invoice lines linked…
Description of the issue this commit addresses: When creating an invoice from the sales or the purchase app, the product names are not picked and put in the name (label) of the invoice lines linked to it. This causes several issues among which the act that the pdf of the invoice only gives the description of the product but not its name. --- Example steps to reproduce: 1. Install sale_subscription 2. Go to sales app and create a new quotation 3. Put any partner and chose the "Monthly Cleaning" quotation template 4. Confirm the quotation 5. Create Invoice for quotation as "Regular Invoice" 6. Confirm the invoice 7. Check the invoice's PDF (Preview / Send & Print) 8. The name of the subscription product is missing --- Desired behavior after this commit is merged: This commit makes sure the product's display_name is always shown in the invoice line's name so that it is rendered on the pdf. --- Enterprise PR: https://github.com/odoo/enterprise/pull/68620 opw-4119507 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The company document layout wizard now keeps the PDF preview hidden until its styling is ready, showing a loading indicator instead. This prevents a brief unstyled preview from appearing and restores the preview after translation edits or logo changes.
Original PR description
- Wizard location settings app >> companies >> Configure document layout - Original problem The PDF layout wizard would show the PDF preview unstyled for a couple of seconds. This would happen at the…
- Wizard location settings app >> companies >> Configure document layout - Original problem The PDF layout wizard would show the PDF preview unstyled for a couple of seconds. This would happen at the wizard opening and at closing (if the user changes the logo). - Initial fix attempt For the original problem, there was a workaround introduced in this PR: https://github.com/odoo/odoo/pull/160958 The workaround would simply make the layout preview disappear once it has a record in the DB (at closing time after changing the logo). It's obvious that the workaround was fragile, and it also had a consequent problem. Therefore, it was reverted in this commit. - Consequent problem The aforementioned workaround (initial fix) caused the following problem: https://www.odoo.com/odoo/project/133/tasks/4137809 In summary, the problem was that the layout preview wouldn't show after attempting to add a translation to some of the previewed fields. - Root cause The root cause of the original problem was that the stylesheet takes longer to load than the rest of iframe, causing it to show unstyled (glitchy). - Solution inroduced in this commit This commit makes use of the fact that bootstrap classes are only loaded in the layout iframe through the delayed stylesheet. It makes the preview content invisible by default and only visible through the d-block class. This way the content will remain hidden until the stylesheet loads, preventing it from showing unstyled. Also, a loading-spinner would show in the absence of the preview, and it would disappear through the d-none class. task-4164703 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Switching between restaurant tables in the Point of Sale now saves the current order to the server before moving away. This prevents staff from losing unsaved changes when using the table switcher during service.
Original PR description
Before this commit, when switching from an order to another through the table switcher, the order was not synced with the server and all the changes were forgotten. task-id: 4169490 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Colombian DIAN e-invoicing flow now avoids crashing when required company or customer details, such as the company VAT/NIT or partner country, are missing. Instead, users receive a clear error message so they can correct the missing information and continue sending the invoice.
Original PR description
With a CO Company setup with missing VAT (NIT) number Have a partner with missing Country Create an invoice to the partner Confirm, Send&Print with option 'DIAN' checked Issue: The system will raise a traceback for each one of the missing info. We need to safely provide a fallback and then generate the corresponding error message so that user may take action opw-4148661
Subscription invoice lines now include the product name in addition to the description. This ensures invoice PDFs clearly show what was billed, reducing customer confusion and manual corrections.
Original PR description
Description of the issue this commit addresses: When creating an invoice from the sales or the purchase app, the product names are not picked and put in the name (label) of the invoice lines linked to it. This causes several issues among which the act that the pdf of the invoice only gives the description of the product but not its name. --- Desired behavior after this commit is merged: This commit makes sure the product's display_name is always shown in the invoice line's name so that it is rendered on the pdf. --- Community PR: https://github.com/odoo/odoo/pull/177242 opw-4119507
This fixes a crash that could happen when sending and printing invoices after the Sign app was uninstalled. The system now disables the invoice signatory setting during Sign removal when accounting features are present, preventing users from hitting an error in invoicing workflows.
Original PR description
Currently, an error occurs when the 'Sign' module is uninstalled and the user tries to send & print an invoice. Step to produce: - Install the 'account_accountant' module. - Go to the Invoicing Settings and enable 'Authorized Signatory on invoice'. - Uninstall the 'Sign' module. - And make a new invoice, Confirm it, and click on 'Send & Print' ``` AttributeError: 'res.users' object has no attribute 'sign_signature' ``` An error occurs when the system tries to get a 'Digital Signature' of a user at [1] but it is not available as the `Sign` module is not installed. Link [1]: https://github.com/odoo/enterprise/blob/addd67e9e46de2510fc110ea2b3ee8c571f41bf8/account_accountant/models/account_move.py#L109 To resolve this issue, create an uninstall hook in the `Sign` module to disable the `Authorized Signatory on invoice` if the `account_accountant` module is installed. Sentry-5667341424