Tuesday, September 17, 2024
9 changes · master
Resolved issues and error corrections
Point of Sale now clears the order screen status after payment when automatic receipt printing is enabled. This prevents orders from appearing in the wrong state, helping cashier workflows continue smoothly after checkout.
Original PR description
When automatic receipt printing is set, the order screen_state wasn't correctly set. This commit fixes the issue by setting the screen_state to empty string after the payment is done.
A failing automated test was corrected so it is properly skipped when the CRM app is not installed. This helps keep Odoo's validation pipeline reliable and prevents false errors during testing.
Original PR description
when crm is not installed, test_webjson_access_error_crm was supposed to skip a test, but was using skip instead of skipTest, which gave error. Now it's fixed. Runbot error https://runbot.odoo.com/web#id=75057&menu_id=424&action=573&model=runbot.build.error&view_type=form --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The project profitability panel now shows expected, billed, and to-bill cost values under the correct column headings. This helps users read project financial information accurately and avoid confusion when reviewing costs.
Original PR description
The current title and value of the expected/billed/to billed column are incorrect. This commit's purpose is to put the expected value under the expected title, the billed value under the billed value and the to billed value under the to billed value. task - 4179342 affected version: master Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The point of sale order screen now shows the event ticket printing option only when an order actually includes event tickets. This reduces clutter and avoids confusing staff with an action that has nothing to print.
Original PR description
In pos order form view, the button for printing the event tickets for the events bought in the order is always shown. In this commit we make it visible only when there actually are tickets to print. Task: 4189185 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes overly long and noisy error messages produced by Odoo's internal record-checking test helper. The change makes test failures easier for developers to understand, helping teams diagnose issues faster without affecting end users.
Original PR description
odoo/odoo#178332 attempted to simplify `assertRecordValues` and clarify its messages, it failed quite significantly at the second one, fix that: - Reformat error diffs using udiff rather than the…
odoo/odoo#178332 attempted to simplify `assertRecordValues` and clarify its messages, it failed quite significantly at the second one, fix that: - Reformat error diffs using udiff rather than the default ndiff (which always displays the entire thing), ndiff provides either completely cutoff output (because it's very easy to get above maxDiff = 640 when comparing pprints of lists of dicts) or extremely large output as it always displays the entire thing, when comparing either lots of records or very large dicts this is unusable. Not quite sure how I missed that Python uses ndiff, I assume it's because a previous version did the diffing explicitly using udiff and I didn't validate it when I changed to straight `assertEqual`. `pytest` has the exact same behavior so it's not like I got confused with that. Add tests to check that the formatting is as intended (use large lists from account as basis). Note: for now only swap out cutoff diffs, if the caller sets `maxDiff = None` then assume they want the entire thing. - Don't decorate the `Approx` values inside `assertRecordValues`, that formats out as differences on every failure even when those values are irrelevant. This makes the diff unreadable as basically every float value (which has rounding applied but that's most of them, in accounting anyway) gets prefixed by `~` which shows up during the diff. There is still an edge case if the rounding was necessary to make values match, it might be a good idea to `round` the values based on the input information in that case if that turns out to be a common problem.
The Point of Sale mobile view now hides product categories when using the scan option. This keeps the screen cleaner and makes scanning products easier for staff on smaller devices.
Original PR description
Steps: - Open Point of Sale - Switch to mobile view - Click on the scan option in navbar. Issue: Product categories are visible. Fix: - For mobile view we have restrict showing categories for better user experience. task-4160847
The rental eCommerce pages were updated to stay aligned with recent website shop layout changes. This helps prevent display or configuration issues when rental products appear in the online shop.
Original PR description
Follow the changes made in community which introduced the `shop_grid_header` template. task-3986938 part of task-3986921 Community PR: https://github.com/odoo/odoo/pull/177034
This change prevents an error that appeared when activating test asset debugging with the Colombian electronic invoicing website sales module installed. It removes an unsupported setting so the debugging mode can be enabled normally, improving reliability for testing and development workflows.
Original PR description
version: ----------- - master Steps to reproduce: --------------------------- - Install module l10n_co_edi_website_sale - Enable debug mode. - Click on Activate tests assets debugging. Issue: --------- - A traceback occurs when activating test assets debugging. Cause: --------- - The error occurs because the system does not recognize the stepDelay key. Solution: ------------ - the fix is to remove the stepDelay key from the tour setup to prevent the error. task-3628329
This fix restores intended customizations on the point of sale login screen and receipt header by correcting where the system applies them. It helps ensure employees and customers see the right branded and operational information in affected point of sale flows.
Original PR description
The login screen overrides were not working as expected. This commit fixes the issue by updating the file paths. Also, override target wasn't set correctly. This commit fixes the override target for the receipt_header.xml file.