Odoo Changelog — 2024-09-17

Tuesday, September 17, 2024

3 changes · saas-17.2

Bug Fixes(3)

Resolved issues and error corrections

[FIX] mrp: prevent error when saving manufacturing order

Coresaas-17.2mrpMedium

This fixes an error that could block users from saving a confirmed manufacturing order after removing a line. It helps manufacturing teams avoid interruptions when adjusting orders during normal workflow.

Original PR description

This error occurs when attempting to save a manufacturing order that is in a confirmed state.

Steps to reproduce:
- Install the ``mrp_workorder_hr_account`` module
- Create a new MO, add a line, and ``Confirm``
- Now remove a line and click on the ``Save`` button

Traceback:
``ValueError: not enough values to unpack (expected 3, got 2)``

The error at [1] occurred because we were not receiving the expected value of ``field_values`` in ``move_vals``. We expected 3 values but only received 2.

[1]- https://github.com/odoo/odoo/blob/c48d62098b2809cd046742435afd4f7ba3a4cbe1/addons/mrp/models/mrp_production.py#L843-L844

sentry-5819387893

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#manufacturing#orders#save#stability

[FIX] sale_stock: update DO demand from partially delivered SO

PR #179719

Coresaas-17.2sale_stockMedium

This fix ensures sales orders calculate only the remaining quantity to deliver after deliveries and returns have been processed. It prevents creating delivery orders for the full updated order quantity when only the difference should still be shipped, reducing over-delivery and warehouse confusion.

Original PR description

### Steps to reproduce:

- Create and confirm an SO for 5 units of a consumable product.
- Validate the associated delivery.
- Return and validate the return.
- Return and validate the return of the return.
- Change the demand of the SO from 5 to 8 units.

#### > A delivery order for 8 units is created instead of 3.

### Cause of the issue:

Changing the demand on the SO will trigger the ` _action_launch_stock_rule` to determine which procurement to trigger in order to fulfill the delivery. During this call the qty to deliver will be computed by comparing the quantity handled by incoming and outgoing moves  linked to the sol. However, the return of the return of an outgoing move will not be flagged as an outgoing move since it does not have a `location_final_id` since it was created as a return: https://github.com/odoo/odoo/blob/4a050ec0efb929f7605856f490025f7921d39672/addons/sale_stock/models/sale_order_line.py#L266-L267 https://github.com/odoo/odoo/blob/4a050ec0efb929f7605856f490025f7921d39672/addons/sale_stock/models/sale_order_line.py#L288-L292

opw-4105394
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#sales orders#delivery orders#returns#inventory

[FIX] mail: canned responses text overflow

PR #180438

Coresaas-17.2mail

Long canned response shortcut text now stays within the message composer suggestion list instead of spilling outside it. This keeps the mail interface cleaner and easier to read when users work with longer shortcuts.

Original PR description

Purpose of this PR:
When a canned response have a long shortcut text, the text overflow the navigablelist.

Before:
![image](https://github.com/user-attachments/assets/a0e9c341-8f83-40c9-b89b-541767d61d74)

After:
![image](https://github.com/user-attachments/assets/a30ac3b7-d1ad-4561-a5d3-2f4c87fda375)

#canned responses#mail#display fix

This error occurs when attempting to save a manufacturing order that is in a confirmed state. Steps to reproduce: - Install the ``mrp_workorder_hr_account`` module - Create a new MO, add a line, and ``Confirm`` - Now remove a line and click on the ``Save`` button Traceback: ``ValueError: not enough values to unpack (expected 3, got 2)`` The error at [1] occurred because we were not receiving the expected value of ``field_values`` in ``move_vals``. We expected 3 values but only received 2. [1]- https://github.com/odoo/odoo/blob/c48d62098b2809cd046742435afd4f7ba3a4cbe1/addons/mrp/models/mrp_production.py#L843-L844 sentry-5819387893 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

### Steps to reproduce: - Create and confirm an SO for 5 units of a consumable product. - Validate the associated delivery. - Return and validate the return. - Return and validate the return of the return. - Change the demand of the SO from 5 to 8 units. #### > A delivery order for 8 units is created instead of 3. ### Cause of the issue: Changing the demand on the SO will trigger the ` _action_launch_stock_rule` to determine which procurement to trigger in order to fulfill the delivery. During this call the qty to deliver will be computed by comparing the quantity handled by incoming and outgoing moves linked to the sol. However, the return of the return of an outgoing move will not be flagged as an outgoing move since it does not have a `location_final_id` since it was created as a return: https://github.com/odoo/odoo/blob/4a050ec0efb929f7605856f490025f7921d39672/addons/sale_stock/models/sale_order_line.py#L266-L267 https://github.com/odoo/odoo/blob/4a050ec0efb929f7605856f490025f7921d39672/addons/sale_stock/models/sale_order_line.py#L288-L292 opw-4105394 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Purpose of this PR: When a canned response have a long shortcut text, the text overflow the navigablelist. Before: ![image](https://github.com/user-attachments/assets/a0e9c341-8f83-40c9-b89b-541767d61d74) After: ![image](https://github.com/user-attachments/assets/a30ac3b7-d1ad-4561-a5d3-2f4c87fda375)