Tuesday, September 17, 2024
7 changes · saas-17.4
Resolved issues and error corrections
This fixes Point of Sale pricing so product variant attribute surcharges are included correctly. It prevents missing extra charges in some configurations and avoids double-counting them when variants are added by barcode, helping ensure checkout prices are accurate.
Original PR description
Before this commit, when adding a product variant with an attribute that does not trigger variant creation (create_variant !== "always"), the system failed to include the extra price of this attribute if another attribute with variant creation mode was present. Additionally, for variants of an attribute that triggers variant creation and is added by a barcode, the it would computed the extra price twice. opw-4151754 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update brings the spreadsheet component to the latest 17.4 version and fixes several small issues affecting pivot options, chart formatting, demo data, and collaborative styling. Business users should see more consistent spreadsheet behavior, especially when working with shared spreadsheets or pivot-based reports.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/caad8bd03 [REL] 17.4.8 Task: 0 https://github.com/odoo/o-spreadsheet/commit/8da9df710 [FIX] menu_items_actions: hide…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/caad8bd03 [REL] 17.4.8 Task: 0 https://github.com/odoo/o-spreadsheet/commit/8da9df710 [FIX] menu_items_actions: hide reinsert pivot menu Task: 4137926 https://github.com/odoo/o-spreadsheet/commit/7c67e1bd1 [FIX] charts: export formatTickValue helper Task: 3953835 https://github.com/odoo/o-spreadsheet/commit/af04f6c94 [FIX] demo: typo in demo data table style Task: 0 https://github.com/odoo/o-spreadsheet/commit/e98652d5a [IMP] demo: add tables in pivot demo data Task: 0 https://github.com/odoo/o-spreadsheet/commit/a74b5f6ea [FIX] style: recompute style on collaborative change Task: 4141034 Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
This fixes an issue where a previously edited contact could fail to open after the Website module was uninstalled. The mail tracking logic now handles missing field references safely, preventing an error and preserving access to the contact record.
Original PR description
This error occurs when we modify the ``Level Weight`` in ``Partner Assignment`` within Contacts, then uninstall the ``Website`` module, and subsequently attempt to access the modified contact again. Steps to reproduce: - Install the ``website_crm_partner_assign`` module - Change the ``Level Weight`` in ``Partner Assignment`` in Contacts - Now uninstall the ``Website`` module - Now open the changed contact again Traceback: ``AttributeError: 'NoneType' object has no attribute 'is_accessible'`` The error in [1] occurred because the field name from ``tracking.field_id.name`` was not found in ``tracking.field_id.model``. [1]- https://github.com/odoo/odoo/blob/d9d0b1c66dd608e475bdb7d29c162b6251b0f329/addons/mail/models/mail_tracking_value.py#L48-L49 sentry-5664351482 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where the Point of Sale customer search could crash when using “Search more” with loyalty features enabled. This helps store staff continue finding customers during checkout without interruptions.
Original PR description
A traceback appears when searching for more customers inside the shop. Steps to reproduce: ------------------- * Make sure you have `pos_layalty` installed * Open shop session * Select **Customers** * Enter anything in the search bar * Scroll down and select **Search more** > Observation: Traceback -> TypeError: cards is not iterable Why the fix: ------------ https://github.com/odoo/odoo/blob/d9d0b1c66dd608e475bdb7d29c162b6251b0f329/addons/pos_loyalty/static/src/overrides/components/partner_list_screen/partner_list_screen.js#L15-L18 `coupons` is a Promise as per: https://github.com/odoo/odoo/blob/d9d0b1c66dd608e475bdb7d29c162b6251b0f329/addons/pos_loyalty/static/src/overrides/models/pos_store.js#L630 ad thus we cannot access any value from it: https://github.com/odoo/odoo/blob/d9d0b1c66dd608e475bdb7d29c162b6251b0f329/addons/pos_loyalty/static/src/overrides/models/pos_store.js#L574 opw-4175319
List views now use more appropriate column widths so key information like products has more room while compact fields such as discounts, dates, numbers, and checkboxes take less space. Column resizing is also smoother because header tooltips no longer cover the view while users adjust widths.
Original PR description
Followup of task~3866837 (fp request)
This update prevents the website configurator onboarding tour from crashing by making tours wait until required page elements are ready before starting or resuming. It also temporarily disables broken manual theme homepage tours to avoid failed onboarding flows while a fuller solution is prepared.
Original PR description
In master, we should get rid of the `wait_for` tour option that doesn't serve any purpose anymore. Starting a tour is done by calling the `startTour` method of the `tour_service` (exported via…
In master, we should get rid of the `wait_for` tour option that doesn't serve any purpose anymore. Starting a tour is done by calling the `startTour` method of the `tour_service` (exported via `odoo.startTour`).
The tour service is already responsible for waiting for the DOM to be loaded (owl's `whenReady` method). This PR adds the new responsibility of waiting for `waitFor` dependencies when starting or resuming a tour.
For this purpose, the `startTour` and the `resumeTour` method are now asynchronous. This is stable-compatible because waiting for dependencies (await) is done after sideeffects to the tour service and tour registry.
In python, it makes no sense to manually wait for a test to be "ready" anymore. However, we still want to wait for the tour service to be ready, so we should introduce a new `odoo.isTourServiceReady` variable to replace the `ready` code.
-----
[REV] website: avoid error on configurator tour
This reverts the temporary fix by bso [1].
[1]: 2ec3afd842c7cc84a309c56f80e561724de155f8
task-4100223
-----
[FIX] web_tour, website, *: fix configurator tour crash in onboarding
*: web_tour_recorder
This commit fixes the JQuery replacement of the configurator tour [1].
It adds a `waitFor` option to tours that gets awaited before starting or
resuming tours. The goal of `waitFor` is to replace `wait_for` in master
which doesn't have any desired effect anymore.
This commit fixes the `homepage` tour registered with
`registerThemeHomepageTour` by waiting for the iframe to be loaded and
ready.
[1]: odoo@cfaf6d3#diff-3ec0693f8de5ef84844fffbe674e6c13c279b79170c167f0ff2979f6bcd19358L8-L31
task-4100223
Co-authored-by: Benoit Socias <bso@odoo.com>
-----
[FIX] website: disable broken theme hompage tours manual mode
When theme homepage tours are launched in manual mode
(post-configurator), many of them cannot be completed because of failing
checks at some steps.
This commit temporarily disables the manual mode of these tests until a
better solution is developed with task-4100300.
task-4100223Restaurant point-of-sale orders now remain available in the refund list after moving from the receipt screen back to the floor screen. This prevents paid orders from disappearing prematurely, so staff can reliably process refunds for recent table orders.
Original PR description
Steps: - Open restaurant and delete to existing draft orders. - Open table 1. - Add order items and pay the order until "New Order" button. Clicking New Order will change the screen to Floor Screen. - Open table 1 again. - In Actions button, select Refund. - The order you just paid will be in the list. - Refund the order. - Repeat steps 2 to 7. The new order is not there. Issue: Order list is not updated when refunding the order. Cause: When we navigate from the receipt screen to the floor screen, the onWillUnmount method will be called to remove the order from the local database and server. So, when we navigate to the order list then new orders will not be there as they are removed. FIX: Pass false argument to "removeFromServer" in the removeOrder function, so it will not delete the order from the server. So, the order list will be updated task-4155780