Daily updates from Odoo
Tuesday, September 17, 2024
9 changes
2 changes
Resolved issues and error corrections
This fixes an error that could block users from saving a confirmed manufacturing order after removing a line. It helps manufacturing teams avoid interruptions when adjusting orders during normal workflow.
Original PR description
This error occurs when attempting to save a manufacturing order that is in a confirmed state. Steps to reproduce: - Install the ``mrp_workorder_hr_account`` module - Create a new MO, add a line, and ``Confirm`` - Now remove a line and click on the ``Save`` button Traceback: ``ValueError: not enough values to unpack (expected 3, got 2)`` The error at [1] occurred because we were not receiving the expected value of ``field_values`` in ``move_vals``. We expected 3 values but only received 2. [1]- https://github.com/odoo/odoo/blob/c48d62098b2809cd046742435afd4f7ba3a4cbe1/addons/mrp/models/mrp_production.py#L843-L844 sentry-5819387893 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures sales orders calculate only the remaining quantity to deliver after deliveries and returns have been processed. It prevents creating delivery orders for the full updated order quantity when only the difference should still be shipped, reducing over-delivery and warehouse confusion.
Original PR description
### Steps to reproduce: - Create and confirm an SO for 5 units of a consumable product. - Validate the associated delivery. - Return and validate the return. - Return and validate the return of the…
### Steps to reproduce: - Create and confirm an SO for 5 units of a consumable product. - Validate the associated delivery. - Return and validate the return. - Return and validate the return of the return. - Change the demand of the SO from 5 to 8 units. #### > A delivery order for 8 units is created instead of 3. ### Cause of the issue: Changing the demand on the SO will trigger the ` _action_launch_stock_rule` to determine which procurement to trigger in order to fulfill the delivery. During this call the qty to deliver will be computed by comparing the quantity handled by incoming and outgoing moves linked to the sol. However, the return of the return of an outgoing move will not be flagged as an outgoing move since it does not have a `location_final_id` since it was created as a return: https://github.com/odoo/odoo/blob/4a050ec0efb929f7605856f490025f7921d39672/addons/sale_stock/models/sale_order_line.py#L266-L267 https://github.com/odoo/odoo/blob/4a050ec0efb929f7605856f490025f7921d39672/addons/sale_stock/models/sale_order_line.py#L288-L292 opw-4105394 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
5 changes
Resolved issues and error corrections
Mexican electronic payment cancellation now lets users choose the cancellation reason directly from the payment or invoice flow. This fixes cases where a payment must be cancelled and replaced, helping businesses comply with CFDI rules while recording the replacement payment reference.
Original PR description
Add a wizard to choose the cancellation reason on the payment view and add a new cancellation reason. As before only the "02" was supported, now the "01" is supported too, with the possibility to add the new payment which replace the one you cancel. linked:https://github.com/odoo/odoo/pull/175015 task-3894308
The accounting dashboard no longer shows separate expense-related warnings that duplicate information already covered by vendor bill alerts. Bill payment counts are also corrected so items ready or excepted for payment appear as bills to pay, while overdue items appear as late bills.
Original PR description
This commit remove the warnings we have on the accounting dashboard, as the journals entries are already included in the vendor bills warnings. task:3877069 odoo : https://github.com/odoo/odoo/pull/169820 upgrade : https://github.com/odoo/upgrade/pull/6283
This fixes cases where the editor could save an incorrect text selection while background page changes were still being processed. It helps prevent future undo or editing issues when opening overlays, using the table picker, or pressing Enter/space in edited content.
Original PR description
Before this commit, stageSelection could update the currentStep selection with mutations (‘add’, ‘remove’ and ‘characterData’) in progress. We should not have this type of mutations in the currentStep before staging the selection or the selection could be wrong when reverting that step in the future. When staging the selection, we shouldn't have any ‘attributes’ mutations either. Unfortunately, this is too common at the moment, so we've chosen to ignore them in this commit as they should not generate bugs. Before this commit, 3 related bugs have been found: 1) When an overlay was opened 2) When the table picker was opened (a temporary node was added for technical reasons). 3) When you press ‘enter’ or ‘ ’, the code call `normalise` without `ADD_STEP`. Our solution is to move this code so that it takes place at beforeInput and the mutations are added in the ‘enter’ or ‘ ’ step.
This fix prevents payment details from being edited after a point-of-sale order has been printed. It helps keep printed receipts and registered sales records consistent for Belgian blackbox and Swedish POS localization workflows.
Original PR description
Before this commit, it was possible to edit the payment lines of a printed order. This commit disables the editing of payment lines for printed orders. taskId: 4178904
Restaurant point-of-sale orders created while offline are now sent to the server when the connection returns. The update also prevents an error when staff access appointment bookings from the point of sale, improving reliability during daily operations.
Original PR description
Before orders created when offline were not synced to the server when the POS was back online. Also creating a fix for pos_restaurant_appointment. Traceback was raised when trying to access booking from PoS
2 changes
Resolved issues and error corrections
Fixed an issue where the Safari browser URL bar and navigation buttons were visible when accessing the Meeting Room booking page as an installed home screen app on iOS devices. The fix adds proper mobile web app configuration to provide a cleaner, full-screen experience for users who add the room booking to their iPhone home screen.
Original PR description
Steps to reproduce (on IOS): ------------------- With Safari browser: - Install `Meeting Rooms` app - Go to Meeting Rooms -> Rooms and open any room - Copy the `Room Booking URL` and open it in a new tab - Click on the menu, then on `Add to Home Screen` - Open the room booking from the home screen Issue: ------ The URL and browser buttons are visible at the top of the screen. Solution: --------- Add the meta tags `mobile-web-app-capable` and `apple-mobile-web-app-capable` to the room template. opw-3639196
This fix ensures that when the AvaTax module is installed or when a new US company is created, the required fiscal position is automatically set up across all US companies. Previously, the fiscal position was only available in the company where the module was initially installed, causing issues for multi-company setups.
Original PR description
Since the fiscal position is added in data with the xml, the others companies than the current ones don't have it. So this commit will allow: - When installing the Avatax modules, create the fiscal position in all US companies at the same time - When creating a new US company with the Avatax module installed, setup the fiscal position in the new company at the same time task: 4100725