Wednesday, September 18, 2024
6 changes · saas-17.4
Resolved issues and error corrections
Recruitment applicants can now correctly use the company information needed when assigning a recruiter from the kanban view. This prevents an error that blocked recruiter assignment when the recruiter field was initially empty.
Original PR description
Steps to reproduce:
1. make an applicant, leave recruiter field empty
2. Go to kanban view and try to assign a recruiter on the applicant
Error:
```
UncaughtPromiseError > EvalError
Uncaught Promise > Can not evaluate python expression: ([('share', '=', False), ('company_ids', 'in', company_id)])
Error: Name 'company_id' is not defined
```
The issue happens because the `company_id` field is missing from the view and as a result this field cannot be found.
This commit adds the field so that the domain can be calculated correctly.
opw-4188706
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prFixed an issue where working hours scheduled on Sundays were missing from employee calendar views. This ensures weekly schedules are displayed accurately for teams that work on Sundays.
Original PR description
Issue ----- Sunday working hours set in the working schedule do not appear in the calendar. Unlike other working hours which are displayed in white. Cause ----- Fullcalendar uses 0-based indexing starting on Sunday, the correct conversion from backend to fullcalendar library is 6 -> 0 for Sunday. opw-4152047
Opening a member list in Mail could get stuck in Firefox when two people had the same display name. The list ordering now uses each member's ID as a tie-breaker, preventing the loop and keeping the member list reliable.
Original PR description
This PR fixes an infinite loop that occurs when opening a member list with two members sharing the same name on firefox. This occurs because the sort function on `offlineMembers` is non deterministic when two members have the same name. It will first put the first member above the other one, then the opposite and so on. This PR updates the sort function to rely on id when two members have the same name, making the sort deterministic.
A web module test was adjusted so it checks the intended behavior around screen positioning in an invalid embedded page scenario. This helps keep future updates reliable without changing what users see in the product.
Original PR description
This commit fixes a test that even though would pass with the current implementation of the position hook, was behaving in a completely different way from before the conversion.
The receipt screen no longer shows an unnecessary email toggle when email is the only available delivery method. This reduces confusion for cashiers and keeps the checkout flow cleaner when SMS or WhatsApp sending is not enabled.
Original PR description
If SMS or Whatsapp are not enabled, diplaying the email toggle button to set the mode to email is redundant, as email would be the only available option by default. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The appointment booking flow now uses a more specific label, "Review Booking," to avoid conflicting with another translated use of "Review." This prevents customers from seeing an incorrect translation during booking review, improving clarity in localized interfaces.
Original PR description
### Issue: The word 'Review' being used in 2 different frontend locations (it's also used in portal_rating) and the frontend can only use the last translation that it loads. Thus, the 'Review' is translated as 'Avis', which is wrong. ### After this PR: Renamed 'Review' label to 'Review Booking'. Task-4164125