Thursday, September 19, 2024
4 changes · 17.0
Resolved issues and error corrections
Creating a field service task from the calendar now works correctly when the selected customer has no zip code. This prevents an error caused by calling the wrong underlying process, improving reliability for field service scheduling.
Original PR description
Steps to reproduce:
- Install the FSM module.
- Open FSM and navigate to the calendar view.
- Create a task with a customer (without a zip code).
Issue:
The wrong method is being called. Currently, the code uses super.onWillStart();, but this is
incorrect as the method does not exist in the calendar model.
Fix:
We corrected the super method call.
task-3617833This fix prevents Argentina demo data from failing during setup when loaded after database creation. Demo products are now tied to the correct company, avoiding duplicate default taxes that could block demo invoice installation.
Original PR description
### Steps to reproduce: - Create a db with `l10n_ar` but without demo data - In dev move at the bottom of the settings page: Load Demo data #### > UserError > load aborted. ### Cause of the issue:…
### Steps to reproduce: - Create a db with `l10n_ar` but without demo data - In dev move at the bottom of the settings page: Load Demo data #### > UserError > load aborted. ### Cause of the issue: Since commit 051d43dbef390de171307fe0e493d651c9ad7b4b (17.0), during the create of products, if the product is not associated to a given company, we add a default tax for each company that is not in the context (and hence should not have defined a tax yet): https://github.com/odoo/odoo/blob/b32fc0f715e41f6795972f2f8a2c3e4826357aa1/addons/account/models/product.py#L138-L146 However, if you were to create a DB without demo data and if you were loading the demo data from the UI, you will create demo datas product for companies that had already set a tax for that product (e.g. `company_ri` on the product `product_product_telefonia`) and since the current company is in the context the override of the create will add a second tax on these products for that companies. As such, if the product is later used in account moves it will raise a user error: https://github.com/odoo/odoo/blob/b32fc0f715e41f6795972f2f8a2c3e4826357aa1/addons/l10n_ar/models/account_move.py#L141-L144 and the installation of the all the demo datas will then be aborted. ### Fix: Since the demo data's products used in the account moves raising user errors are only expected to be used in the the company for which we have associated a tax eg: https://github.com/odoo/odoo/blob/b32fc0f715e41f6795972f2f8a2c3e4826357aa1/addons/l10n_ar/demo/account_supplier_invoice_demo.xml#L136 we simply add a company_id on these products. Note that the test datas had to be updated in somewhat a similar way in commit 051d43dbef390de171307fe0e493d651c9ad7b4b. ### Note: Since commit 7d9b791 (saas-17.2), the reference of the company has changed from `l10n_ar.company_ri` to `base.company_ri` so that the diff has to be adapted in foraward ports. opw-4180872 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures an existing automated test file is properly included when the sale-purchase-stock module test suite runs. It helps prevent related scheduling and lead time issues from slipping through future updates, with no direct change to day-to-day user workflows.
Original PR description
This commit add the missing test file in `__init__.py` Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed a PDF formatting issue in the General Ledger where the communication and partner columns could overlap for medium-length text. This makes printed accounting reports easier to read and helps avoid confusion when reviewing ledger details.
Original PR description
When printing a PDF report of the General Ledger, the columns for "communication" and "partner" overlap if the "communication" column's length is between 40 and 65 characters. This issue occurs because we only apply o_overflow_value for lengths greater than 65 characters. **To reproduce in Runbot, follow these steps:** 1) Navigate to Accounting > Reporting > General Ledger. 2) Print the report in PDF format (you will find some columns are overlapping). - **OPW: 4113571** - **UPG: 1782821** **Runbot snap before Fix:**  **Runbot snap after Fix:** 