Friday, September 20, 2024
7 changes · 17.0
Resolved issues and error corrections
Fixes an issue where favorite star icons could show the wrong state after saving records affected by automation rules. Users will now see the favorite status update consistently when toggling it, reducing confusion in apps such as Project.
Original PR description
The issue: When setting an automation rule to trigger 'On Save' onto a model with the boolean_favorite widget (i.e. project), the display will not update the icon properly when attempting to toggle it. This is due to base_automation populating the old_values which will attempt to read is_favorite, triggering a recomputation before favorite_user_ids is updated. The Fix: Retrigger the update without saving. This will force is_favorite to recompute again with the updated favorite_user_ids value and the display will stay consistent with the status of the widget. OPW: 4106799 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix removes an unnecessary rounding step when calculating expense unit prices. It helps ensure expense amounts are displayed consistently and accurately, reducing confusion during expense review and reimbursement.
Original PR description
During the forward-port of c940d3f fix about the price_unit display, the changes introduced by the refactoring in 68fbdc9 weren't taken into consideration. task-3749434 This completes the fix by removing the price_unit rounding entirely in the compute method Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Installing Indian withholding tax no longer fails when an Indian company has branch companies. The setup now loads taxes only for the main company, avoiding errors for branches that already use the parent company's chart of accounts.
Original PR description
- Install `l10n_in` - create a branch for the Indian company - install `l10n_in_withholding` - traceback If there an Indian company has a branch, installing `l10n_in_withholding` raises an RPC error on the branch company, because the TDS group is not set on it. Since branches use the COA of the parent company, we don't need to load further. Task [link](https://www.odoo.com/odoo/project/967/tasks/4143223) task-4143223
This change prevents a timesheet access rule from incorrectly blocking analytic account branch tests when only the timesheet grid app is installed. It helps keep automated checks reliable and avoids configuration-specific access errors.
Original PR description
Steps to reproduce: - install only `timesheet_grid` - run `test_analytic_account_branches` Issue: An access error is raised Cause: https://github.com/odoo/odoo/blob/8029b467dacaf9e34b21db52b148a2963efb29e4/addons/hr_timesheet/security/hr_timesheet_security.xml#L33-L44 So the analytic line should have a project_id set. Solution: Unlkink the groupe if existing runbot-97783
This fixes when the Viettel e-invoice XML section is shown on invoice forms. Users should now see the correct page when working with replacement invoice information, avoiding confusion or missing details.
Original PR description
* PROPBLEM: In form view we try to use m2o.field_name which is 'l10n_vn_edi_replacement_origin_id.l10n_vn_edi_invoice_number', odoo doesn't support that so it will not work at least in form view * SOLUTION: this commit make the invisible condition more simpler and create a non-store field to fix the issue Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When a SendCloud contract has no available rates, adding it to a sales order no longer triggers a disruptive popup. Users now see the same message in a red banner, keeping the workflow clearer and less interruptive.
Original PR description
In this PR ================== Some contracts in SendCloud do not have rates. This caused an annoying popup when adding it to the Sales Order. After this PR, the red banner is displayed with the same message instead of the annoying popup when adding it to the Sales Order. Enterprise PR: https://github.com/odoo/enterprise/pull/66976 TaskId: 4012182
This update adds a missing validation rule to the batch payment system to prevent payment method changes that could violate business constraints. While the standard interface already prevents this issue, the fix ensures the constraint is enforced even when records are created or modified through custom views or direct code, protecting data integrity.
Original PR description
payment_method_id is readonly in account.batch.payment's form view when there is at least one payment on the batch. So, it cannot easily be changed in standard in order to break the constraint. It could however happen in custom views or when generating records directly from the code. Forward-Port-Of: odoo/enterprise#70230