Friday, September 20, 2024
3 changes · saas-17.2
Resolved issues and error corrections
Generating the Indian GSTR report no longer fails when an overseas invoice uses 0% IGST. The report now correctly includes zero-rated tax data across relevant sections, improving reliability for compliance reporting.
Original PR description
Steps to reproduce traceback: 1. Create an overseas invoice with `IGST 0` 2. Post the Invoice 3. Create GSTR Report for the following month 4. Click on Generate Button traceback: ```py Traceback…
Steps to reproduce traceback:
1. Create an overseas invoice with `IGST 0`
2. Post the Invoice
3. Create GSTR Report for the following month
4. Click on Generate Button traceback:
```py
Traceback (most recent call last):
File "/home/odoo/odoo/enterprise/l10n_in_reports_gstr/tests/test_gstr1_report.py", line 233, in test_gstr1_export_with_igst_zero
gstr1_json = gstr1_report._get_gstr1_json()
File "/home/odoo/odoo/enterprise/l10n_in_reports_gstr/models/gst_return_period.py", line 1114, in _get_gstr1_json
'exp': _get_exp_json(AccountMoveLine.search(self._get_section_domain('exp'))),
File "/home/odoo/odoo/enterprise/l10n_in_reports_gstr/models/gst_return_period.py", line 932, in _get_exp_json
for line_tax_details in tax_details.values():
AttributeError: 'NoneType' object has no attribute 'values'
```
After this commit-
We fix the above traceback and on further investigation it was found that `hsn`, `b2b` and `cdnr` were
missing `zero_rated` base tag in their domain
which we fix in this commit
task-4195917The Point of Sale product information popup now reads the cashier role from the correct place after a page refresh. This prevents an error for employee logins with administrator PoS access, allowing staff to continue viewing product details normally.
Original PR description
Problem: The `role` attribute is being retrieved from the `raw` field, but when the page is refreshed, all attributes (including `role`) are set in the `cashier` object, not in `raw`. Steps to reproduce: - Set up a PoS session with the "Log in with Employees" setting enabled. - Use a User/Employee with Administrator PoS access (e.g., Mitchell Admin). - Start a PoS session. - Refresh the page. - Click the "i" icon to see more information about a product. - A traceback occurs. opw-4120414 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a new Argentine company now keeps the AFIP responsibility type selected by the user instead of reverting it to the default Monotributo option. This ensures the correct chart of accounts is loaded from the start, reducing setup errors for Argentine accounting.
Original PR description
Create a company: - Name: Any - Country: Argentina - AFIP Responsibility Type: IVA Responsable Inscripto Save Issue: Company AFIP Type will be set back to Responsable Monotributo This occurs because when company is created the system will try to load the coa. The COA to load is currently determined only by the country of the new company, and the default for new Argentina companies is 'Responsable Monotributo' Then, the AFIP Type is changed to match the CoA In order to take into account the company settings when loading the CoA we check via context if we are operating on a company and load the template matching the AFIP Type opw-4175351