Saturday, September 21, 2024
10 changes · master
Resolved issues and error corrections
This update fixes an automated website event sales test by ensuring a pop-up is closed after checking a discount. It helps keep the test reliable so future changes can be validated with fewer false failures.
Original PR description
In this commit, we fix the function checkPriceDiscountEvent. In this one, we must close the modal after checking the discount otherwise the element is no longer in the DOM. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Sub-threads now stop users from trying to upload an icon when they are showing the parent channel's icon. This avoids a confusing experience where an upload appears to do nothing because the visible icon belongs to the parent channel, not the sub-thread.
Original PR description
Sub-threads show their parent channel's icon in the discuss header. However, when uploading a new icon nothing happens: the icon is actually updated for the sub-thread. We should not allow to upload any icon in this case as it does not make sense to do so.
Manufacturing dashboard buttons for work orders now open the relevant list of items instead of sending users to the shopfloor screen. The workcenter graph layout is also stabilized so cards stay aligned even when extra status buttons appear.
Original PR description
We want the 3 buttons 'To Launch', 'In Progress' and 'Late' to redirect to a list view of corresponding workorders instead of the shopfloor. This should have been done via odoo/enterprise#69644 but since we decided to keep that specific button, the change will be made here instead. Also adding 'mt-auto' to ensure that the graph stays at the same height. Otherwise, a workcenter having a 'Late' or 'In Progress' button showing will displace the graph of the workcenter next to it. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Batch transfers now show the correct name when users add stock pickings to an existing batch. This prevents confusing labels such as "Unnamed" or "False: description", making it easier for warehouse users to choose the right batch.
Original PR description
Steps to reproduce:
- Create a batch transfer (or more).
- Open the list view of stock pickings.
- Select one (or more) stock pickings.
- From the actions menu, select "Add to batch".
- Select "Add to existing batch".
- Click on the many2one field to view the available batches.
Current behavior:
Batches without description appear as "Unnamed" and batches with description appear as "False: <description>".
This was because the definition of `_compute_display_name` was circular: display_name = `{display_name}: {description}` in case of using the add to batch wizard, or `{display_name}` otherwise. This commit uses `name` instead since `display_name` is not yet defined at this point.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis fix makes the batch picking report more reliable by changing how stock fleet report content is inserted and ensuring pickings appear in the correct order. It helps users get clearer, consistently ordered warehouse documents without changing their workflow.
Original PR description
remove the replace section in the report. Instead use a better xpath with before/after. Also correctly order the pickings. order is not an existing argument, so use a sort instead Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The message composer in chatter now aligns typed text more neatly with the nearby action buttons. This small visual fix makes the communication area look cleaner and easier to use without changing functionality.
Original PR description
Before / After  
This update corrects a small styling typo that caused the Discuss message composer to display incorrectly. It restores the intended appearance, improving consistency and usability for users writing messages in Discuss.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/180761 Original PR made the right fix but last PR in forward-port has a typo, which results in wrong composer style. This commit fixes the typo. Before / After  
When an analytic budget is revised, the new revised budget now keeps the same budget type as the original. This prevents confusion and helps ensure budget reviews and reporting stay consistent.
Original PR description
Description of the issue this commit addresses: When revizing an analytic budget, the revized budget doesn't have the type of the initial budget. --- Desired behavior after this commit is merged: The revized budget has the type fo the initial budget. --- task-4190606
The update prevents a reporting check from failing when it encounters invalid or non-readable invoice data. This keeps related document and accounting workflows running instead of being interrupted by unexpected file content.
Original PR description
Previously, the method `_is_l10n_in_irn_json` encountered a `UnicodeDecodeError` when processing binary content in JSON format, causing the failure of tests such as `test_bridge_folder_workflow`, `test_workflow_create_misc_entry`, `test_move_document_unlink`, `test_bridge_account_sync_partner` in the `documents_account` module. To resolve this, exception handling has been enhanced to suppress both `JSONDecodeError` and `UnicodeDecodeError`, ensuring the method can safely handle invalid or non-UTF-8 encoded content without interrupting the workflow. Fixes: https://runbot.odoo.com/web#id=98061&view_type=form&model=runbot.build.error&menu_id=405
Clearing a lead's email or phone will no longer erase those details from the linked customer record. This prevents accidental loss of contact information used by other business documents, such as sales orders and support tickets.