Saturday, September 21, 2024
3 changes · saas-17.2
Miscellaneous changes
Currently, a traceback occurs when the user tries to `log out from all devices`. To reproduce this issue: 1) Open the `Preferences` from the profile 2) Click `Log out from all devices` from the Account Security page 3) Give the current password and click `Log out from all devices` Error:- ``` AttributeError: 'bool' object has no attribute 'strip' ``` When the user clicks on the `Log out from all devices`, the `revoke_all_devices` method triggers in which the `_check_identity`
Original PR description
Currently, a traceback occurs when the user tries to `log out from all devices`. To reproduce this issue: 1) Open the `Preferences` from the profile 2) Click `Log out from all devices` from the…
Currently, a traceback occurs when the user tries to `log out from all devices`. To reproduce this issue: 1) Open the `Preferences` from the profile 2) Click `Log out from all devices` from the Account Security page 3) Give the current password and click `Log out from all devices` Error:- ``` AttributeError: 'bool' object has no attribute 'strip' ``` When the user clicks on the `Log out from all devices`, the `revoke_all_devices` method triggers in which the `_check_identity` method is triggered. https://github.com/odoo/odoo/blob/a7db2d8f1336035f6e45d04da7c2ebec5f3d9dba/odoo/addons/base/models/res_users.py#L2000-L2002 But here in the `_check_identity()` current password is set to False. This leads to a traceback from the `_change_password` method. https://github.com/odoo/odoo/blob/a7db2d8f1336035f6e45d04da7c2ebec5f3d9dba/odoo/addons/base/models/res_users.py#L1982-L1988 https://github.com/odoo/odoo/blob/a7db2d8f1336035f6e45d04da7c2ebec5f3d9dba/odoo/addons/base/models/res_users.py#L977-L978 Note:- I don't know the scope of setting the password as False, So instead of removing that line, I passed the current password as a variable. sentry-5867375557 Forward-Port-Of: odoo/odoo#180612
Before this commit: ========== - An issue existed with the quantity of reward products where there were more reward products applied than configured in the backend. - Rewards were being applied even when loyalty points were insufficient for the redemption of loyalty rewards. - In a loyalty program configuration with a reward point mode per order, loyalty points were consistently decreasing. - We were not showing a balance of loyalty points for the customers. After this commit:
Original PR description
Before this commit: ========== - An issue existed with the quantity of reward products where there were more reward products applied than configured in the backend. - Rewards were being applied even when loyalty points were insufficient for the redemption of loyalty rewards. - In a loyalty program configuration with a reward point mode per order, loyalty points were consistently decreasing. - We were not showing a balance of loyalty points for the customers. After this commit: ========== - The quantity of the applied reward product will now match the configuration set in the backend. - Reward products will not be applied if the customer's loyalty points are insufficient for the specific reward product. - Loyalty points will be computed correctly in the case of the reward point mode per order. - We will show a balance of loyalty points for the customers. task-4126886 Forward-Port-Of: odoo/odoo#180850 Forward-Port-Of: odoo/odoo#178901
Commit [958b41c4] added an event triggered when clicking on "Accept all" on a cookie banner (in 17.4) and [cee8a5e6] added support for Google Consent Mode V2 in master (18.0). This commit backports the relevant parts of both so that stable versions are compliant with Google's policy and that the analytics are properly working. The event will also make it easier for customers to add custom code working with Odoo's standard cookie banner. Note that due to [958b41c4], the behavior of Google Con
Original PR description
Commit [958b41c4] added an event triggered when clicking on "Accept all" on a cookie banner (in 17.4) and [cee8a5e6] added support for Google Consent Mode V2 in master (18.0). This commit backports…
Commit [958b41c4] added an event triggered when clicking on "Accept all" on a cookie banner (in 17.4) and [cee8a5e6] added support for Google Consent Mode V2 in master (18.0). This commit backports the relevant parts of both so that stable versions are compliant with Google's policy and that the analytics are properly working. The event will also make it easier for customers to add custom code working with Odoo's standard cookie banner. Note that due to [958b41c4], the behavior of Google Consent Mode is slightly different in stable versions than in 17.4 and above: - In stable, Google is called on page load with consents set on denied. This grants that only cookieless pings, non-identifying information is sent to Google (see [Google's documentation]). It is updated once the cookies are accepted. - In 17.4 and above, Google is not called until the cookies are accepted and only then receives the default + updated consents. [958b41c4]: https://github.com/odoo/odoo/commit/958b41c4acec7e1700ca4d6e0b25ee0ad2aac9f1 [cee8a5e6]: https://github.com/odoo/odoo/commit/cee8a5e6aafd9c05e5b2c027e52aee6b174a4ad5 [Google's documentation]: https://support.google.com/google-ads/answer/10000067 Related to task-3880544 Forward-Port-Of: odoo/odoo#180960 Forward-Port-Of: odoo/odoo#180866