Wednesday, September 25, 2024
4 changes · 17.0
Resolved issues and error corrections
The checkout flow now keeps a previously selected pickup point from being reopened unnecessarily when shoppers return to delivery selection. It also clears the pickup point when the shopper changes or creates a shipping address, preventing orders from using an outdated delivery location.
Original PR description
Steps to reproduce: - Install "Sendcloud Delivery" and configure it for belgium with a belgium website. - Once configured buy a product and go through the checkout process. - During carrier selection select any "Point relais". - Go back to the previous step (Shipping address selection). - Go again to checkout. Issues: The previous location is shown but we also see available point relais as if we didn't select it. In order to solve this issue we need to not reset access point if `forceClickCarrier` is on. We also call `_getCurrentLocation` before potentially clicking on the carrier, if we found a location `forceClickCarrier` is set to false as we have don't need to show point relais. Another issue was also met when testing the fix. If we changed shipping methods access point was not reseted to fix this we reset `access_point_address` in the `/shop/cart/update_address` route. opw-4050542
This fix prevents the Point of Sale from creating the same restaurant/table order more than once when sync actions happen at the same time. It reduces duplicate sales records and helps keep order, payment, and reporting data accurate during unstable or slow internet connections.
Original PR description
Before this commit, it was possible for the same order to be created multiple times if the order was sent to the server concurrently. While the order button has a guard to prevent duplicate clicks,…
Before this commit, it was possible for the same order to be created multiple times if the order was sent to the server concurrently. While the order button has a guard to prevent duplicate clicks, the `sendDraftToServer` function can be called from different places, some of which lack this guard. For example, the `setTable` function triggers order syncing but does not have the duplicate protection. Steps to reproduce: 1. Create an order in a table 2. Block the internet connection to prevent the order from syncing 2. Go to the floor screen 3. Re-enable a slow internet connection 4. Quickly click on two different tables without orders This behavior results in duplicate order creation. Since it's not possible to enforce uniqueness on the server side via a constraint, this commit introduces a debouncing mechanism in the `_save_to_server` function. This ensures that an order cannot be sent to the server more than once concurrently, preventing duplicate creation. opw-4136101 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed a bug where users could incorrectly select expense accounts from different companies when creating assets in a multi-company environment. This prevents data integrity issues and ensures assets only use accounts from their own company.
Original PR description
To reproduce: Be in multicompany, with several companies selected. Create an asset Click on the Expense Account field Select accounts from a different company than the asset's We should not show these. Even worse, in ulterior version, you can save the asset. (computing depreciations would still be prevented) The issue is that we define a custom domain, so it should include it. no-task Forward-Port-Of: odoo/enterprise#68699
Fixed an issue that prevented non-administrator users from sending and printing Mexican invoices (CFDI). The system now properly handles certificate access during invoice processing without requiring administrative rights. This allows regular users to complete their invoicing tasks independently.
Original PR description
### Steps to reproduce issue: 1. Install Mexican localization 2. Make sure Demo User has no administration right 3. As Demo User, create and confirm Invoice for Mexican customer - Make sure Products of the Invoice have an UNSPSC Category (Accounting tab) 5. Send and print Invoice for CFDI 6. An Access Error is raised: > You are not allowed to access 'SAT Digital Sail' (l10n_mx_edi.certificate) records. > > This operation is allowed for the floowing groups: > - Administration/Settings ### Explanation: During the operation, the user will retrieve the certificates of the company in `_send_api`. Those certificates can only be accessed by people with `group_system` access rights. ### Fix reasoning: Since the issue only concerns the retrieval of the certificates, we will enter superuser mode when executing this operation. opw-4205612