Wednesday, September 25, 2024
11 changes · 18.0
Enhancements to existing features
The mail composer’s mention suggestions are now more compact, with reduced spacing and smaller list items. This makes the suggestion dropdown less distracting, shows more useful information, and better aligns it with the full composer width.
Original PR description
Spacing was too big, and also size of suggestion list items were as big as any other content. As a result, this was too distracting compared to actual content like message list. This commit make suggestion items smaller and also reduces spacing around suggestion items. This make suggestion less likely to truncate, so more content of suggestion is visible. Also suggestion list takes whole width of composer, instead of just the inner textarea. <img width="1178" alt="Screenshot 2024-09-23 at 13 52 45" src="https://github.com/user-attachments/assets/a806e83d-7662-4f63-8361-f6bf4ed09dbc">
The mail composer’s mention suggestions are now more compact and use the full composer width. This makes the suggestion list less distracting, reduces text truncation, and keeps focus on the main conversation content.
Original PR description
Spacing was too big, and also size of suggestion list items were as big as any other content. As a result, this was too distracting compared to actual content like message list. This commit make suggestion items smaller and also reduces spacing around suggestion items. This make suggestion less likely to truncate, so more content of suggestion is visible. Also suggestion list takes whole width of composer, instead of just the inner textarea. <img width="1178" alt="Screenshot 2024-09-23 at 13 52 45" src="https://github.com/user-attachments/assets/a806e83d-7662-4f63-8361-f6bf4ed09dbc">
Chat messages sent by the current user now size more naturally when they contain a short sentence or mention. This removes awkward empty space on the right side of message bubbles, making conversations easier to read and visually cleaner.
Original PR description
Before this commit, when a user posts a message in chat window with a single sentence, this message was displayed with lost of spacing on the right. Steps to reproduce: - As Mitchell Admin, open…
Before this commit, when a user posts a message in chat window with a single sentence, this message was displayed with lost of spacing on the right. Steps to reproduce: - As Mitchell Admin, open "general" channel in normal-sized chat window - Type `@Marc Demo asjdoiasjdoiajsoidjsdd` without backquote, and mentioning Marc Demo - Send the message => message body text is wrapped with lots of wasted spacing on the right. This happens because message body is a `div` that contains a `span`. The `span` has `work-break` so it is squished, but the `div` does not adapt its width. Strangely, there's no CSS feature to solve this issue. The visual of self-messages do not look good in such scenario, which happens quite frequently. This commit fixes the issue by computing the width of parent container in JS. Code doesn't look very nice, but functionally this solves an annoying issue, therefore the "ugly" code is worth the cost. <img width="944" alt="Screenshot 2024-09-23 at 19 32 46" src="https://github.com/user-attachments/assets/0dbc9cb3-d33e-4405-b8b0-8dfc193dfd84"> 
Resolved issues and error corrections
Creating a discussion thread from a message now displays the message text cleanly instead of showing raw HTML tags such as <p>. This improves readability for users, especially when network conditions are slow and message loading timing varies.
Original PR description
Before this commit, creating a thread from a message was sometimes showing the html tags of the message in text content.
Steps to reproduce:
- Open general channel
- Post a message
- Set "slow 4g" network performance
- Create a thread from the message => It opens the sub channel with the message, but the
message and thread name title shows HTML tags like `<p>`
This happens due to missing of `store.insert({ html: true })`, which this commit fixes.
Task-4207900
Before
After
Miscellaneous changes
Creating a discussion thread from a message now displays the message text and thread title cleanly instead of showing raw HTML tags like <p>. This improves readability in Mail discussions, especially when the interface loads slowly on poor network connections.
Original PR description
Before this commit, creating a thread from a message was sometimes showing the html tags of the message in text content.
Steps to reproduce:
- Open general channel
- Post a message
- Set "slow 4g" network performance
- Create a thread from the message => It opens the sub channel with the message, but the
message and thread name title shows HTML tags like `<p>`
This happens due to missing of `store.insert({ html: true })`, which this commit fixes.
Task-4207900
Before
After
Design Themes: https://github.com/odoo/design-themes/pull/939 Enterprise: https://github.com/odoo/enterprise/pull/70692
Original PR description
Design Themes: https://github.com/odoo/design-themes/pull/939 Enterprise: https://github.com/odoo/enterprise/pull/70692
Before, when we were selling event tickets through pos_event the attendee weren't set as "attended" if we were printing their badges. This PR makes it so that if the ticket is sold through pos_event and the attendee badge is printed, the attendee is automatically set as "attended" instead of the "registered" status as it was previously done --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181271
Original PR description
Before, when we were selling event tickets through pos_event the attendee weren't set as "attended" if we were printing their badges. This PR makes it so that if the ticket is sold through pos_event and the attendee badge is printed, the attendee is automatically set as "attended" instead of the "registered" status as it was previously done --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181271
More logging is required to track calls to VIES services to enable tracking databases triggering VIES limitations. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#176677 Forward-Port-Of: odoo/odoo#176602
Original PR description
More logging is required to track calls to VIES services to enable tracking databases triggering VIES limitations. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#176677 Forward-Port-Of: odoo/odoo#176602
During [this refactoring] the custom `parseFloat` function import was removed from the payment screen. This custom function took into account the localized decimal separator to parse the entered number in the tip popup. By removing the import, the default JS `parseFloat` function was used, that only works with a `.` decimal separator. When you selected e.g. Spanish (Latin America) as a language that has `,` as a decimal separator, the payment screen would incorrectly parse the numeric string
Original PR description
During [this refactoring] the custom `parseFloat` function import was removed from the payment screen. This custom function took into account the localized decimal separator to parse the entered number in the tip popup. By removing the import, the default JS `parseFloat` function was used, that only works with a `.` decimal separator. When you selected e.g. Spanish (Latin America) as a language that has `,` as a decimal separator, the payment screen would incorrectly parse the numeric string of the tip amount and cut off the part after the comma when saving it. This commit adds the correct `parseFloat` import again, so it works with localized separators. [this refactoring]: https://github.com/odoo/odoo/commit/2a5f1abf2e98ee09fa7a912b87d71879b5ff260b Forward-Port-Of: odoo/odoo#181097
This pull request marks the Enterprise repository for the 18.0 release. It appears to be a release housekeeping change rather than a specific business feature or functional update.
Community: https://github.com/odoo/odoo/pull/181487 Design Themes: https://github.com/odoo/design-themes/pull/939
Original PR description
Community: https://github.com/odoo/odoo/pull/181487 Design Themes: https://github.com/odoo/design-themes/pull/939