Original PR description

In the stock rule diagram, the table border color was not correct anymore.

before:
![image](https://github.com/user-attachments/assets/a415063c-fe4d-4111-8cb0-97f22f7e1646)

after:
![image](https://github.com/user-attachments/assets/513ba257-25b0-4bc5-931d-4636c50be39b)


Retarget of https://github.com/odoo/odoo/pull/181395

task-id: 4207218


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Problem:
When the option "Add a link to a Web Page" is enabled, the preview page always shows the T&C link regardless of the content added to the notes. This behavior is inconsistent with the T&C section in the PDF invoice.

Steps to reproduce:

- Enable "Add a link to a Web Page."
- Create a new Sales Order (SO).
- Add content (text or image) to the notes.
- Confirm and preview the SO.
- The added content does not appear in the T&C section.

opw-4170021

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Table linking in chrome on ios does not work if the floorplan has a bg image. When the user tries to drag a table, the context menu appears, which prevents the table dragging from taking place.

This is because of a mistake in commit 894d7c25b7dd216ac6df1fd8ebedffccd20ef64e, where a line was removed.

Task: 4196350





---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Before the commit:
The button label remained as 'Claim' even when there were no rewards, which
seemed inconsistent.

After this commit:
The button gets hidden when no rewards are available.

Original PR description

Steps:
1. have a horizontal rule (HR) and two paragraphs in the editor
2. make a selection across the two paragraphs
3. press backspace or delete

Result: the HR gets filled with a BR element, leading to a vertical space being added below it.

The isShrunkBlock function is typically used to detect blocks that need to have a BR element added to it, otherwise they would be displayed collapsed in the editor.

Before this commit, the HR element was (incorrectly) considered as a shrunk block. The issue described above happened because the deleteRange method, after removing nodes as joining blocks, looks for shrunk blocks and fills them with a BR element.

Original PR description

Before when deleting an order, we removed the order and after related records. This caused an error when trying to remove the order because the related records try to access the order.

Now we remove the related records first and then the order.

Original PR description

Before this commit, the
@html_editor/image/Image transformation dissapear when selection change test was failing unpredictably.

This commit fix it.

Backward-port of #181200

Original PR description

This commit moves the price list snippets to a more appropriate category: Text

task-4212916

Requires:
- https://github.com/odoo/design-themes/pull/942


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Item does not exist anymore on the employee list in the select cashier mixin.

Adapt the code to use the correct variable name.

Original PR description

This commit Restore "Reset to Draft" on Payments "In Process". Only Validated & Sent Payments can not be Reset to Draft.

task: 4213210




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

before this commit there is no space between 'sms' and 'chat' buttons.

after this commit added a space between both buttons.

enterprise PR-https://github.com/odoo/enterprise/pull/70742

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

In commit [1], the new `s_cta_card` snippet has been added. It uses the `s_card` inner snippet.

This commit fixes the card:
- add the missing `data-snippet` attribute,
- fix the versioning: indeed, it was using `data-vcss` while the inner snippet in fact uses `data-vxml`. This caused the card background colors to be washed out, instead of being the real selected color.
- fix the `border-width` style: it was missing the `px` unit and the `!important` that would be added if we used the option to set it.

[1]: https://github.com/odoo/odoo/commit/4b88c63a96e84f5a603eea35fee3a395fbb4aae3

Related to task-4094392

Original PR description

Website user/interactive tours are not properly working at the moment. This disables the "follow the tips" message in the website loader while waiting for a fix.

Follow-up of https://github.com/odoo/odoo/pull/180471
Related to task-3084175

Original PR description

*in new API kanban views.

Those attributes are no longer supported as the css rules associated with the classname they generate are scoped to legacy kanban. Instead, we want to encourage the use of bootstrap utility classes (e.g. fw-bold).

Note: those attributes were no longer used in standard views. Note 2: we keep supporting them in legacy archs (those using "kanban-box"). The support of legacy archs will be dropped after v18.

Part of task~3992107

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Before this commit:
In mobile view, when the 'Add a reaction' action is clicked, the EmojiPicker opens, but the native keyboard also appears due to the focus being on the input field. This causes the keyboard to block the view of the EmojiPicker.

After this commit:
Now, in mobile view, the input search bar will not be automatically focused when the EmojiPicker opens, preventing the native keyboard from appearing and obstructing the EmojiPicker.

task-4208499

Original PR description

## [FIX] tools: variate `company_dependent` dates

Following de302c2d36305c0d7562572a30587641eabfe914, `company_dependent` fields
are stored as `jsonb` now, so the variation of dates needs to take that into account.


## [FIX] tools: allow populate for less priviledged `pg_roles`

When running the `populate` with a `pg_roles` that doesn't have admin access
or the group `session_replication_role` (only since PG15), the routine
crashes with an Insufficient exception when trying to drop the Fkey
constriants.
This context manager was initially added to speed up batch insertion by 10x,
but we are adding a generic catch to ignore said optimisation when privileges
are insufficient.


## [FIX] cli: show --help for populate CLI

Group options were added with the respective `help` section for each
arg, but the group was never added to the CLI arg parser.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Before this commit: delete an empty line under a separator and some text adds a br element to the separator

After this commit: the br won't be added to hr element because it already has a visible height




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

This commit enables tracking of the costing method in chatter for the product category.

Original PR description

Before this commit: in a table, select last two cells of first row and drag drop it to a p element out of the table, a traceback is raised

After this commit: the traceback is fixed, the added test only simulate the to be pasted content when drag and drop the selected cells


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

This commit adds the styling rules for the blockquote (present in the web_editor module), and fixes the padding for the hint that is displayed when the blockquote is empty.

Before this commit, the hint would be displayed on the top left corner of the blockquote without any padding, which, other than looking bad, does not match the position in which the text is inserted after typing.

task-4207507

Original PR description

The `new_page_template_services_s_parallax` template wrongly adds the `background-position` of the `style` attribute.

This commit fixes this definition so that the old `background-position` is replaced.

Steps to reproduce:
- Add a new page
- In the Service tab, pick a template that contains a parallax block (at the time of writing, this is the case of the second one in the first column)
- Inspect the parallax block

=> The `background-position` was defined twice.

task-4206845

Original PR description

Purpose of this commit:
Adjust the placeholder text for subchannels, as it previously included the '#' symbol, which typically denotes a channel rather than a thread

Before
![image](https://github.com/user-attachments/assets/1b61e8ff-f3ff-4aca-9c38-7690aacd214c)

After
![image](https://github.com/user-attachments/assets/a361991b-9cde-4c11-9bec-b42c1272aec7)

Original PR description

Since commit [1], the snippets are dropped by using a snippets dialog. In order for dynamic elements to be visible in the modal, fake previews are used. They are then removed once the snippet is dropped. These previews can be recognized by their `s_dialog_preview` class.

When a snippet is deprecated, a message is displayed in the right panel, informing that it is outdated and allowing to therefore replace it by its new version. However, in the case where the new version would have a dialog preview in it, this preview would not be removed.

This commit handles the dialog previews removal when replacing an outdated snippet.

[1]: https://github.com/odoo/odoo/commit/edf81c13d8f2f6d29a77d68cbfa0dc9216da3c2a

task-4185274

Original PR description

In the Native Mobile Apps when we use a Native method that requires a permission the promise is rejected on the first call.

This commit avoids to generate `unhandledrejection` in this case.

Original PR description

Before this commit, the 3c7775f4c7a3efaa891bc31072c41abff24edfad commit adds some style to correctly display the noContent helper inside the grid view. The problem is the selector used to apply that styling is too generic and not specific to the grid view which can alter the position of the no content helper in other views.

This commit makes sure the style added for the grid view is only applied inside the grid view and not somewhere else.

task-4207210

Original PR description

Before this commit, the compute of the allocated hours could be raised a traceback if the shift is an open one because we check if the resource is flexible before checking if there is a resource set on the shift.

This commit makes sure a resource exists on the shift before checking if the resource is flexible or not.

task-4206945

Original PR description

**Before this commit**
Tests on test_23_export_hardcoded_models_and_fields function break on single app tests because we are trying to find models from PRESET_MODELS_DEFAULTS in runbot that do not actually exist in self.env if we do not install extra modules like hr, crm, etc.

**After this commit**
This test checks beforehand if some needed modules are all installed.

Original PR description

before this commit there is no space between 'sms' and 'chat' buttons.

after this commit added a space between both buttons.

Original PR description

Before when creating two appointment one by one, an error was raised for the second appointment. This was due to the fact that the calendar view was refreshed with a wrong active id.

This commit remove the view refresh since the view itself make a RPC to get the new data.

Original PR description

Before this commit, toggling the bold attribute on a field in a (new API) kanban view didn't work. This was because the feature wasn't fully implemented (in web) for new API kanban. Indeed, the class "o_text_bold" was correctly set, but the associated css rule was scoped for legacy kanban records.

Instead of fixing it in web, we rather want to promote the use of bootstrap utility class. So instead of setting the `bold` attribute, we toggle the `fw-bold` classname.

Original PR description

**How to reproduce**
Create a Table Booking appointment from the Action helper 
Go to the booking page for that appointment 
it looks like this - https://tinyurl.com/29q2ktjb

**After this PR**
Now that appointment name will be Table instead of Table Booking

Backport of this commit - https://github.com/odoo/enterprise/pull/70643/commits/209aeae1f5d6689ef15fd8016cbcd08b03710f6f 

Task-4210749

Original PR description

When portal users try to switch to the list view, they get a client error.

The error is solved by keeping the studio service accessible to the ListRenderer.

task-3373836

Original PR description

website_id is not defined on sale teams... website_ids is.
"False" should be False...

task-4210343

Original PR description

This commit is the counter part of https://github.com/odoo/odoo/pull/181354 and adapt a test to the fix of the pivot view in spreadsheet.

Task: 4207668

Original PR description

The issue was recently fixed with a sudo, but it allowed standard salesman/users to
create discount products and update the company, which ideally shouldn't happen.

Since a single use of the wizard by the admin will properly create the discount product,
we prefer to encourage the user to request the admin to do it first instead of
bypassing the standard access rights.

opw-4048403

Forward-Port-Of: odoo/odoo#180298
Forward-Port-Of: odoo/odoo#180221

Original PR description

Before this commit, adding a product to the cart became progressively slower after creating several orders in the PoS, especially when a high number of products were loaded. This performance issue was due to the search operation across all order lines for each product, which became increasingly inefficient with a large number of loaded products and created orders. To address this, "<-pos.order.line.product_id" is now utilized to directly find the corresponding order line, significantly reducing the time complexity and improving the responsiveness of product addition to the cart.

opw-4209134

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#181415

Original PR description

Before this commit, attempting to add a product to the cart that did not have an archived variant would result in an error.

opw-4212973

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#181512

Original PR description

Before this commit, connecting a `<-` field unnecessarily attempted to link the record to the reversed field, which was not required. This additional search operation increased the time complexity of the connection process, leading to performance inefficiencies.

opw-4169060

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#179886

Original PR description

Steps

- install `stock`
- create a delivery for 2 products > *Mark as Todo* > *Validate*
- make a return, a `ListRenderer` for the return moves opens
- click the last field (quantity) of the last record in the list
- press `tab`
   * => Traceback: `Uncaught Promise > futureRecord is undefined`

Cause
---
This specific view is `editable='top' create='0'`, but the return moves have been generated on the fly, so their `isNew` property is true.

But, we check `isNew` to decide if a record has just been created in the list, and what element is the last.

This leads to a false negative where we don't detect that we're on the last record.

Note
---
`.isNew` is still needed because we can run into problems with the pager or if we start with a grouped list view.

opw-4108845

Forward-Port-Of: odoo/odoo#180908
Forward-Port-Of: odoo/odoo#180690

Original PR description

Before this commit, attempting to sync a paid order that had not been previously synced in a newly opened session would result in an error due to the absence of the `session_id`.

opw-4182909

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#181015

Original PR description

**Current behavior before PR:**

- When a table was created within an empty list item `(li)`, it was inserted directly inside the `ul` and as a sibling of the list item `(li)`. Furthermore, an additional `li` element was generated after the table.

**Desired behavior after PR is merged:**

- Now, when a table created inside empty `li` elements, it will be correctly inserted within the list item itself instead of the `ul`. Additionally, no extra `li` element will be generated after the table.

task-3550599

Forward-Port-Of: odoo/odoo#164304

Original PR description

Design Themes: https://github.com/odoo/design-themes/pull/940
Enterprise: https://github.com/odoo/enterprise/pull/70693

Original PR description

Before:

In chrome, you can see the message "[DOM] Input elements should have autocomplete attributes (suggested: "username"):
(More info: https://goo.gl/9p2vKq)".

After:

The message does not appear.

Also, This maintains consistency with the password input which has the attribute autocomplete.

![Screenshot from 2023-12-12 12-05-33](https://github.com/odoo/odoo/assets/90422721/bcbec47e-6dee-431b-8a05-379fb13c0731)





---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#146934
Forward-Port-Of: odoo/odoo#146037

Original PR description

template data of model res.company: {id: values}
template data of model account.journal, account.tax...: {xmlid: values}

An error occurred when adding the x2many field to res.company and try load template


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#180816

Original PR description

Situation:
Field `ir.models.fields.field_description` has value `{"en_US": "Foo", "fr_FR": "", "nl_NL": "Baz"}` in database. When using `EXCLUDED.{quote(fname)}`, the value of keys `fr_FR` and `nl_NL` will be lost.

Solution:
Use `ir.models.fields.field_description || EXCLUDED.field_description` to overwrite part of the value instead of replacing the old value.




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#180970

Original PR description

Steps to reproduce the bug:
- Create a storable product “P1”:
    - vendors:
        -Azure interior, code: Vendor 1
        - Deco Addict, code: Vendor 2
- Create a purchase order:
    - product P1
    - Vendor: Azure interior

> Description P1 [Vendor 1]

- Create an Alternative PO:
    - Vendor: Deco Addict
    - Copy products: True

Problem:
The description of POL is incorrect: P1 [Vendor 1] instead of P1 [Vendor 2]

opw-4133933

Forward-Port-Of: odoo/odoo#180798
Forward-Port-Of: odoo/odoo#179487

Original PR description

In de29ff9cee5be830b8d2aaf2c703f4f13ee24dec, we missed a tag for
credit notes on PST tax for saskatchewan tax report.

opw-3955926

Forward-Port-Of: odoo/odoo#181004

Original PR description

Purpose:

- Ensure that muted text is displayed exclusively on active
  lines while remaining absent from other lines.

- Resolve the issue where muted text wasn't displaying on the
  checklist when the selection or cursor was on it.

task-3875225

Forward-Port-Of: odoo/odoo#162804

Original PR description

Problem:
The `role` attribute is being retrieved from the `raw` field, but when the page is refreshed, all attributes (including `role`) are set in the `cashier` object, not in `raw`.

Steps to reproduce:

- Set up a PoS session with the "Log in with Employees" setting enabled.
- Use a User/Employee with Administrator PoS access (e.g., Mitchell Admin).
- Start a PoS session.
- Refresh the page.
- Click the "i" icon to see more information about a product.
- A traceback occurs.

opw-4120414

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#180841

Original PR description

Updated the tax names, descriptions, and invoice labels to be more clear.
Added an additional tax group for exempt.

task-4196993


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#180766

Original PR description

Before this commit:
==========
- Rewards were being applied even when loyalty points were insufficient for the redemption of loyalty rewards.

After this commit:
==========
- Reward products will not be applied if the customer's loyalty points are Insufficient for the specific reward product.

task-4126886

Related PR: https://github.com/odoo/odoo/pull/180972

Forward-Port-Of: odoo/odoo#180981

Original PR description

Starting d1a94147060083da54f9423f8c379676fbb7db66, when making ingenico payment, the pos app sends an `NaN` as `TransactionID`. As a result, users are unable to receive payments from Ingenico terminal. This change proposes to take the last 13 characters of the payment's uuid (after removing the `-` separators) and convert it as integer which will serve as the `TransactionID`. We're only taking the 13 characters because it's the number of characters that can be converted to JS int without exponent.

Forward-Port-Of: odoo/enterprise#70672

Original PR description

Due to legal reasons, we need to send a zip containing the PDF and the xml. The xml is an UBL `AttachedDocument` containing both the initial xml representing the invoice and the `ApplicationResponse` returned when calling the GetStatus webservice of DIAN.

The `ApplicationResponse` is an xml representing the state of the invoice on the DIAN server.

task-4133688

backport of https://github.com/odoo/enterprise/pull/70171

Forward-Port-Of: odoo/enterprise#70664

Original PR description

Before this commit, changing the partner in POS for the EC localization
was raising an OWL error.
This error happens because missingFields got stripped from most of the
codebase, including PartnerList, leading to an "Invalid Props" error in Owl.
This was preventing users from selecting a partner other than the default
"consumidor final".

After this commit, clicking the partner button correctly opens the "partner selection" popup.

opw-4171779
opw-4192162

Forward-Port-Of: odoo/enterprise#70559

Original PR description

The aim of this commit is to add an extra security in the test of the reporting framework.

Context:
Those line_id are used to recognize lines in the framework and also in the frontend by owl as t-key. Those line_id not being unique would result in a crash in the front-end framework (only from 17.0 as OWL is used starting version 17.0 on accounting reports).

Before the commit:
There isn't any test performed on the line_id property.

After the commit:
assertLinesValues will make sure that each line_id is unique for the generated data.

Back-ports the following commits:
 - https://github.com/odoo/enterprise/commit/fa3f03d859a35595990f34606c0864f9868e13fc
 - https://github.com/odoo/enterprise/commit/74000d6d5c8435bcaad93f7baf143abdf8593064
 - https://github.com/odoo/enterprise/commit/fed41d1b3042414823345d995eb173f7acb3c6dc

Co-authored-by: Brice Bartoletti <bib@odoo.com>

task-4063612

Forward-Port-Of: odoo/enterprise#70566
Forward-Port-Of: odoo/enterprise#68840

Original PR description

Community: https://github.com/odoo/odoo/pull/181488
Design Themes: https://github.com/odoo/design-themes/pull/940

Original PR description

The common SAFT test class has tags that will be passed to all inheriting test classes. We don't want that. Hence, we remove to tags and let the lower level test classes define those test tags.

Runbot error 99192

Forward-Port-Of: odoo/enterprise#70634

Original PR description

before this commit:
On mobile devices, the `Locating new addresses` and `Set up token` Bootstrap alerts are overlapping.

after this commit:
On mobile devices, the `Set up token` alert only becomes visible after the `Locating new addresses` process has been completed.

Task-3928322

Forward-Port-Of: odoo/enterprise#70552
Forward-Port-Of: odoo/enterprise#69822

Original PR description

## Description
Currently the ebay module logs as `INFO` the whole content of the JSON response coming from the Ebay API. This can bloat excessively the logs of databases, forcing customers to quickly exceed their disk quotas. We can just log this type of information as a DEBUG log.

## Reference
opw-4192547

Forward-Port-Of: odoo/enterprise#70626

Original PR description

Currently, a traceback is occurring if the net

To reproduce this issue:
1) Install accounting
2) Create a confirmed customer invoice with a product and tax
2) Open `Tax report` report from reporting

Error:-
```
TypeError: unsupported operand type(s) for /: 'float' and 'str'
```

This error is occurring after the recent changes from the commit https://github.com/odoo/enterprise/pull/68632/commits/f2bf719665dc3d19024d585e95d4913643b12572

We get `net_value` as an empty string from the below line https://github.com/odoo/enterprise/blob/7f3c71f03ff21dbfdda2763862f609445c4c9103/account_reports/models/account_generic_tax_report.py#L969-L970

But here `net_value` is used to calculate the error value, which leads to the above traceback

https://github.com/odoo/enterprise/blob/7f3c71f03ff21dbfdda2763862f609445c4c9103/account_reports/models/account_generic_tax_report.py#L1076-L1077

sentry-5842821270

Forward-Port-Of: odoo/enterprise#70620