Thursday, September 26, 2024
20 changes · saas-17.2
Resolved issues and error corrections
This fix restores the ability for users to mark or unmark a product as a favorite from the product form. It corrects a previous restriction that was applied too broadly, improving day-to-day product management without changing broader workflows.
Original PR description
readonly was added to product template in commit 0d75323600a14dd8964b0b3d29d69aa0fde3ee45 When it should've just been on product.product, so users were no longer able to set as favorite from form view. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change reverts a previous update to internal web test routes because those routes should not change in stable versions. It helps keep testing behavior consistent for the 17.2 release without affecting everyday user workflows.
Original PR description
Test routes were not meant to be changed in stable (17.2 and 17.4). This reverts commit d9035ae6b4a506044da4a499f112c3ac1f0e0b5d. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Restores the ability to mark and unmark products as favorites directly from the product form. This fixes a regression so users can continue using the familiar star button workflow without interruption.
Original PR description
A change was made in https://github.com/odoo/odoo/pull/168464 that made the favorite button unusable on the view. Customers were expecting the functionality to continue working as it has and being able to star and unstar on the form. opw-4142528
Miscellaneous changes
The Accounting and Benchmark dashboards were designed with a global filter working with months. But when filtering by quarter, everything breaks because formulas do not expect an input such as "Q4/2020". This commit disable the possibility to select quarters. Task: 4184088 Forward-Port-Of: odoo/enterprise#69991
Original PR description
The Accounting and Benchmark dashboards were designed with a global filter working with months. But when filtering by quarter, everything breaks because formulas do not expect an input such as "Q4/2020". This commit disable the possibility to select quarters. Task: 4184088 Forward-Port-Of: odoo/enterprise#69991
Backport of parts of https://github.com/odoo/enterprise/pull/60147/commits/976158bca652bc21765306ff5366a73e8982853b commit. When running Timer tests for single app install nightly builds, we were getting error, as timer tests needed timesheet_greed to be installed.  This pr is solving this issue by moving the test in timesheet_grid, and creating additional tests in time
Original PR description
Backport of parts of https://github.com/odoo/enterprise/pull/60147/commits/976158bca652bc21765306ff5366a73e8982853b commit. When running Timer tests for single app install nightly builds, we were getting error, as timer tests needed timesheet_greed to be installed.  This pr is solving this issue by moving the test in timesheet_grid, and creating additional tests in timer module. Forward-Port-Of: odoo/enterprise#67789
Make ShopFloor use IoT task: 4017327 Forward-Port-Of: odoo/enterprise#68706
Original PR description
Make ShopFloor use IoT task: 4017327 Forward-Port-Of: odoo/enterprise#68706
Previously, only users with accounting rights could see the `total_due` from the POS and therefore only they could settle dues from the POS. Basic POS users should be able to settle dues. This commit allows them to do so without granting them unnecessary rights, by creating an exception in the `get_total_due` method for users in `group_pos_user`. opw-[3976254](https://www.odoo.com/odoo/project.task/3976254?cids=1) Forward-Port-Of: odoo/enterprise#66953 Forward-Port-Of: odoo/enterprise#
Original PR description
Previously, only users with accounting rights could see the `total_due` from the POS and therefore only they could settle dues from the POS. Basic POS users should be able to settle dues. This commit allows them to do so without granting them unnecessary rights, by creating an exception in the `get_total_due` method for users in `group_pos_user`. opw-[3976254](https://www.odoo.com/odoo/project.task/3976254?cids=1) Forward-Port-Of: odoo/enterprise#66953 Forward-Port-Of: odoo/enterprise#66369
### Steps to reproduce: - Have two companies: COMP1, COMP2 - In the settings Enable Multi-step routes Prior to 17.2: - Inventory > Configuration > Warehouse Management > Locations - Unarchive: Virtual Locations/Inter-company transit and set is Return Locations - With COMP1: Create and confirm a PO with COMP2 as vendor for 10 units of a storable product - Validate the receipt and return. Select the Virtual Locations/Inter-company transit as return location and validate #### > On the POL
Original PR description
### Steps to reproduce: - Have two companies: COMP1, COMP2 - In the settings Enable Multi-step routes Prior to 17.2: - Inventory > Configuration > Warehouse Management > Locations - Unarchive:…
### Steps to reproduce: - Have two companies: COMP1, COMP2 - In the settings Enable Multi-step routes Prior to 17.2: - Inventory > Configuration > Warehouse Management > Locations - Unarchive: Virtual Locations/Inter-company transit and set is Return Locations - With COMP1: Create and confirm a PO with COMP2 as vendor for 10 units of a storable product - Validate the receipt and return. Select the Virtual Locations/Inter-company transit as return location and validate #### > On the POL the received quantity went from 10 to 20 rather than 0 #### Note: Starting from 17.2, the Inter-company transit location is the default location destination of the return rather than (Partner/Vendor). It also changed its reference to `stock_location_inter_company` so that the fix should be adapted in that version. ### Cause of the Issue: Currently, the qty_received is computed with respect to moves linkes to the POL. However, a move is flagged as a return only if the usage of its destination supplier (dropshipping and subcontracting flow excluded): https://github.com/odoo/odoo/blob/f494496b5142af23ee46ce249a1063f9d6caf403/addons/purchase_stock/models/stock_move.py#L247-L249 and if it is not flagged a return, its quantity is counted positively rather than negatively in the received quantity: https://github.com/odoo/odoo/blob/f494496b5142af23ee46ce249a1063f9d6caf403/addons/purchase_stock/models/purchase.py#L348-L370 opw-4190647 Forward-Port-Of: odoo/enterprise#70528 Forward-Port-Of: odoo/enterprise#70376
## Description Currently the ebay module logs as `INFO` the whole content of the JSON response coming from the Ebay API. This can bloat excessively the logs of databases, forcing customers to quickly exceed their disk quotas. We can just log this type of information as a DEBUG log. ## Reference opw-4192547 Forward-Port-Of: odoo/enterprise#70626
Original PR description
## Description Currently the ebay module logs as `INFO` the whole content of the JSON response coming from the Ebay API. This can bloat excessively the logs of databases, forcing customers to quickly exceed their disk quotas. We can just log this type of information as a DEBUG log. ## Reference opw-4192547 Forward-Port-Of: odoo/enterprise#70626
before this commit: On mobile devices, the `Locating new addresses` and `Set up token` Bootstrap alerts are overlapping. after this commit: On mobile devices, the `Set up token` alert only becomes visible after the `Locating new addresses` process has been completed. Task-3928322 Forward-Port-Of: odoo/enterprise#70552 Forward-Port-Of: odoo/enterprise#69822
Original PR description
before this commit: On mobile devices, the `Locating new addresses` and `Set up token` Bootstrap alerts are overlapping. after this commit: On mobile devices, the `Set up token` alert only becomes visible after the `Locating new addresses` process has been completed. Task-3928322 Forward-Port-Of: odoo/enterprise#70552 Forward-Port-Of: odoo/enterprise#69822
Updated the tax names, descriptions, and invoice labels to be more clear. Added an additional tax group for exempt. task-4196993 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180766
Original PR description
Updated the tax names, descriptions, and invoice labels to be more clear. Added an additional tax group for exempt. task-4196993 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180766
Situation: Field `ir.models.fields.field_description` has value `{"en_US": "Foo", "fr_FR": "", "nl_NL": "Baz"}` in database. When using `EXCLUDED.{quote(fname)}`, the value of keys `fr_FR` and `nl_NL` will be lost. Solution: Use `ir.models.fields.field_description || EXCLUDED.field_description` to overwrite part of the value instead of replacing the old value. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#18097
Original PR description
Situation:
Field `ir.models.fields.field_description` has value `{"en_US": "Foo", "fr_FR": "", "nl_NL": "Baz"}` in database. When using `EXCLUDED.{quote(fname)}`, the value of keys `fr_FR` and `nl_NL` will be lost.
Solution:
Use `ir.models.fields.field_description || EXCLUDED.field_description` to overwrite part of the value instead of replacing the old value.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#180970In de29ff9cee5be830b8d2aaf2c703f4f13ee24dec, we missed a tag for credit notes on PST tax for saskatchewan tax report. opw-3955926 Forward-Port-Of: odoo/odoo#181004
Original PR description
In de29ff9cee5be830b8d2aaf2c703f4f13ee24dec, we missed a tag for credit notes on PST tax for saskatchewan tax report. opw-3955926 Forward-Port-Of: odoo/odoo#181004
Steps to reproduce the bug: - Create a storable product “P1”: - vendors: -Azure interior, code: Vendor 1 - Deco Addict, code: Vendor 2 - Create a purchase order: - product P1 - Vendor: Azure interior > Description P1 [Vendor 1] - Create an Alternative PO: - Vendor: Deco Addict - Copy products: True Problem: The description of POL is incorrect: P1 [Vendor 1] instead of P1 [Vendor 2] opw-4133933 Forward-Port-Of: odoo/odoo#180798 Forward-Po
Original PR description
Steps to reproduce the bug:
- Create a storable product “P1”:
- vendors:
-Azure interior, code: Vendor 1
- Deco Addict, code: Vendor 2
- Create a purchase order:
- product P1
- Vendor: Azure interior
> Description P1 [Vendor 1]
- Create an Alternative PO:
- Vendor: Deco Addict
- Copy products: True
Problem:
The description of POL is incorrect: P1 [Vendor 1] instead of P1 [Vendor 2]
opw-4133933
Forward-Port-Of: odoo/odoo#180798
Forward-Port-Of: odoo/odoo#179487template data of model res.company: {id: values} template data of model account.journal, account.tax...: {xmlid: values} An error occurred when adding the x2many field to res.company and try load template --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180816
Original PR description
template data of model res.company: {id: values}
template data of model account.journal, account.tax...: {xmlid: values}
An error occurred when adding the x2many field to res.company and try load template
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#180816### Steps to reproduce: - Have two companies: COMP1, COMP2 - In the settings Enable Multi-step routes Prior to 17.2: - Inventory > Configuration > Warehouse Management > Locations - Unarchive: Virtual Locations/Inter-company transit and set is Return Locations - With COMP1: Create and confirm a PO with COMP2 as vendor for 10 units of a storable product - Validate the receipt and return. Select the Virtual Locations/Inter-company transit as return location and validate #### > On the POL
Original PR description
### Steps to reproduce: - Have two companies: COMP1, COMP2 - In the settings Enable Multi-step routes Prior to 17.2: - Inventory > Configuration > Warehouse Management > Locations - Unarchive:…
### Steps to reproduce: - Have two companies: COMP1, COMP2 - In the settings Enable Multi-step routes Prior to 17.2: - Inventory > Configuration > Warehouse Management > Locations - Unarchive: Virtual Locations/Inter-company transit and set is Return Locations - With COMP1: Create and confirm a PO with COMP2 as vendor for 10 units of a storable product - Validate the receipt and return. Select the Virtual Locations/Inter-company transit as return location and validate #### > On the POL the received quantity went from 10 to 20 rather than 0 ### Note: Starting from 17.2, the Inter-company transit location is the default location destination of the return rather than (Partner/Vendor). It also changed its reference to `stock_location_inter_company` so that the fix should be adapted in that version. ### Cause of the Issue: Currently, the qty_received is computed with respect to moves linkes to the POL. However, a move is flagged as a return only if the usage of its destination supplier (dropshipping and subcontracting flow excluded): https://github.com/odoo/odoo/blob/f494496b5142af23ee46ce249a1063f9d6caf403/addons/purchase_stock/models/stock_move.py#L247-L249 and if it is not flagged a return, its quantity is counted positively rather than negatively in the received quantity: https://github.com/odoo/odoo/blob/f494496b5142af23ee46ce249a1063f9d6caf403/addons/purchase_stock/models/purchase.py#L348-L370 opw-4190647 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181126 Forward-Port-Of: odoo/odoo#180846
Steps to reproduce: - Install "Sendcloud Delivery" and configure it for belgium with a belgium website. - Once configured buy a product and go through the checkout process. - During carrier selection select any "Point relais". - Go back to the previous step (Shipping address selection). - Go again to checkout. Issues: The previous location is shown but we also see available point relais as if we didn't select it. In order to solve this issue we need to not reset access point if `fo
Original PR description
Steps to reproduce: - Install "Sendcloud Delivery" and configure it for belgium with a belgium website. - Once configured buy a product and go through the checkout process. - During carrier selection select any "Point relais". - Go back to the previous step (Shipping address selection). - Go again to checkout. Issues: The previous location is shown but we also see available point relais as if we didn't select it. In order to solve this issue we need to not reset access point if `forceClickCarrier` is on. We also call `_getCurrentLocation` before potentially clicking on the carrier, if we found a location `forceClickCarrier` is set to false as we have don't need to show point relais. Another issue was also met when testing the fix. If we changed shipping methods access point was not reseted to fix this we reset `access_point_address` in the `/shop/cart/update_address` route. opw-4050542 Forward-Port-Of: odoo/odoo#176030
This change allows us to practically revive the 'real price' costing method via customization, specifically using the stock_valuation_fifo_lot OCA module. By making `qty_taken_on_candidate` adjustable in the `_run_fifo()` method, we can fine-tune the FIFO calculation to better suit real price costing needs. @qrtl QT4650 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180245
Original PR description
This change allows us to practically revive the 'real price' costing method via customization, specifically using the stock_valuation_fifo_lot OCA module. By making `qty_taken_on_candidate` adjustable in the `_run_fifo()` method, we can fine-tune the FIFO calculation to better suit real price costing needs. @qrtl QT4650 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180245
Before this commit, the IOT was using an old system to render pages on the IOT box. This commit refactors the homepage to use the new owl system. taskId: 4134163 Forward-Port-Of: odoo/odoo#177895
Original PR description
Before this commit, the IOT was using an old system to render pages on the IOT box. This commit refactors the homepage to use the new owl system. taskId: 4134163 Forward-Port-Of: odoo/odoo#177895
In the Inventory Adjustments view, it is currently possible to select any user for a count request or assign any user to a specific stock.quant, even portal users. This fix ensures only stock users are selected. task 4207784 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181376
Original PR description
In the Inventory Adjustments view, it is currently possible to select any user for a count request or assign any user to a specific stock.quant, even portal users. This fix ensures only stock users are selected. task 4207784 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181376