Thursday, September 26, 2024
24 changes · saas-17.4
Enhancements to existing features
This update lets module manifests mark selected files, such as custom JavaScript guided tours, so they are excluded from maintenance line-of-code calculations. This helps keep maintenance metrics focused on relevant product code and avoids charging or reporting instructional tour content as maintained code.
Original PR description
In the context of the industries we want to create custome js tours. The role of these tours is to explain some flows to the user in a more intuitive version than text. Currently those tours are counted in the mainenance line of code. This comportment is not intended. After this commit, we will look at the cloc_excluded argument in the manifest and exclude those from the maintenance line of code. task-4056239 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adds the missing test setup needed for a new Studio form dialog service. It helps keep Studio's automated checks reliable and reduces the risk of future changes breaking related behavior.
Original PR description
This commit add the dependecies for the new service hasFormViewInDialog on the studio tests.
Resolved issues and error corrections
Website administrators can once again find and select shop page links in autocomplete when editing restricted website content, even if public ecommerce access is disabled. This prevents editors from being blocked when linking to shop pages intended for non-public or controlled areas of the site.
Original PR description
Finetuning of #176391, when ecommerce access was disabled to public users, the admin were unable to reference /shop urls even in restricted parts of the website if needed, because autocomplete didn't suggest those links anymore.
Miscellaneous changes
In the Inventory Adjustments view, it is currently possible to select any user for a count request or assign any user to a specific stock.quant, even portal users. This fix ensures only stock users are selected. task 4207784 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181376
Original PR description
In the Inventory Adjustments view, it is currently possible to select any user for a count request or assign any user to a specific stock.quant, even portal users. This fix ensures only stock users are selected. task 4207784 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181376
The language selection dropdown in the editor toolbar now has a height limit and scrolls when many languages are available. This prevents it from extending beyond the screen, making translation workflows easier to use.
Original PR description
Description of the issue this PR addresses: Current behavior before PR: When many languages were installed, the translate dropdown would become too large and overflow out of the screen. Desired behavior after PR is merged: The translate dropdown has a maximum height of 40vh and scrolls if the content overflows, ensuring it stays within the viewport. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The product attribute value list no longer shows a deletion confirmation for items that have not yet been saved. This prevents an error when users try to delete a new, unsaved value and keeps the product setup flow smooth.
Original PR description
Steps to reproduce: 1) Create new attribute value (do not save) 2) Click on delete 3) Confirm deletion in the dialog Reason: When the record is new it does not have resId. But `unlink` only accepts list of type 'number' otherwise it throws an error.
When users add documents to a bill of materials, the attachment list now refreshes right away instead of requiring a page reload. This prevents confusion and makes document uploads feel reliable in manufacturing workflows.
Original PR description
In https://github.com/odoo/odoo/pull/152286, we changed the documents that are added to the chatter of a BoM to be added to the product_product directly (or the template if there are no product on the BoM). However, some changes in mail made the just-added document not appear untill reload. This commit fixes it by reloading the chatter when adding an attachment. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an issue where removing a previously set markup did not properly reset the related discount to zero. This helps keep product pricing accurate when users adjust pricelist rules.
Original PR description
If markup is set to a value then reset to 0, the discount is not properly reset to 0. This commit removes `if item.price_markup` as it was wrong. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes an issue in Point of Sale where adding some products to the cart could fail if they did not have an archived variant. It helps ensure cashiers can add valid products smoothly without unexpected checkout interruptions.
Original PR description
Before this commit, attempting to add a product to the cart that did not have an archived variant would result in an error. opw-4212973 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Event badge printing has been adjusted so more information fits cleanly on badges, with smaller text and reduced margins. Long event or ticket names are now shortened automatically, and printer positioning can be managed directly on the printer for more reliable output.
Original PR description
- Reduced the side margins to allow more text to fit - Decreased the font sizes slightly for the event name and ticket name - Removed the printing offset commands so that offsets can be configured on the printer - Added a text length limit when printing the event name, that will truncate with a '...' - Used `markupsafe.Markup` to stop characters from being escaped when sent to the printer --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an error that appeared when users opened the signed documents view from a Sign template with no related records. This prevents a disruptive traceback and keeps the Sign workflow usable from the kanban view.
Original PR description
**Version:** - saas-17.4 **Steps to reproduce:** - activate debug mode - go to template with no sign record - click on the "signed document" state button or option from the template kanban **Issue:** - it was giving traceback when clicking on "signed documents". **Cause:** - an UncaughtPromiseError was triggered due to an undefined 'noContentHelp' prop in the SignActionHelper component. **Solution:** - removed the 'noContentHelp' prop from the SignActionHelper component to prevent the validation error as it is not used at anywhere. task-4098729
The Sign app no longer shows the “Request Signature” option when viewing existing signature requests. This prevents users from triggering an error from an action that is not supported in that context.
Original PR description
Versions: ------------ saas-17.4 Steps to Reproduce: --------------------------- 1. Go to the All Documents menu. 2. Click on "Details" from the kanban dropdown. 3. Select "Request Signature" from the cog menu. Issue: --------- A `ValueError` occurs: `Wrong value for sign.request.reference_doc: 'sign.request,1'`. Cause: --------- The `reference_doc` field restricts the `sign.request` model in the `selection_target_model`. Solution: ----------- Hide the "Request Signature" option in the cog menu. task: 4175789
readonly was added to product template in commit 0d75323600a14dd8964b0b3d29d69aa0fde3ee45 When it should've just been on product.product, so users were no longer able to set as favorite from form view. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181531
Original PR description
readonly was added to product template in commit 0d75323600a14dd8964b0b3d29d69aa0fde3ee45 When it should've just been on product.product, so users were no longer able to set as favorite from form view. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181531
Test routes were not meant to be changed in stable (17.2 and 17.4). This reverts commit d9035ae6b4a506044da4a499f112c3ac1f0e0b5d. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181576
Original PR description
Test routes were not meant to be changed in stable (17.2 and 17.4). This reverts commit d9035ae6b4a506044da4a499f112c3ac1f0e0b5d. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181576
This change allows us to practically revive the 'real price' costing method via customization, specifically using the stock_valuation_fifo_lot OCA module. By making `qty_taken_on_candidate` adjustable in the `_run_fifo()` method, we can fine-tune the FIFO calculation to better suit real price costing needs. @qrtl QT4650 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180245
Original PR description
This change allows us to practically revive the 'real price' costing method via customization, specifically using the stock_valuation_fifo_lot OCA module. By making `qty_taken_on_candidate` adjustable in the `_run_fifo()` method, we can fine-tune the FIFO calculation to better suit real price costing needs. @qrtl QT4650 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180245
Suppose the following structure: ---------------------------------------------- BoM of Main kit: - BoM Type: Kit - Quantity: 4 - Components: * 1 x Sub kit A * 1 x Sub kit B BoM of Subkit A: - BoM Type: Kit - Quantity: 1 - Components: * 2 x Component A (Cost: $10, Storable) BoM of Subkit B: - BoM Type: Kit - Quantity: 1 - Components: * 2 x Component B (Cost: $6, Storable) When creating a sale order for 1 Main Kit, delivering the components
Original PR description
Suppose the following structure: ---------------------------------------------- BoM of Main kit: - BoM Type: Kit - Quantity: 4 - Components: * 1 x Sub kit A * 1 x Sub kit B BoM of Subkit A: - BoM…
Suppose the following structure:
----------------------------------------------
BoM of Main kit:
- BoM Type: Kit
- Quantity: 4
- Components:
* 1 x Sub kit A
* 1 x Sub kit B
BoM of Subkit A:
- BoM Type: Kit
- Quantity: 1
- Components:
* 2 x Component A (Cost: $10, Storable)
BoM of Subkit B:
- BoM Type: Kit
- Quantity: 1
- Components:
* 2 x Component B (Cost: $6, Storable)
When creating a sale order for 1 Main Kit, delivering the components and posting the invoice, the Cost Of Goods Sold computed by the _stock_account_get_anglo_saxon_price_unit method was ignoring the COGS for the Subkit B.
This is due to the commit https://github.com/odoo/odoo/commit/31e1352df686d8a23628ade83d321929c49d6f4e which fetches the BOMs from the stock moves linked to the Sale Order. As no component is present directly in the bom lines of the Main Kit BOM, the bom was omitted.
Now, if the product's bom is not present in the stock move's bom, we'll fetch one the old way.
opw-4033293
Forward-Port-Of: odoo/odoo#178321
Forward-Port-Of: odoo/odoo#174853template data of model res.company: {id: values} template data of model account.journal, account.tax...: {xmlid: values} An error occurred when adding the x2many field to res.company and try load template --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180816
Original PR description
template data of model res.company: {id: values}
template data of model account.journal, account.tax...: {xmlid: values}
An error occurred when adding the x2many field to res.company and try load template
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#180816Steps to reproduce the bug: - Create a storable product “P1”: - vendors: -Azure interior, code: Vendor 1 - Deco Addict, code: Vendor 2 - Create a purchase order: - product P1 - Vendor: Azure interior > Description P1 [Vendor 1] - Create an Alternative PO: - Vendor: Deco Addict - Copy products: True Problem: The description of POL is incorrect: P1 [Vendor 1] instead of P1 [Vendor 2] opw-4133933 Forward-Port-Of: odoo/odoo#180798 Forward-Po
Original PR description
Steps to reproduce the bug:
- Create a storable product “P1”:
- vendors:
-Azure interior, code: Vendor 1
- Deco Addict, code: Vendor 2
- Create a purchase order:
- product P1
- Vendor: Azure interior
> Description P1 [Vendor 1]
- Create an Alternative PO:
- Vendor: Deco Addict
- Copy products: True
Problem:
The description of POL is incorrect: P1 [Vendor 1] instead of P1 [Vendor 2]
opw-4133933
Forward-Port-Of: odoo/odoo#180798
Forward-Port-Of: odoo/odoo#179487In de29ff9cee5be830b8d2aaf2c703f4f13ee24dec, we missed a tag for credit notes on PST tax for saskatchewan tax report. opw-3955926 Forward-Port-Of: odoo/odoo#181004
Original PR description
In de29ff9cee5be830b8d2aaf2c703f4f13ee24dec, we missed a tag for credit notes on PST tax for saskatchewan tax report. opw-3955926 Forward-Port-Of: odoo/odoo#181004
Situation: Field `ir.models.fields.field_description` has value `{"en_US": "Foo", "fr_FR": "", "nl_NL": "Baz"}` in database. When using `EXCLUDED.{quote(fname)}`, the value of keys `fr_FR` and `nl_NL` will be lost. Solution: Use `ir.models.fields.field_description || EXCLUDED.field_description` to overwrite part of the value instead of replacing the old value. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#18097
Original PR description
Situation:
Field `ir.models.fields.field_description` has value `{"en_US": "Foo", "fr_FR": "", "nl_NL": "Baz"}` in database. When using `EXCLUDED.{quote(fname)}`, the value of keys `fr_FR` and `nl_NL` will be lost.
Solution:
Use `ir.models.fields.field_description || EXCLUDED.field_description` to overwrite part of the value instead of replacing the old value.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#180970Updated the tax names, descriptions, and invoice labels to be more clear. Added an additional tax group for exempt. task-4196993 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180766
Original PR description
Updated the tax names, descriptions, and invoice labels to be more clear. Added an additional tax group for exempt. task-4196993 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#180766
The Accounting and Benchmark dashboards were designed with a global filter working with months. But when filtering by quarter, everything breaks because formulas do not expect an input such as "Q4/2020". This commit disable the possibility to select quarters. Task: 4184088 Forward-Port-Of: odoo/enterprise#69991
Original PR description
The Accounting and Benchmark dashboards were designed with a global filter working with months. But when filtering by quarter, everything breaks because formulas do not expect an input such as "Q4/2020". This commit disable the possibility to select quarters. Task: 4184088 Forward-Port-Of: odoo/enterprise#69991
## Description Currently the ebay module logs as `INFO` the whole content of the JSON response coming from the Ebay API. This can bloat excessively the logs of databases, forcing customers to quickly exceed their disk quotas. We can just log this type of information as a DEBUG log. ## Reference opw-4192547 Forward-Port-Of: odoo/enterprise#70626
Original PR description
## Description Currently the ebay module logs as `INFO` the whole content of the JSON response coming from the Ebay API. This can bloat excessively the logs of databases, forcing customers to quickly exceed their disk quotas. We can just log this type of information as a DEBUG log. ## Reference opw-4192547 Forward-Port-Of: odoo/enterprise#70626
before this commit: On mobile devices, the `Locating new addresses` and `Set up token` Bootstrap alerts are overlapping. after this commit: On mobile devices, the `Set up token` alert only becomes visible after the `Locating new addresses` process has been completed. Task-3928322 Forward-Port-Of: odoo/enterprise#70552 Forward-Port-Of: odoo/enterprise#69822
Original PR description
before this commit: On mobile devices, the `Locating new addresses` and `Set up token` Bootstrap alerts are overlapping. after this commit: On mobile devices, the `Set up token` alert only becomes visible after the `Locating new addresses` process has been completed. Task-3928322 Forward-Port-Of: odoo/enterprise#70552 Forward-Port-Of: odoo/enterprise#69822