Daily updates from Odoo
Thursday, September 26, 2024
42 changes
3 changes
Resolved issues and error corrections
This fix restores the ability for users to mark or unmark a product as a favorite from the product form. It corrects a previous restriction that was applied too broadly, improving day-to-day product management without changing broader workflows.
Original PR description
readonly was added to product template in commit 0d75323600a14dd8964b0b3d29d69aa0fde3ee45 When it should've just been on product.product, so users were no longer able to set as favorite from form view. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change reverts a previous update to internal web test routes because those routes should not change in stable versions. It helps keep testing behavior consistent for the 17.2 release without affecting everyday user workflows.
Original PR description
Test routes were not meant to be changed in stable (17.2 and 17.4). This reverts commit d9035ae6b4a506044da4a499f112c3ac1f0e0b5d. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Restores the ability to mark and unmark products as favorites directly from the product form. This fixes a regression so users can continue using the familiar star button workflow without interruption.
Original PR description
A change was made in https://github.com/odoo/odoo/pull/168464 that made the favorite button unusable on the view. Customers were expecting the functionality to continue working as it has and being able to star and unstar on the form. opw-4142528
2 changes
Resolved issues and error corrections
Fixes an issue where action buttons in Documents could remain incorrect after switching folders while previewing a document. This helps users see the right controls for the folder they are working in and avoids confusion during document management.
Original PR description
…ewing This commit fixes the remaining actions after switching folders while previewing a document.
Fixes an issue where dragging a single document could show an unclear “undefined” message in kanban and list views. It also keeps the owner avatar and activity icon consistently positioned at the bottom of document cards, making the interface cleaner and easier to read.
Original PR description
This commit fix the 'undefined' message when trying to drag and drop a single document in the kanban and list view. It also fix the owner avatar and activity icon to always stick to the bottom of the kanban card.
36 changes
Resolved issues and error corrections
Mention links in Mail now use matching link details so users are sent to the correct record. This restores expected navigation from mentions and prevents failed redirects caused by inconsistent URL formatting.
Original PR description
This PR corrects an issue introduced in [1], where the `base href` of mention URLs was converted from `web` to `odoo`, but the associated query parameters were not updated accordingly. As a result, the redirection to the proper record failed. [1]: https://github.com/odoo/odoo/pull/174516 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error when adding products to a sales quotation for customers with an analytic distribution model that has no distribution lines. It ensures the quotation flow continues normally instead of showing a traceback, improving reliability for accounting-enabled sales workflows.
Original PR description
Steps --------- 1. Install `accounting` and `sale_management` 2. Activate Accounting > Configuration > Settings > Analytics > Analytic Accounting 3. Accounting > Configuration > Analytic Accounting > Distribution Model 4. Create a new model and only put Deco Addict as partner, then save 5. Go to the Sale app 6. New quotation 7. Select Deco Addict as partner 8. Click `Add a product`, a traceback is raised. Problem --------- Using `|=` requires two objects of the same type. Unfortunately, when there is no distribution line, `analytic_distribution` is False whereas `res` is a dict. Solution --------- Use a empty dict instead when `analytic_distribution` is False. V18 Accounting PAD issues --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes the table border color in the stock rule diagram so the report displays with the intended visual styling. It is a small presentation correction that helps users read inventory rule diagrams more clearly and consistently.
Original PR description
In the stock rule diagram, the table border color was not correct anymore. before:  after:  Retarget of https://github.com/odoo/odoo/pull/181395 task-id: 4207218 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Sales order previews now show the same Terms and Conditions content as the PDF invoice. This prevents customers from seeing only a webpage link when custom text or images were added to the order notes, improving consistency across sales documents.
Original PR description
Problem: When the option "Add a link to a Web Page" is enabled, the preview page always shows the T&C link regardless of the content added to the notes. This behavior is inconsistent with the T&C section in the PDF invoice. Steps to reproduce: - Enable "Add a link to a Web Page." - Create a new Sales Order (SO). - Add content (text or image) to the notes. - Confirm and preview the SO. - The added content does not appear in the T&C section. opw-4170021 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Restaurant floor plans with background images now allow tables to be dragged correctly in Chrome on iOS. This prevents the browser context menu from interrupting staff when linking or repositioning tables.
Original PR description
Table linking in chrome on ios does not work if the floorplan has a bg image. When the user tries to drag a table, the context menu appears, which prevents the table dragging from taking place. This is because of a mistake in commit 894d7c25b7dd216ac6df1fd8ebedffccd20ef64e, where a line was removed. Task: 4196350 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The loyalty rewards page now hides the claim button when a customer has no rewards available. This prevents confusing prompts and makes the shopping experience clearer.
Original PR description
Before the commit: The button label remained as 'Claim' even when there were no rewards, which seemed inconsistent. After this commit: The button gets hidden when no rewards are available.
This fixes an editor issue where deleting selected paragraphs near a horizontal line could add extra blank space under the line. Users can now edit content around horizontal rules without the layout being unexpectedly altered.
Original PR description
Steps: 1. have a horizontal rule (HR) and two paragraphs in the editor 2. make a selection across the two paragraphs 3. press backspace or delete Result: the HR gets filled with a BR element, leading to a vertical space being added below it. The isShrunkBlock function is typically used to detect blocks that need to have a BR element added to it, otherwise they would be displayed collapsed in the editor. Before this commit, the HR element was (incorrectly) considered as a shrunk block. The issue described above happened because the deleteRange method, after removing nodes as joining blocks, looks for shrunk blocks and fills them with a BR element.
Deleting a Point of Sale order now removes its linked records first, preventing errors during the deletion process. This makes order cleanup more reliable for cashiers and back-office users.
Original PR description
Before when deleting an order, we removed the order and after related records. This caused an error when trying to remove the order because the related records try to access the order. Now we remove the related records first and then the order.
This fix makes an image editing test run consistently instead of failing unpredictably. It helps keep the editor quality checks dependable, reducing noise for development and release validation without changing user-facing behavior.
Original PR description
Before this commit, the @html_editor/image/Image transformation dissapear when selection change test was failing unpredictably. This commit fix it. Backward-port of #181200
Website price list snippets have been moved into the Text category so users can find them in a more logical place. This is a small usability fix that improves content editing organization without changing website behavior.
Original PR description
This commit moves the price list snippets to a more appropriate category: Text task-4212916 Requires: - https://github.com/odoo/design-themes/pull/942 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix corrects an internal reference used when selecting a cashier in Point of Sale with employee support. It prevents cashier selection from failing because the system was looking for an outdated item name.
Original PR description
Item does not exist anymore on the employee list in the select cashier mixin. Adapt the code to use the correct variable name.
The Reset to Draft button is available again for payments that are still in process. This lets users correct or revise these payments before they reach stages where resetting is no longer allowed, while validated and sent payments remain protected.
Original PR description
This commit Restore "Reset to Draft" on Payments "In Process". Only Validated & Sent Payments can not be Reset to Draft. task: 4213210 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The website visitor view now adds proper spacing between SMS and chat buttons. This small visual fix makes the buttons easier to distinguish and improves the overall presentation for visitors and staff using the interface.
Original PR description
before this commit there is no space between 'sms' and 'chat' buttons. after this commit added a space between both buttons. enterprise PR-https://github.com/odoo/enterprise/pull/70742 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes the website call-to-action card snippet so its styling is applied correctly. Users will see the intended card colors and borders when using this website building block.
Original PR description
In commit [1], the new `s_cta_card` snippet has been added. It uses the `s_card` inner snippet. This commit fixes the card: - add the missing `data-snippet` attribute, - fix the versioning: indeed, it was using `data-vcss` while the inner snippet in fact uses `data-vxml`. This caused the card background colors to be washed out, instead of being the real selected color. - fix the `border-width` style: it was missing the `px` unit and the `!important` that would be added if we used the option to set it. [1]: https://github.com/odoo/odoo/commit/4b88c63a96e84f5a603eea35fee3a395fbb4aae3 Related to task-4094392
The website loading screen no longer shows the "follow the tips" message while interactive website tours are not working correctly. This avoids directing users to a broken or unreliable guidance feature until a proper fix is available.
Original PR description
Website user/interactive tours are not properly working at the moment. This disables the "follow the tips" message in the website loader while waiting for a fix. Follow-up of https://github.com/odoo/odoo/pull/180471 Related to task-3084175
This fix updates newer Kanban views so outdated bold and display settings are no longer applied where they are unsupported. It helps keep Kanban card styling consistent and encourages the supported Bootstrap styling approach, while preserving compatibility for older legacy Kanban layouts.
Original PR description
*in new API kanban views. Those attributes are no longer supported as the css rules associated with the classname they generate are scoped to legacy kanban. Instead, we want to encourage the use of bootstrap utility classes (e.g. fw-bold). Note: those attributes were no longer used in standard views. Note 2: we keep supporting them in legacy archs (those using "kanban-box"). The support of legacy archs will be dropped after v18. Part of task~3992107 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Mobile users can now open the emoji reaction picker without the phone keyboard covering it. This makes adding reactions easier and avoids a frustrating display issue on smaller screens.
Original PR description
Before this commit: In mobile view, when the 'Add a reaction' action is clicked, the EmojiPicker opens, but the native keyboard also appears due to the focus being on the input field. This causes the keyboard to block the view of the EmojiPicker. After this commit: Now, in mobile view, the input search bar will not be automatically focused when the EmojiPicker opens, preventing the native keyboard from appearing and obstructing the EmojiPicker. task-4208499
This update fixes several issues in Odoo's data population tooling so it works more reliably across different database permissions and newer field storage formats. It also restores missing help information in the command-line interface, making the tool easier to use and troubleshoot.
Original PR description
## [FIX] tools: variate `company_dependent` dates Following de302c2d36305c0d7562572a30587641eabfe914, `company_dependent` fields are stored as `jsonb` now, so the variation of dates needs to take that into account. ## [FIX] tools: allow populate for less priviledged `pg_roles` When running the `populate` with a `pg_roles` that doesn't have admin access or the group `session_replication_role` (only since PG15), the routine crashes with an Insufficient exception when trying to drop the Fkey constriants. This context manager was initially added to speed up batch insertion by 10x, but we are adding a generic catch to ignore said optimisation when privileges are insufficient. ## [FIX] cli: show --help for populate CLI Group options were added with the respective `help` section for each arg, but the group was never added to the CLI arg parser. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an editing issue where deleting content below a separator could add an unwanted blank line inside the separator. This keeps page content cleaner and avoids small visual glitches when users edit formatted text.
Original PR description
Before this commit: delete an empty line under a separator and some text adds a br element to the separator After this commit: the br won't be added to hr element because it already has a visible height --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Product categories now record changes to their costing method in the activity log. This helps teams see when costing rules were changed, improving traceability for inventory valuation and accounting reviews.
Original PR description
This commit enables tracking of the costing method in chatter for the product category.
This change prevents the HTML editor from crashing when users drag selected table cells into content outside the table. It improves editing reliability and adds a test to help ensure the issue does not return.
Original PR description
Before this commit: in a table, select last two cells of first row and drag drop it to a p element out of the table, a traceback is raised After this commit: the traceback is fixed, the added test only simulate the to be pasted content when drag and drop the selected cells --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The editor now applies the correct spacing to the placeholder text shown inside empty quote blocks. This makes the editing experience look cleaner and ensures the placeholder appears where typed text will actually begin.
Original PR description
This commit adds the styling rules for the blockquote (present in the web_editor module), and fixes the padding for the hint that is displayed when the blockquote is empty. Before this commit, the hint would be displayed on the top left corner of the blockquote without any padding, which, other than looking bad, does not match the position in which the text is inserted after typing. task-4207507
Corrects a website page template so parallax sections no longer duplicate the background positioning setting. This helps ensure newly created service pages render cleaner markup and avoids potential visual inconsistencies.
Original PR description
The `new_page_template_services_s_parallax` template wrongly adds the `background-position` of the `style` attribute. This commit fixes this definition so that the old `background-position` is replaced. Steps to reproduce: - Add a new page - In the Service tab, pick a template that contains a parallax block (at the time of writing, this is the case of the second one in the first column) - Inspect the parallax block => The `background-position` was defined twice. task-4206845
The message composer now shows clearer placeholder text when replying in subchannels. This avoids using the # symbol, which can make a thread look like a channel and confuse users.
Original PR description
Purpose of this commit: Adjust the placeholder text for subchannels, as it previously included the '#' symbol, which typically denotes a channel rather than a thread Before  After 
Fixes an issue where temporary preview content could remain visible when replacing an outdated website editor snippet. This keeps the editing experience cleaner and prevents unwanted placeholder elements from appearing in updated page content.
Original PR description
Since commit [1], the snippets are dropped by using a snippets dialog. In order for dynamic elements to be visible in the modal, fake previews are used. They are then removed once the snippet is dropped. These previews can be recognized by their `s_dialog_preview` class. When a snippet is deprecated, a message is displayed in the right panel, informing that it is outdated and allowing to therefore replace it by its new version. However, in the case where the new version would have a dialog preview in it, this preview would not be removed. This commit handles the dialog previews removal when replacing an outdated snippet. [1]: https://github.com/odoo/odoo/commit/edf81c13d8f2f6d29a77d68cbfa0dc9216da3c2a task-4185274
The mobile app now handles expected permission-related responses during startup without showing or logging disruptive unhandled errors. This helps make app launch more reliable when native device permissions are requested for the first time.
Original PR description
In the Native Mobile Apps when we use a Native method that requires a permission the promise is rejected on the first call. This commit avoids to generate `unhandledrejection` in this case.
This fix prevents styling meant for grid views from affecting empty-state messages in other parts of Odoo. Users should see more consistent layout behavior across views, with the grid view still displaying its no-content helper correctly.
Original PR description
Before this commit, the 3c7775f4c7a3efaa891bc31072c41abff24edfad commit adds some style to correctly display the noContent helper inside the grid view. The problem is the selector used to apply that styling is too generic and not specific to the grid view which can alter the position of the no content helper in other views. This commit makes sure the style added for the grid view is only applied inside the grid view and not somewhere else. task-4207210
This fix prevents an error when calculating allocated hours for open shifts that do not yet have a resource assigned. It improves reliability in planning by safely checking that a resource exists before using its scheduling settings.
Original PR description
Before this commit, the compute of the allocated hours could be raised a traceback if the shift is an open one because we check if the resource is flexible before checking if there is a resource set on the shift. This commit makes sure a resource exists on the shift before checking if the resource is flexible or not. task-4206945
A Web Studio automated test now checks that required optional apps are installed before running. This prevents false failures in limited test environments and helps keep release validation stable without changing business features.
Original PR description
**Before this commit** Tests on test_23_export_hardcoded_models_and_fields function break on single app tests because we are trying to find models from PRESET_MODELS_DEFAULTS in runbot that do not actually exist in self.env if we do not install extra modules like hr, crm, etc. **After this commit** This test checks beforehand if some needed modules are all installed.
This fixes the layout of the SMS and Chat buttons so they no longer appear too close together. The change improves readability and makes the visitor contact options look cleaner for users.
Original PR description
before this commit there is no space between 'sms' and 'chat' buttons. after this commit added a space between both buttons.
Creating multiple restaurant appointments in a row no longer triggers an error in the back-office calendar. The calendar now relies on its normal data update process, preventing the wrong booking from being reloaded.
Original PR description
Before when creating two appointment one by one, an error was raised for the second appointment. This was due to the fact that the calendar view was refreshed with a wrong active id. This commit remove the view refresh since the view itself make a RPC to get the new data.
Users customizing Kanban views in Studio can now reliably turn bold formatting on or off for fields. This fixes a styling issue so visual changes made in the editor are correctly reflected in the view.
Original PR description
Before this commit, toggling the bold attribute on a field in a (new API) kanban view didn't work. This was because the feature wasn't fully implemented (in web) for new API kanban. Indeed, the class "o_text_bold" was correctly set, but the associated css rule was scoped for legacy kanban records. Instead of fixing it in web, we rather want to promote the use of bootstrap utility class. So instead of setting the `bold` attribute, we toggle the `fw-bold` classname.
The appointment demo setup now shows the table booking appointment as "Table" instead of "Table Booking". This avoids a confusing label on the booking page and keeps the demo experience aligned with the intended naming.
Original PR description
**How to reproduce** Create a Table Booking appointment from the Action helper Go to the booking page for that appointment it looks like this - https://tinyurl.com/29q2ktjb **After this PR** Now that appointment name will be Table instead of Table Booking Backport of this commit - https://github.com/odoo/enterprise/pull/70643/commits/209aeae1f5d6689ef15fd8016cbcd08b03710f6f Task-4210749
Portal users can now switch to the document list view without seeing a client error. This improves reliability for external users accessing shared documents through the portal.
Original PR description
When portal users try to switch to the list view, they get a client error. The error is solved by keeping the studio service accessible to the ListRenderer. task-3373836
This fixes an issue where marketing automation for website sales used the wrong website field when filtering sales teams. Campaign targeting should now work more reliably for businesses using multiple websites or website-specific sales flows.
Original PR description
website_id is not defined on sale teams... website_ids is. "False" should be False... task-4210343
Spreadsheet pivot views now correctly support using the same field with multiple calculation methods. This prevents incorrect or missing pivot results and keeps spreadsheet reporting aligned with the related pivot view fix.
Original PR description
This commit is the counter part of https://github.com/odoo/odoo/pull/181354 and adapt a test to the fix of the pivot view in spreadsheet. Task: 4207668
1 change
Resolved issues and error corrections
This update fixes a tooltip positioning issue in the Documents module's search panel. The change aligns the Documents tests with improvements made to the core platform, ensuring the search interface displays correctly and provides better user experience when hovering over search options.
Original PR description
This commit adapts documents tests to changes made in https://github.com/odoo/odoo/pull/180776