Saturday, September 28, 2024
11 changes · saas-17.4
Miscellaneous changes
[Real Decreto-ley 4/2024] of June 26, 2024 introduces some changes to the tax rates to address the economic and social consequences arising from the conflicts in Ukraine and the Middle East. The VAT reductions of 5% (pasta and seed oils) and 0% (basic foodstuffs and olive oils) previously introduced will be increased to 7.5% and 2%, respectively, starting on October 1, 2024. The rates of the equivalence surcharge applicable to these products will increase from 0.6% and 0%, to 1% and 0.26%,
Original PR description
[Real Decreto-ley 4/2024] of June 26, 2024 introduces some changes to the tax rates to address the economic and social consequences arising from the conflicts in Ukraine and the Middle East. The VAT reductions of 5% (pasta and seed oils) and 0% (basic foodstuffs and olive oils) previously introduced will be increased to 7.5% and 2%, respectively, starting on October 1, 2024. The rates of the equivalence surcharge applicable to these products will increase from 0.6% and 0%, to 1% and 0.26%, respectively. An upgrade script is provided that automatically disables the deprecated VAT of 5% and Rec. Eq. of 0.62% when upgrading the `l10n_es` module. [Real Decreto-ley 4/2024]: https://www.boe.es/buscar/act.php?id=BOE-A-2024-12944 [task-4147046](https://www.odoo.com/odoo/all-tasks/4147046) Related to https://github.com/odoo/enterprise/pull/69736 Forward-Port-Of: odoo/odoo#181783 Forward-Port-Of: odoo/odoo#179797
in appraisal, the method `_check_validity` is overriden to make different checks in case of `answer_wrong_user`, to make sure that all the checks are OK before handling `answer_wrong_user` case the deadline check should be done before the user check. opw-4128638 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179270
Original PR description
in appraisal, the method `_check_validity` is overriden to make different checks in case of `answer_wrong_user`, to make sure that all the checks are OK before handling `answer_wrong_user` case the deadline check should be done before the user check. opw-4128638 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179270
[REV] l10n_pl: Credit note can be more than the invoice total amount This is a revert for PR https://github.com/odoo/odoo/pull/168252 Reason: The law allow the credit note to be more than the invoice total amount according to the user input task-3965527 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181854
Original PR description
[REV] l10n_pl: Credit note can be more than the invoice total amount This is a revert for PR https://github.com/odoo/odoo/pull/168252 Reason: The law allow the credit note to be more than the invoice total amount according to the user input task-3965527 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181854
Load taxes in an end script when all modules are loaded ``` Traceback (most recent call last): File "/home/odoo/src/odoo/17.0/odoo/service/server.py", line 1313, in preload_registries registry = Registry.new(dbname, update_module=update_module) File "<decorator-gen-16>", line 2, in new File "/home/odoo/src/odoo/17.0/odoo/tools/func.py", line 87, in locked return func(inst, *args, **kwargs) File "/home/odoo/src/odoo/17.0/odoo/modules/registry.py", line 114, in new o
Original PR description
Load taxes in an end script when all modules are loaded ``` Traceback (most recent call last): File "/home/odoo/src/odoo/17.0/odoo/service/server.py", line 1313, in preload_registries registry =…
Load taxes in an end script when all modules are loaded
```
Traceback (most recent call last):
File "/home/odoo/src/odoo/17.0/odoo/service/server.py", line 1313, in preload_registries
registry = Registry.new(dbname, update_module=update_module)
File "<decorator-gen-16>", line 2, in new
File "/home/odoo/src/odoo/17.0/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/home/odoo/src/odoo/17.0/odoo/modules/registry.py", line 114, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 476, in load_modules
processed_modules += load_marked_modules(env, graph,
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 364, in load_marked_modules
loaded, processed = load_module_graph(
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 232, in load_module_graph
migrations.migrate_module(package, 'post')
File "/home/odoo/src/odoo/17.0/odoo/modules/migration.py", line 240, in migrate_module
migrate(self.cr, installed_version)
File "/home/odoo/src/odoo/17.0/addons/l10n_uk/migrations/1.1/post-migrate.py", line 7, in migrate
env['account.chart.template'].try_loading('uk', company)
File "/home/odoo/src/odoo/17.0/addons/account/models/chart_template.py", line 153, in try_loading
return self._load(template_code, company, install_demo)
File "/home/odoo/src/odoo/17.0/addons/account/models/chart_template.py", line 212, in _load
self._post_load_data(template_code, company, template_data)
File "/home/odoo/src/odoo/17.0/addons/l10n_uk/models/template_uk.py", line 38, in _post_load_data
result = super()._post_load_data(template_code, company, template_data)
File "/home/odoo/src/enterprise/17.0/account_reports/models/chart_template.py", line 31, in _post_load_data
company._get_and_update_tax_closing_moves(fields.Date.today(), include_domestic=True)
File "/home/odoo/src/enterprise/17.0/account_reports/models/res_company.py", line 163, in _get_and_update_tax_closing_moves
report, tax_closing_options = tax_closing_move._get_report_options_from_tax_closing_entry()
File "/home/odoo/src/enterprise/17.0/account_reports/models/account_move.py", line 264, in _get_report_options_from_tax_closing_entry
report_options = tax_report.with_context(allowed_company_ids=company_ids).get_options(previous_options=options)
File "/home/odoo/src/enterprise/17.0/account_reports/models/account_report.py", line 1670, in get_options
initializer(options, previous_options=previous_options)
File "/home/odoo/src/enterprise/17.0/account_reports/models/account_report.py", line 1619, in _init_options_custom
self.env[custom_handler_model]._custom_options_initializer(self, options, previous_options)
File "/home/odoo/src/odoo/17.0/odoo/api.py", line 534, in __getitem__
return self.registry[model_name](self, (), ())
File "/home/odoo/src/odoo/17.0/odoo/modules/registry.py", line 213, in __getitem__
return self.models[model_name]
KeyError: 'l10n_uk.tax.report.handler'
```
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#181154Adding pages to a notebook is required in a few l10n, so providing it by default will help avoid issues when adding pages. An empty notebook does not show, so it should be fine to have it there. Task id # 3639230 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179258
Original PR description
Adding pages to a notebook is required in a few l10n, so providing it by default will help avoid issues when adding pages. An empty notebook does not show, so it should be fine to have it there. Task id # 3639230 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#179258
### Steps to reproduce 1. Install `l10n_se`. 2. Switch to a Swedish company. 3. Create and confirm a vendor bill with a price of 200, applying the preconfigured 25% purchase tax. 4. Create and confirm a customer invoice with a price of 200, applying the preconfigured 25% sales tax. 5. Open the tax report. ### Expected behavior - Fält 48 (Input VAT) = 50 - Fält 49 (Output VAT - Input VAT) = 50 - 50 = 0 ### Issue - Input VAT is incorrectly negated, resulting in Fält 48 = -50.
Original PR description
### Steps to reproduce 1. Install `l10n_se`. 2. Switch to a Swedish company. 3. Create and confirm a vendor bill with a price of 200, applying the preconfigured 25% purchase tax. 4. Create and confirm a customer invoice with a price of 200, applying the preconfigured 25% sales tax. 5. Open the tax report. ### Expected behavior - Fält 48 (Input VAT) = 50 - Fält 49 (Output VAT - Input VAT) = 50 - 50 = 0 ### Issue - Input VAT is incorrectly negated, resulting in Fält 48 = -50. - Consequently, Fält 49 is incorrectly calculated as 50 - (-50) = 100. - Additionally, the total for Block G does not match the value in Fält 49. opw-4008171 Enterprise PR: odoo/enterprise#70844 Forward-Port-Of: odoo/odoo#181859 Forward-Port-Of: odoo/odoo#181747
When asking for website text replacements to IAP, a timeout of 20 seconds was set. Meaning that after 20 seconds, the user waited for no reason as texts won't be replaced for him (but will be for the next user, using the cache, if still valid). This commit increases that 20 seconds value to 45 seconds. While testing, this 20 seconds timeout is really annoying and from a functional point of view, waiting an extra 25 seconds (at worst) for a much greater chance of having text replacements seems
Original PR description
When asking for website text replacements to IAP, a timeout of 20 seconds was set. Meaning that after 20 seconds, the user waited for no reason as texts won't be replaced for him (but will be for the next user, using the cache, if still valid). This commit increases that 20 seconds value to 45 seconds. While testing, this 20 seconds timeout is really annoying and from a functional point of view, waiting an extra 25 seconds (at worst) for a much greater chance of having text replacements seems acceptable. This will be even more true with the 18.0 new waiting screen which is nicer. Also, it might just be needed to increase that timeout as we may increase the overall delay a bit in future updates to have better quality text replacements. Forward-Port-Of: odoo/odoo#181901
The Modelo 303 has been updated according to [Orden HAC/819/2024] of July 30, 2024. Changes starting from periods 09 and 3T 2024: --------------------------------------------- * Box 108 was added to allow for manually entering those rectifications for which there is no specific box in the form. * Box 111 was added to differentiate refund requests that arise from the application of tax regulations from those that may correspond to a request for undue income. * 3 boolean fields were added i
Original PR description
The Modelo 303 has been updated according to [Orden HAC/819/2024] of July 30, 2024. Changes starting from periods 09 and 3T 2024: --------------------------------------------- * Box 108 was added to…
The Modelo 303 has been updated according to [Orden HAC/819/2024] of July 30, 2024. Changes starting from periods 09 and 3T 2024: --------------------------------------------- * Box 108 was added to allow for manually entering those rectifications for which there is no specific box in the form. * Box 111 was added to differentiate refund requests that arise from the application of tax regulations from those that may correspond to a request for undue income. * 3 boolean fields were added in case we are submitting a rectification to indicate that: - we want to cancel/modify the direct debit made before; - the rectification is due to a discrepancy with administrative criteria; - the rectification is due to another reason. Changes starting from periods 10 and 4T 2024: --------------------------------------------- * Boxes 153, 154 and 155 were changed to reflect the updated VAT rate of 7.5%. * Boxes 16, 17 and 18 were changed to reflect the updated Rec. Eq. rate of 1%. * Boxes 165 to 170 were added to report the new VAT rate of 2% and the new Rec. Eq. rate of 0.26%. * Box 27 was updated to take into account the new boxes 167 and 170 in its computation. (See also [Real Decreto-ley 4/2024]) The BOE file export was updated accordingly. > [!IMPORTANT] > In order to use this, you need to update both the `l10n_es`, `l10n_es_reports` modules and install the new `l10n_es_reports_2024` module. [Orden HAC/819/2024]: https://www.boe.es/eli/es/o/2024/07/30/hac819 [Real Decreto-ley 4/2024]: https://www.boe.es/buscar/act.php?id=BOE-A-2024-12944 [task-4147046](https://www.odoo.com/odoo/all-tasks/4147046) Related to https://github.com/odoo/odoo/pull/179797 Forward-Port-Of: odoo/enterprise#70858 Forward-Port-Of: odoo/enterprise#69736
Issue 1: ======== To reproduce: ------------- - on an appraisal request -> ask for feedback -> set a deadline - the employee can answer after the deadline Problem: -------- the method `_check_validity` was overriden in `hr_appraisal_survey` module to do different checks than the original method in `survey` module in case of `validity_code = answer_wrong_user`, but this override bypasses the other checks in the original method like the deadline check. Solution: --------- call
Original PR description
Issue 1: ======== To reproduce: ------------- - on an appraisal request -> ask for feedback -> set a deadline - the employee can answer after the deadline Problem: -------- the method…
Issue 1: ======== To reproduce: ------------- - on an appraisal request -> ask for feedback -> set a deadline - the employee can answer after the deadline Problem: -------- the method `_check_validity` was overriden in `hr_appraisal_survey` module to do different checks than the original method in `survey` module in case of `validity_code = answer_wrong_user`, but this override bypasses the other checks in the original method like the deadline check. Solution: --------- call the original method `_check_validity` in the override, to make sure all the checks are done, then if the original method returns `validity_code = answer_wrong_user` we can do our specific checks. Issue 2: ======== To reproduce: ------------- - on an appraisal request -> ask for feedback -> set a deadline - manager can't see the answers after the deadline Problem: -------- - to display answer in appraisal module we rely on the url of the survey that contains the tokens for suervey/answer - the deadline handling is done in the survey module where the url is dead after the deadline which is not suitable for the appraisal module Solution: --------- - override the method `_get_access_data` and bypass the deadline check in case of appraisal feedback for manager. opw-4128638 Forward-Port-Of: odoo/enterprise#69502
Implement support for the generation of EFT files following the requirement of the most popular banks in New Zealand Task id # 3639230 Forward-Port-Of: odoo/enterprise#69494
Original PR description
Implement support for the generation of EFT files following the requirement of the most popular banks in New Zealand Task id # 3639230 Forward-Port-Of: odoo/enterprise#69494
Community PR: odoo/odoo#181747 Forward-Port-Of: odoo/enterprise#70905 Forward-Port-Of: odoo/enterprise#70844
Original PR description
Community PR: odoo/odoo#181747 Forward-Port-Of: odoo/enterprise#70905 Forward-Port-Of: odoo/enterprise#70844