Saturday, September 28, 2024
24 changes
Resolved issues and error corrections
This update fixes an issue that could prevent the add-to-cart notification from displaying correctly on the website shop. Customers should now get smoother feedback when adding products to their cart, reducing confusion during checkout preparation.
Original PR description
Owl doesn't accept `null` values for optional props, so we should omit the prop instead of providing a `null` value.
This fixes an issue where the website editor button for loading product categories into mega menus did not correctly trigger category fetching. Website managers can now reliably populate shop navigation menus with categories, improving setup consistency for online stores.
Original PR description
With previous commit f354cb8794c9fd2b5183e520ce292adbe547ba4c, a new feature was introduced to be able to load categories to your mega menu however there was a bug that the button was not synced to fetching the categories Backport of https://github.com/odoo/odoo/pull/181075 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes an issue in the website shop where information used by the page was not available in the right place. It helps ensure shopping pages render reliably and prevents minor display or checkout-related disruptions for customers.
Original PR description
A variable was initialized in a subtemplate but read both in the subtemplate and outside of it. It needs to be declared outside of the subtemplate in order to be readable there.
Discount lines in sales loyalty flows no longer show an extra “Discount:” label when no taxes apply. This avoids redundant wording because the product name already identifies the discount, making sales order descriptions clearer for users.
Original PR description
Issue: - When applying a discount without taxes, a 'Discount:' label is shown in the description field, even though the product name already indicates the discount. Fix: - The 'Discount:' description is now suppressed when there are no taxes applied. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an error in automated warehouse wave processing caused by grouping items using a field that was not available in that process. It helps ensure picking batches can be created reliably without failing on invalid product category references.
Original PR description
auto_wave do a reference to `product_categ_id`. It only exists on `stock.quant` and not `stock.move.line`. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a task from the website form no longer fails when optional company or phone details are left blank. This prevents users from seeing an error page and helps ensure submitted requests are captured reliably.
Original PR description
Currently, when a user creates a task through the webform without providing a company or phone, a traceback occurs.
Technical details:
- The issue arises when trying to access a key that doesn't exist in a dictionary.
- Example: `test = {'a': 1}`, accessing `test['b']` results in a KeyError.
Solution:
- Replaced direct dictionary access with the `get` method to handle missing keys gracefully.
task-4207886Kanban cards now show their configured color indicator even when the color field is not explicitly included in the view setup. This restores expected visual cues in Planning and helps users quickly distinguish cards by status or category.
Original PR description
Kanban cards can be colored (their left border) dynamically by using the root attribute `highlight_color="color"`, where `color` is the name of the integer field to use as color field. However, before this commit, this required the given `color` to be also defined in the arch, otherwise it wouldn't have been fetched, and no card would be colored. With this commit, we automatically fetch the highlight_color field. This fixes a bug in planning where colors weren't displayed. Task~4215979 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Product pages no longer fail when the specifications section is empty. This prevents a broken interaction on ecommerce product pages and keeps the shopping experience stable.
Original PR description
Issue: when the product specifications are empty, the `#product_accordion` exists without an `.accordion-item` which fails the `._updateAccordionActiveItem` function. follow-up of task-3987039 task-4215477 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes broken navigation arrows in website image gallery slideshows used inside page templates. Visitors can once again move through gallery images as expected, restoring the intended browsing experience.
Original PR description
Since the redesign of `s_image_gallery` in commit 9042b1cae7b630b20e0670788b7a4ed9e4c97609, the arrow anchors has been changed and no longer work in slideshows that are in page templates. To fix this issue, this commit reintroduces the previous ID. task-4215411 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes the point-of-sale restaurant tip screen test reliable when orders appear in a different order. It reduces false test failures, helping maintain confidence in the checkout and tipping flow without changing customer-facing behavior.
Original PR description
Fix tests checks, the test 05_tip_screen_tour.js was failing because the order of orders can vary, so we need to change the check to prevent error related to the order of the orders. rb error: 99346
The chatter search panel no longer shows a duplicate search icon above the search bar. This cleans up the interface and avoids confusion when users search messages in chatter.
Original PR description
**Current behavior before PR:** On clicking the search button on chatter. Extra search icon appears above the search bar **Desired behavior after PR is merged:** now after clicking search button on chatter extra icon is removed. task-4206791 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The point of sale employee sales report no longer shows duplicate sales entries in session reports, making totals clearer and more reliable. The employee sales details report was also renamed for easier identification.
Original PR description
before this commit: ============== - session sales report was displaying duplicate values. after this commit: ============== - removed duplicate entries from print session sales report - renamed the employee sales details report. task - 4143903
The debug menu item for viewing raw record data now behaves as it did before, while keeping its updated name. This avoids exposing the option in places like list or kanban views where it was not intended, reducing confusion for users and support teams.
Original PR description
In the PR [1], the behavior of the "View Raw Record Data" debug item changed. It opened the /json route of the current view and it was also available in multi record views (list, kanban, etc.). This commit reverts this behavior change but keeps the renaming. task-4055746 [1]: https://github.com/odoo/odoo/pull/180141
The checkout address page no longer shows a sign-in prompt when sign-in or sign-up at checkout has been disabled. This keeps the checkout experience aligned with the store’s configured customer account policy and avoids confusing shoppers.
Original PR description
Issue: - When 'disabled' option is selected for Sign in/up at checkout, sign-in prompt is still showing on address page. Fix: - Updated the t-if condition to ensure that the sign-in prompt is no longer displayed when the 'disabled' option is selected. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Livechat visitors will no longer see their own country flag displayed in the conversation header after sending a message. The flag is now limited to the operator side, reducing unnecessary exposure of visitor location details and keeping the customer-facing chat interface cleaner.
Original PR description
Before this commit, when a visitor posts a message in livechat, the header was showing their country flag. Steps to reproduce: - log in as Mitchell Admin as available operator - log in as Joel Willis (portal user, on another browser context) - open a livechat as Joel and send a message => Country of joel "USA" is visible in header This happens because it was always showing `anonymous_country` when available, which is the visitor country. This commit fixes the issue by limiting the showing of the country flag to the operator of livechat conversation. Before / After  
Portal users can now fold categories in the Discuss sidebar without causing a crash. This keeps the public page experience stable by avoiding an action that only internal users are allowed to save.
Original PR description
The discuss sidebar was recently added to the public page. The state of the sidebar (folded categories) is saved for internal users. Guests and portal users do not have the rights to do this. However, it was only disabled for guests. As a result, folding a category as a portal user would lead to a crash. This PR fixes this issue.
SEPA credit transfer files no longer include duplicate issuer or LEI identifier entries. This helps prevent payment file validation issues and reduces the risk of bank rejections caused by repeated information.
Original PR description
Issr and LEI nodes were added twice, because they were handled both in the generic ISO20022 code and the SEPA Credit Transfer override.
The trial balance report now opens correctly when horizontal groups are configured. This prevents users from hitting an error screen and keeps financial reporting accessible in affected setups.
Original PR description
Steps to reproduce - Create a horizontal group - open the trial balance -> Traceback Cause of the issue: a None value is set in the 'no_format' key of a line of the report.
This fix ensures document access updates run correctly when performed with elevated system rights. It prevents permission checks from incorrectly blocking internal access updates, improving reliability for document sharing and membership changes.
Original PR description
Purpose ======= Skip user permission check, when calling `_action_update_access` in SUDO, like it has been done for `_action_update_members`
Portal users can now preview documents without the Documents portal crashing. This fix improves reliability for external users accessing shared documents.
Original PR description
The commit prevents the Documents portal from crashing when portal users try to preview a document. We prevent the client from raising an error when trying to access an undefined available embedded actions records (not available for portal users.) task-3373836
Subscription sales orders now show only one Create Invoice button after confirmation. This reduces confusion for users and helps keep the invoicing workflow clear and consistent.
Original PR description
Version: - 18.0 Steps to reproduce: - create a subscription sale order - confirm the sale order Issue: - two create invoice button are visible Cause: - The conditions for showing the two "Create Invoice" buttons overlapped, making both appear at the same time Solution: - Adjusted button conditions to ensure only one "Create Invoice" button is displayed when no invoice is created
This fixes an error that could occur when validating multiple payment batches at once. SEPA direct debit batches are now checked correctly, helping prevent failed payment processing workflows.
Original PR description
_check_minimal_collection_date is written in a way where it will break if multiple batches are in self. We fix this by changing the way we check if the constrains should run: we will check the batches in self and only run it if any batch is a sepa batch; and only run it with these.
Reloading an open spreadsheet in Documents no longer sends users back to the main Documents view. This keeps users in the spreadsheet they were working on and avoids workflow interruption.
Original PR description
Steps to reproduce: - open a spreadsheet - reload the page => you're redirected to the main Documents kanban view The url of a spreadsheet looks like `http://localhost:8069/odoo/documents/spreadsheet/26` The code here thinks `spreadsheet/26` is a document access_token
Saving a new favourite view from the Project control panel no longer triggers an error. This helps users save their preferred task views reliably without interruption.
Original PR description
…in the control panel When saving a new favourire view from the control panel a traceback would appear. It was because the domain was not parsed correctly in search_model.js when calling the getDomain method from the _getIrFilterDescription method. It was not parsed correctly because 2 parameters given to the method were lost because the getDomain method was overwritten in HighlightProjectTaskSearchModel. After passing the parameters to the super call inside the overwritten getDomain method, the traceback is fixed. task-4207512