Monday, September 30, 2024
9 changes · 17.0
Resolved issues and error corrections
This fixes an error that could occur when a service product linked to project creation was changed to a consumable while a sales order page was still open. Users can now avoid a crash from the Project button after the product type changes, improving stability in sales order workflows.
Original PR description
Steps to reproduce:
1. Install the `sale_project` module.
2. Create a product with the following properties:
- Type: 'Service'
- Create on Order: 'Project & Task'
4. Create a sale order and add the product to it.
5. Confirm the sale order.
6. In another tab, change the product type to 'Consumable' in the product form (a popup will appear informing you that you cannot change the type, but it can be dismissed.)
The issue arises because the 'Project' smart button remains visible in the sale order tab until the page is reloaded, and there are no longer any order lines with a product of type 'Service', resulting in a StopIteration error.
Closes #180340This fixes an issue where employee leave balance fields could fail to display because the system returned the data in the wrong format. HR users can now add and view remaining leave information on employee records without triggering this error.
Original PR description
The method `_get_remaining_leaves` is supposed to return a dict object not a set of tuples, as it is used in [`_compute_remaining_leaves`](https://github.com/odoo/odoo/blob/913c081a8687d0f2aa6c40faeee9013fa10865db/addons/hr_holidays/models/hr_employee_base.py#L84) How to reproduce: 1- Install module hr_holidays 2- Add any of the fields [`remaining_leaves`, `leaves_count`] to an employee view --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Server actions can now send email messages for any type of business record when the selected email template supports it. This fixes an overly strict validation that blocked valid email automation setups, while keeping safeguards for unsupported follower-related actions.
Original PR description
odoo/odoo#114352 add some logic validation to avoid nonsensical configurations that attempt to e.g. add a follower to a model who does not inherit mail.thread This restriction is a tad too extreme in the case of the 'Send message' action - sending an email is supported on any kind of model as long as the email template supports it. Task-4203142
The survey results page no longer shows a misleading test-entry warning after a test survey has been completed and the user is viewing results. This avoids confusion for users reviewing survey responses and keeps the displayed status accurate.
Original PR description
Steps to reproduce: - Survey > New > Tick 'Survey' - Create a question - Test > Complete the survey - Edit survey > See results The banner displays 'This is a test survey entry', despite no longer being in the test. The condition to display this text was removed in c983f8a5343ac623ebc9d6dbddc506db4079ee5e but it is still relevant here. opw-4160109 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an edge case where users could trigger an error by opening a project link from an outdated sales order page after the related product type was changed. Instead of showing an unhandled exception, the sales order now handles the missing project-generating service product more safely, improving reliability in an unusual but possible workflow.
Original PR description
Steps to reproduce: - Create a service product with 'Create on Order' set to 'Project' - Duplicate your browser tab (Right click the tab) - (New tab)Sales > Quotations > New > Add your product >…
Steps to reproduce: - Create a service product with 'Create on Order' set to 'Project' - Duplicate your browser tab (Right click the tab) - (New tab)Sales > Quotations > New > Add your product > Confirm - (Old tab) Edit your product to be a consumable - (Old tab) A warning will pop up but it can be dismissed > Save - (New tab) Try to access the project with the link button Despite the warning claiming "You cannot change the product's type because it is already used in sales orders.", the product template's type can be changed at will. This causes issues when accessing the project view because we iterate under the assumption that a service product will be found (Only services can generate projects). The project button disappears after reloading the page but if someone did click it raises an unhandled exception, which is not great even if the user really has to go out of their way to get it. opw-4189248 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Point of Sale checkout now correctly keeps tip amounts separate from taxable sales amounts. This prevents customers from being overcharged and keeps receipts and accounting totals accurate.
Original PR description
During tests a tax was applied on the tip amount, which is not correct. RB err: 76192, 76191
Shift assignment emails now keep the intended author instead of automatically using the sender address chosen by the email template. This helps ensure employees see the correct source for planning notifications and supports more reliable communication.
Original PR description
Purpose ======= Now the send_mail method of mail.template automatically chose the author based on the email from, so we force the author when assigning a shift. Adapt the queries count tests. Task-3815627
A test tour for adding documents to dashboard groups was not running because the Python test method was missing the required 'test_' prefix. The tour has been fixed to work with the new functionality that allows creating dashboards from new spreadsheets. This ensures the feature is properly tested.
Original PR description
The tour `spreadsheet_dashboard_document_add_document_to_dashboard_group` was never actually run because the python method wasn't prefixed by `test_`. The toru was also broken since we allowed to create a dashboard based on a new spreadsheet. Task: [4199036](https://www.odoo.com/web#id=4199036&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)
This update fixes a visual formatting problem in the Sign module where placeholder text was overlapping with navigation controls when fields were left-aligned in templates. The issue was caused by excessive padding removal that was added in a previous update. This fix restores proper spacing while maintaining the intended visual consistency across the application.
Original PR description
Steps to reproduce: - Sign > Edit any template > Add a field - Click your field > Select left alignment > Validate The placeholder text overlaps with the arrow block, in 16.0 this does not occur. The culprit is the ps-0 class added to signItem which removes all padding from the block. The formatting was changed in f1b35ae9030ff82afc498bfbd6315414407bb4e1 to make it consistent between the other views (The shift is kept even the move icon is not visible) but the alignment feels consistent even without this class. opw-4159676