Friday, October 4, 2024
3 changes · 17.0
Miscellaneous changes
**Steps to reproduce:** - Install account_accountant. - Create a journal with a type other than miscellaneous. - For the created journal, select a default account - Now change the journal type to Miscellaneous. **Issue :** - When changing the journal type to Miscellaneous from any other type, the default_account_id remains unchanged in the database. Functionally, the default_account_id should be removed for Miscellaneous journals, as this field isn't visible in the front-end, so custome
Original PR description
**Steps to reproduce:** - Install account_accountant. - Create a journal with a type other than miscellaneous. - For the created journal, select a default account - Now change the journal type to…
**Steps to reproduce:** - Install account_accountant. - Create a journal with a type other than miscellaneous. - For the created journal, select a default account - Now change the journal type to Miscellaneous. **Issue :** - When changing the journal type to Miscellaneous from any other type, the default_account_id remains unchanged in the database. Functionally, the default_account_id should be removed for Miscellaneous journals, as this field isn't visible in the front-end, so customers aren't aware if it still contains data. - I have faced one issue where customer changed journal type to miscellaneous and after upgrade he faced some issue related to cash flow statement which is accuring because there is default_account_id set for it. - Before fix : https://drive.google.com/file/d/1OL19m14RIz44gAtsZyu866OjRv4xGOoO/view?usp=sharing - After fix : https://drive.google.com/file/d/1u89YTUIrRGvZgI-5afG26sR00fcbHWT2/view?usp=sharing opw-4072696 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181516 Forward-Port-Of: odoo/odoo#178494
Before these changes, the total price of the invoices was displayed in the kanban view without considering whether it was an outgoing or incoming payment. This can cause confusion for the user when charging customers.  After these changes, the total is displayed with the symbol so that users can easily differentiate the type of invoice, just as it is done in the tree views.  After these changes, the total is displayed with the symbol so that users can easily differentiate the type of invoice, just as it is done in the tree views.  cc @Tecnativa TT50987 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181424
In case an extra dependency is added to the api.depends decorator of account.move._compute_journal_id, account.payment.partner_bank_id is going to be recomputed, potentially overwriting existing value. Steps to reproduce: 1. Install a module adding a dependency to account.move._compute_journal_id 2. Create a vendor bill with a partner having more than one bank account 3. Register payment using another bank account than the first one The created payment would then have its bank account r
Original PR description
In case an extra dependency is added to the api.depends decorator of account.move._compute_journal_id, account.payment.partner_bank_id is going to be recomputed, potentially overwriting existing value. Steps to reproduce: 1. Install a module adding a dependency to account.move._compute_journal_id 2. Create a vendor bill with a partner having more than one bank account 3. Register payment using another bank account than the first one The created payment would then have its bank account recomputed. By testing for an existing value in the compute function before assigning the first bank account of the partner, we ensure any manually defined value will not be overwritten through unwanted recomputation. For context: https://github.com/OCA/sale-workflow/pull/3321 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181278