Tuesday, October 8, 2024
27 changes · saas-17.2
Resolved issues and error corrections
Reloading an import records page now keeps the selected business object, so users are returned to the correct import screen instead of seeing an error or being redirected. This makes record imports more reliable when users refresh the browser or change interface settings during the process.
Original PR description
- In any APP (We would use CRM for the example); - On a multi-record view (Kanban, List, or other); - Click the action menu; - Click on “Import records” dropdown; - Reload the view (either reload the browser, or activate the debug, or change to dark mode on the user menu). Before this commit, an exception was raised, and the default multi-record view was loaded. This occurs because, the client action base import required a model (found in the context) that was lost when reloading. Now, the model is put in the query string of the URL (as active_model), in that way, when reloading, the client action base import will have the needed model. Note that, this is also the behavior of the stock TraceabilityReport client action [1]. opw-3959254 [1] : https://github.com/odoo/odoo/commit/8b3deab679bfee844ccd84c7f4f6f831921365d3
Reloading an import screen now keeps users on the same import page instead of briefly showing an error and sending them back to the list or kanban view. This preserves the user's workflow and prevents confusion during record imports.
Original PR description
- Go to CRM app - Click on the action menu --> Import records --> Import screen will appear - Reload the page a traceback will occur which will disappear quickly (you can see it in console) - It redirects you back to the kanban view which is not correct Before this commit, on reloading the import screen page a traceback was occuring which redirects back to the kanban/list view. This occurs because the ImportAction lost the current model at reload (resModel). Now, the ImportAction will update the state of action using updateActionState prop, to add the resModel to the url (as a query param), and be able to restore the full state at reload. Task-3959254 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Pivot table header menus now close again after choosing a grouping option. This prevents users from adding multiple groupings from a stale menu state, which could lead to incorrect pivot table results.
Original PR description
Before https://github.com/odoo/odoo/pull/137691, select a groupby in the dropdown of a pivot header would close the dropdown. Now the dropdown stays open and it is possible to add several row/col groupbys at the same time but the pivot model is not updated correctly because the update of the model is based on the groupId of the header for which the dropdown was opened. The simpler/best solution to that problem is to restore the previous behavior. Task ID: 3985217
Miscellaneous changes
If an Amazon order has more than one item it was creating for each item an own shipping line even if it had not even a shipping price defined per item line. Info: @wt-io-it Forward-Port-Of: odoo/enterprise#70940
Original PR description
If an Amazon order has more than one item it was creating for each item an own shipping line even if it had not even a shipping price defined per item line. Info: @wt-io-it Forward-Port-Of: odoo/enterprise#70940
This commit adds a QR code (barcode) to the meixo delivery guide PDF (cartaporte). It is a legal requirement according to the filling guide point 4, but other than that, it is the one thing cops will scan to check if the document is real or not. The QR code is generated by taking the idccp, Salida, and LLegada data and insert them as a parameter to an URL pointing to the mexican service to display the data of the published version of the document. task-id: 4142920 Forward-Port-Of:
Original PR description
This commit adds a QR code (barcode) to the meixo delivery guide PDF (cartaporte). It is a legal requirement according to the filling guide point 4, but other than that, it is the one thing cops will scan to check if the document is real or not. The QR code is generated by taking the idccp, Salida, and LLegada data and insert them as a parameter to an URL pointing to the mexican service to display the data of the published version of the document. task-id: 4142920 Forward-Port-Of: odoo/enterprise#71218 Forward-Port-Of: odoo/enterprise#69581
The vendor dropdown does not close when a extract box is clicked and a creation dialog opens. It would only close after the first click. In this commit the dropdown is closed straight away. Forward-Port-Of: odoo/enterprise#71039
Original PR description
The vendor dropdown does not close when a extract box is clicked and a creation dialog opens. It would only close after the first click. In this commit the dropdown is closed straight away. Forward-Port-Of: odoo/enterprise#71039
Previous behavior: - Late bills were determined by comparing `supprd` with the `return period`, which led to inaccuracies. New behavior: - Late bills are now identified by checking if the `bill date` is earlier than the `return period start date`, ensuring more precise classification of late bills. OPW: 4210068 Forward-Port-Of: odoo/enterprise#71364 Forward-Port-Of: odoo/enterprise#70225
Original PR description
Previous behavior: - Late bills were determined by comparing `supprd` with the `return period`, which led to inaccuracies. New behavior: - Late bills are now identified by checking if the `bill date` is earlier than the `return period start date`, ensuring more precise classification of late bills. OPW: 4210068 Forward-Port-Of: odoo/enterprise#71364 Forward-Port-Of: odoo/enterprise#70225
As the Fixed Establishment is no more an obligation for the government, we remove this information from the xml export of the OSS sales report opw-3981681 Forward-Port-Of: odoo/enterprise#71130 Forward-Port-Of: odoo/enterprise#66876
Original PR description
As the Fixed Establishment is no more an obligation for the government, we remove this information from the xml export of the OSS sales report opw-3981681 Forward-Port-Of: odoo/enterprise#71130 Forward-Port-Of: odoo/enterprise#66876
Before this commit, the changes made in community to call `get_create_edit_project_ids` method to know which projects we only allow to quick create a task on `task_id` field in `account.analytic.line` model (timesheets model) introduced a performance issue in the list view because the `TaskWithHours` component doing the rpc call inside `onWillStart` hook is mounted on each row displayed on the list view, this is, the number of rpc call to that method will be the number of the records displayed i
Original PR description
Before this commit, the changes made in community to call `get_create_edit_project_ids` method to know which projects we only allow to quick create a task on `task_id` field in…
Before this commit, the changes made in community to call `get_create_edit_project_ids` method to know which projects we only allow to quick create a task on `task_id` field in `account.analytic.line` model (timesheets model) introduced a performance issue in the list view because the `TaskWithHours` component doing the rpc call inside `onWillStart` hook is mounted on each row displayed on the list view, this is, the number of rpc call to that method will be the number of the records displayed in the list view instead of calling that rpc once. This commit moves that behavior in industry_fsm module since `get_create_edit_project_ids` method will only return fsm projects when the industry_fsm module is installed. Without that module, no project ids will be returned and so it is not really needed to do a rpc call for nothing. This commit also improves the changes to make sure the rpc call is made only once in the list view. Note: that behavior is not managed in the list view of All Timesheets since it would need to add a custom js class. It will be done in 18.0. task-4221621 Forward-Port-Of: odoo/enterprise#71183
When automatic entries are generated, a sequence number should not be assigned on them as long as they are on draft state. This is done because it may be confusing to see a sequence name for a move in draft. This commit ensures that the name of the entries is 'Draft' (or '/') when the move is generated. A sequence number will be assigned once the move is posted. Before this commit, it was possible to generate a draft move with a sequence number when doing a deferred entries with some entries in
Original PR description
When automatic entries are generated, a sequence number should not be assigned on them as long as they are on draft state. This is done because it may be confusing to see a sequence name for a move in draft. This commit ensures that the name of the entries is 'Draft' (or '/') when the move is generated. A sequence number will be assigned once the move is posted. Before this commit, it was possible to generate a draft move with a sequence number when doing a deferred entries with some entries in the future. task-4069862 Forward-Port-Of: odoo/enterprise#70855
Steps to reproduce: - On a fresh DB install only project_hr_expense(Uninstall project_sale_expense). - Create a expense on a project. - Go to Project Updates/ Dashboard - i.e., project right side panel Issue: - You can see that there is no action click on Expense while there should be. Reason: - Incorrect configuration of attaching ids into the action causing this. Solution: - Fixed the incorrect in which action is being generated. Technical: - The issue only occurs w
Original PR description
Steps to reproduce:
- On a fresh DB install only project_hr_expense(Uninstall project_sale_expense).
- Create a expense on a project.
- Go to Project Updates/ Dashboard - i.e., project right side panel
Issue:
- You can see that there is no action click on Expense while there should be.
Reason:
- Incorrect configuration of attaching ids into the action causing this.
Solution:
- Fixed the incorrect in which action is being generated.
Technical:
- The issue only occurs when the project_hr_expense module is installed. If the project_sale_expense module is installed,
the issue does not reproduce because the expense action is handled properly.
task-4175573
Forward-Port-Of: odoo/odoo#182431
Forward-Port-Of: odoo/odoo#179717Currently, a traceback is occurring when the user tries to export a translation without selecting the model when the export type is `model` To reproduce this issue: 1) Try to export a translation without a model with the export type as `model` Error:- ``` KeyError: False ``` We can see that the model is not required when exporting a translation when the export type is `model`. This leads to a Keyerror from the below line https://github.com/odoo/odoo/blob/ce786882fe8527864
Original PR description
Currently, a traceback is occurring when the user tries to export a translation without selecting the model when the export type is `model` To reproduce this issue: 1) Try to export a translation without a model with the export type as `model` Error:- ``` KeyError: False ``` We can see that the model is not required when exporting a translation when the export type is `model`. This leads to a Keyerror from the below line https://github.com/odoo/odoo/blob/ce786882fe852786441ab86d9311aecc143cf57d/odoo/addons/base/wizard/base_export_language.py#L43-L44 Making the model as required in a stable version if the export type is `model` in XML is not stable friendly. So raising a `Usererror` will resolve this issue in stable. Note:- Will make the model as required if the export_type is `model` in master in xml sentry-5686584762 Forward-Port-Of: odoo/odoo#181114
Issues: The test I created here had an inheritance which was in enterprise, as pointed by gawa https://github.com/odoo/odoo/pull/168930#issuecomment-2340200503 Solution: Correct the test to remove the inheritance. opw-3921156 Forward-Port-Of: odoo/odoo#179761
Original PR description
Issues: The test I created here had an inheritance which was in enterprise, as pointed by gawa https://github.com/odoo/odoo/pull/168930#issuecomment-2340200503 Solution: Correct the test to remove the inheritance. opw-3921156 Forward-Port-Of: odoo/odoo#179761
**This is a back-port of a hotfix done during the OXP. See the original commit message below:** `websocket.WebSocketApp` doesn't set any fingerprint header, like no user-agent or origin, ... It can lead to issues when using a proxy firewall, such as HAProxy, as it could lead to the fingerpint to be 00000000-00000000-00000000-00000000, which can be seen as not legitimate, and the requests to be rejected for that reason. By setting a user-agent, we overcome this limitation --- I conf
Original PR description
**This is a back-port of a hotfix done during the OXP. See the original commit message below:** `websocket.WebSocketApp` doesn't set any fingerprint header, like no user-agent or origin, ... It can lead to issues when using a proxy firewall, such as HAProxy, as it could lead to the fingerpint to be 00000000-00000000-00000000-00000000, which can be seen as not legitimate, and the requests to be rejected for that reason. By setting a user-agent, we overcome this limitation --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182562
Currently the IoT Box accepts maximum the default nginx size of 1MB per request. This can be an issue when sending over heavy files to print. This PR increases the limit to 10MB and backports the PR #157733 in v17.0 as this version will be the base for our new image Forward-Port-Of: odoo/odoo#181202
Original PR description
Currently the IoT Box accepts maximum the default nginx size of 1MB per request. This can be an issue when sending over heavy files to print. This PR increases the limit to 10MB and backports the PR #157733 in v17.0 as this version will be the base for our new image Forward-Port-Of: odoo/odoo#181202
Maybe not the right approach, but to put the issue over the table at least. Users can copy paste their html signatures from whatever source, and that can lead to buggy behaviors when that signatures are used in the editor. For this case, users copy-pasted from outlook their html signature containing nested comments like this ``` <!--<![endif]--> ``` This lead to a buggy behavior of the web_editor whenever those signatures were loaded in the template. For example, in the invoice s
Original PR description
Maybe not the right approach, but to put the issue over the table at least. Users can copy paste their html signatures from whatever source, and that can lead to buggy behaviors when that signatures are used in the editor. For this case, users copy-pasted from outlook their html signature containing nested comments like this ``` <!--<![endif]--> ``` This lead to a buggy behavior of the web_editor whenever those signatures were loaded in the template. For example, in the invoice sending template. In that case, the web_editor will rollback any attemped change in the mail composer when that code is loaded into the composer body editor. The issue is that those nested comments are detected incorrectly. So better simply ignore them as they don't add up any value. cc @Tecnativa TT51068 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182382
When automatic entries are generated, a sequence number should not be assigned on them as long as they are on draft state. This is done because it may be confusing to see a sequenced name for a move in draft. This commit ensures that the name of the entries is 'Draft' (or '/') when the move is generated. A sequence number will be assigned once the move is posted. Before this commit, it was possible to generate a draft move with a sequence number when doing an automatic transfer in the future or
Original PR description
When automatic entries are generated, a sequence number should not be assigned on them as long as they are on draft state. This is done because it may be confusing to see a sequenced name for a move in draft. This commit ensures that the name of the entries is 'Draft' (or '/') when the move is generated. A sequence number will be assigned once the move is posted. Before this commit, it was possible to generate a draft move with a sequence number when doing an automatic transfer in the future or with accrued orders. task-4069862 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181779
Steps to reproduce: 1. Open the course content. 2. Exit the full screen. 3. Try to comment on the content. 4. The Send button on comments not working Technical Reason: In portal_chatter_post, a ValidationError was shown in the terminal: "Only a single review can be posted per course." This occurred because it was checking the 'res_id' in the 'slide.channel' model while being in the 'slide.slide' model. After this Commit: The send button on the comment should work properly on the cont
Original PR description
Steps to reproduce: 1. Open the course content. 2. Exit the full screen. 3. Try to comment on the content. 4. The Send button on comments not working Technical Reason: In portal_chatter_post, a ValidationError was shown in the terminal: "Only a single review can be posted per course." This occurred because it was checking the 'res_id' in the 'slide.channel' model while being in the 'slide.slide' model. After this Commit: The send button on the comment should work properly on the content. Task-4213443 Forward-Port-Of: odoo/odoo#182153
**How to reproduce:** - Go to website, then on events - Open edit mode - Select 'Template Badge' - Select List from dropdown - Open a mobile view **Specifications:** Template badge is overlapped with the event details, change its position for mobile view. Add it above location. **After this PR:** Template Badge's position will be changed in mobile view and will no longer be overlapped by the content. Task-4210363 Forward-Port-Of: odoo/odoo#182323
Original PR description
**How to reproduce:** - Go to website, then on events - Open edit mode - Select 'Template Badge' - Select List from dropdown - Open a mobile view **Specifications:** Template badge is overlapped with the event details, change its position for mobile view. Add it above location. **After this PR:** Template Badge's position will be changed in mobile view and will no longer be overlapped by the content. Task-4210363 Forward-Port-Of: odoo/odoo#182323
Before this commit, due to the commit https://github.com/odoo/odoo/commit/a5e27d8f6fad33f9dcd6121b42d4698009627bfd, when the user goes to list view of timesheets, he could be disconnect due to a many rpc calls made to get the projects for which we only allow to create and edit task (because some fields could be required). This commit moves most of changes made in https://github.com/odoo/odoo/commit/a5e27d8f6fad33f9dcd6121b42d4698009627bfd in enterprise since only with hr_timesheet module
Original PR description
Before this commit, due to the commit https://github.com/odoo/odoo/commit/a5e27d8f6fad33f9dcd6121b42d4698009627bfd, when the user goes to list view of timesheets, he could be disconnect due to a many rpc calls made to get the projects for which we only allow to create and edit task (because some fields could be required). This commit moves most of changes made in https://github.com/odoo/odoo/commit/a5e27d8f6fad33f9dcd6121b42d4698009627bfd in enterprise since only with hr_timesheet module installed, we will never get a project for which we don't want to allow the quick create on task_id field. Impacted versions: 17.0+ task-4221621 Forward-Port-Of: odoo/odoo#182303
Steps to reproduce =================== - Create a survey having MCQ-type questions. - Create a live session. - Copy & paste the link into another browser. - Start giving the answer. - Try to submit the answer which is mandatory in MCQ. - The alert box overlaps the options. This PR addresses the issue and adds the margin between the options and the alert box. Task-4231590 Forward-Port-Of: odoo/odoo#182532
Original PR description
Steps to reproduce =================== - Create a survey having MCQ-type questions. - Create a live session. - Copy & paste the link into another browser. - Start giving the answer. - Try to submit the answer which is mandatory in MCQ. - The alert box overlaps the options. This PR addresses the issue and adds the margin between the options and the alert box. Task-4231590 Forward-Port-Of: odoo/odoo#182532
**Steps to reproduce:** - Install Accounting - Create an invoice with any product - Go to "Journal Items" tab - Input a label for the payment term line (it should be empty) - Confirm the invoice **Issue:** The input label of the payment term line is replaced by the "Payment Reference" of the invoice. For bills, it is replaced by an empty string as there is no default value for the payment reference. **Solution:** Only use the payment reference of the invoice as label for the paymen
Original PR description
**Steps to reproduce:** - Install Accounting - Create an invoice with any product - Go to "Journal Items" tab - Input a label for the payment term line (it should be empty) - Confirm the invoice **Issue:** The input label of the payment term line is replaced by the "Payment Reference" of the invoice. For bills, it is replaced by an empty string as there is no default value for the payment reference. **Solution:** Only use the payment reference of the invoice as label for the payment term line if it has not been modified manually. This can be done by checking that their values in _origin are similar. opw-4173634 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182568 Forward-Port-Of: odoo/odoo#182136
before this PR: In a multi-company environment, the GST E-Invoice (India) option appears for all companies, regardless of the company's country after this PR: on Journal, GST E-Invoice (India) option appears for only Indian companies Forward-Port-Of: odoo/odoo#181153
Original PR description
before this PR: In a multi-company environment, the GST E-Invoice (India) option appears for all companies, regardless of the company's country after this PR: on Journal, GST E-Invoice (India) option appears for only Indian companies Forward-Port-Of: odoo/odoo#181153
a bug was reported that when there were multiple available pricelists, the sequence provided by the admin wasn't taken into consideration. This fix returns the first available pricelist based on the model's order, instead of based on the creation order. > [EBC] pricelist country detection issue with more than 2 pricelists: > https://drive.google.com/file/d/1eHlCqA_2CW2HB_IvGlOscQhXZVi_Owq3/view?usp=sharing --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/sub
Original PR description
a bug was reported that when there were multiple available pricelists, the sequence provided by the admin wasn't taken into consideration. This fix returns the first available pricelist based on the model's order, instead of based on the creation order. > [EBC] pricelist country detection issue with more than 2 pricelists: > https://drive.google.com/file/d/1eHlCqA_2CW2HB_IvGlOscQhXZVi_Owq3/view?usp=sharing --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182100
Steps to reproduce : - Add a second language in your website settings. - Drop a "Text" block in a new page. - Add a highlight to some text > Save. - Switch to the translation mode. - Select the highlighted text > The text highlight options are shown. - Select a text without any option > The highlight options remain displayed. Starting from [1], we allow using text options (text animations & text highlights) in the translation mode, mainly by allowing the creation of snippet editors
Original PR description
Steps to reproduce : - Add a second language in your website settings. - Drop a "Text" block in a new page. - Add a highlight to some text > Save. - Switch to the translation mode. - Select the…
Steps to reproduce : - Add a second language in your website settings. - Drop a "Text" block in a new page. - Add a highlight to some text > Save. - Switch to the translation mode. - Select the highlighted text > The text highlight options are shown. - Select a text without any option > The highlight options remain displayed. Starting from [1], we allow using text options (text animations & text highlights) in the translation mode, mainly by allowing the creation of snippet editors if the target is a text option snippet. Another fix (from [2]) was added later to exceptionally authorize the editor's creation for "invisible" elements in translate mode, with a small adaptation on `_activateSnippet()` to prevent activating invisible snippets when their related sidebar buttons are clicked. This code unintentionally leads to keeping the old editors created for a text snippet when switching to another one in the DOM. To fix this behaviour, we still need to ensure existing editors are destroyed so we only create the ones we need in translate mode. [1]: https://github.com/odoo/odoo/commit/3a149e36f7e6deaf156a7ee35e654aad61cf2e5d [2]: https://github.com/odoo/odoo/commit/67efd1d98072f36caf9c473e97984631eb6bc8a3 task-3975683 Forward-Port-Of: odoo/odoo#174458 Forward-Port-Of: odoo/odoo#168642
**Current behavior before PR:** The pencil icon for editing the channel image was not visible on hover due to a wrongly written condition, preventing users from updating the image in the form view. **Desired behavior after PR is merged:** This PR fixes the issue by ensuring that the pencil icon now appears on hover, allowing users to edit the channel image directly from the form view. Task-4224182 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com
Original PR description
**Current behavior before PR:** The pencil icon for editing the channel image was not visible on hover due to a wrongly written condition, preventing users from updating the image in the form view. **Desired behavior after PR is merged:** This PR fixes the issue by ensuring that the pencil icon now appears on hover, allowing users to edit the channel image directly from the form view. Task-4224182 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182486
When installing an industry from the database, the list of dependencies to install is displayed in the dialog box. This is not clear nor necessary for the user and is therefore removed. Also, a message better alerts the user about loading demo data on a database. task-4096849 Forward-Port-Of: odoo/odoo#180035
Original PR description
When installing an industry from the database, the list of dependencies to install is displayed in the dialog box. This is not clear nor necessary for the user and is therefore removed. Also, a message better alerts the user about loading demo data on a database. task-4096849 Forward-Port-Of: odoo/odoo#180035