Thursday, October 10, 2024
16 changes · 17.0
Resolved issues and error corrections
Website editors can now use theme and grayscale colors for navbar link text as expected. This fixes a styling issue where selected named colors appeared saved but were not applied, while avoiding unexpected visual changes for existing affected sites.
Original PR description
Steps to reproduce the bug: - In Website edit mode. - click on the navbar. - For the "Format" option of the navbar, open the color picker. - Select any colors of the theme colors or any grayscale…
Steps to reproduce the bug: - In Website edit mode. - click on the navbar. - For the "Format" option of the navbar, open the color picker. - Select any colors of the theme colors or any grayscale color. - Bug: the color is not applied to the navbar links. The bug has existed since commit [1], which added the feature to set a custom text color for the header. Two problems were there from the start: - First, the variable wasn't saved inside quotes like it should have been. - Second, there was no function to convert theme colors (e.g., "o-color-1") into hexadecimal values when generating the CSS. Because of this, only non-theme colors worked with this option. This commit fixes the issue but ensures that it doesn't change anything for users who already applied a color that didn’t work before. This way, their navbar text color won't suddenly change after the fix without them understanding why. [1]: https://github.com/odoo/odoo/commit/d54028e5ed33a0258d3f2aeeaea338ac04f8d402 opw-4065019
The attendance check-in menu now disables the check-in action when the current user is not linked to an employee. This prevents users from seeing an error and gives a smoother experience when employee setup is incomplete.
Original PR description
The error occurred when the user was going to check in but didn't find any employee. Steps to reproduce: - Install ``hr_attendance`` module(without demo) - Employees > click on employee and remove ``Related User`` in ``HR Settings`` - Click on the ``systray`` button and ``Check-in`` Traceback: ``Expected singleton: hr.employee()`` The error occurred at [1] because we couldn't find an employee. This commit resolves the above error by disabling the button if there is no employee. [1]- https://github.com/odoo/odoo/blob/b05e203aa8f6956d5bc6606d7df53d74442d727a/addons/hr_attendance/controllers/main.py#L164 sentry-5616192792 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an internal test setup issue that caused the same restaurant point-of-sale frontend tests to run three times. It makes the test suite faster and cleaner without changing customer-facing behavior.
Original PR description
Currently since TestFrontend has test methods and is imported/inherited, the same test is executed three times. Fixing it by extracting setup to an utility class --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects a small configuration issue in the Spanish Facturae e-invoicing module related to tax selection values. It helps prevent errors or unexpected behavior when managing Spanish electronic invoice tax settings.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents automated EU OSS accounting tests from failing when a required chart of accounts is not installed. It improves test reliability and adds clearer validation, with no expected change for end users.
Original PR description
The aim of this commit is to prevent test from failing when the error is coming from a missing CoA. We used this opportunity to add a docstring and a new assert. task-id: None Runbot-build-error: 100531
This fixes an issue that could cause errors when updating a saved Razorpay payment method if card network information was missing. The change helps customers complete payment method updates more reliably and reduces unexpected payment-related failures.
Original PR description
Fix the code at [1], Where the system tries to update the payment method, Modify the code to handle this issue where the network value might not exist. This can be done by providing a default value for ```payment_method_type``` if the network value is not present. Link [1]: https://github.com/odoo/odoo/blob/d30f41a49f614456c71a0a6974325030f552a0db/addons/payment_razorpay/models/payment_transaction.py#L391-L392 Sentry-5950544641 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Printed PDFs now match the on-screen preview for nested list numbering. This helps documents keep a consistent appearance when users review them online and then print or export them.
Original PR description
Current behavior before PR: -Nested list numbering appeared differently in the preview compared to printed PDFs, causing inconsistencies in document appearance. Desired behavior after PR is merged: -Nested list numbering appears consistent between the preview and printed PDFs. task-4008883 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes spreadsheet test data by adding a missing identifier field. It helps keep automated checks accurate and reduces the chance of spreadsheet-related changes being delayed by faulty test setup.
Original PR description
Task: 4228916 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where completed recurring project tasks could keep creating new tasks past the configured “until” date. Businesses using recurring tasks will now see schedules stop at the intended limit, preventing unwanted task buildup.
Original PR description
Steps to reproduce: - Project > New Task > Set 'Deadline' to today - 'Repeat Every' 1 week Until tomorrow - Save > Change task state to 'Done' A recurring task is created with a deadline beyond the limit date, this can be repeated indefinitely. This happens because we check he limit date against today instead of comparing it to the task deadline. This is most likely an artifact of 85e9290711c5376660941122dffb3b335b223091, where we allowed immediate recurring task creation (Which would have previously been handled by the CRON at the appropriate date). opw-4210251 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Field service projects without a company will now use the active company when creating related sales orders. This prevents validation errors when users add products to billable tasks, keeping the product-to-sales flow working smoothly.
Original PR description
### Steps to reproduce: - Create a project and set it as billable - Create a new partner and set it as a customer for this project - In this project's settings check 'Products on Tasks' checkbox - Create a task in the project and navigate to the product view through the smart button - Add a product and you will get a Validation Error ### Current behavior before PR: This is happening when the project does not have a company assigned to it so the project's task won't have a company too and when preparing the values for the sale order we are using the task's company_id. https://github.com/odoo/enterprise/blob/17.0/industry_fsm_sale/models/project_task.py#L396:L404 ### Desired behavior after PR is merged: The PO suggested to fallback on the self.env.company when creating SO and we don't have one already. opw-4219492
This update resolves an issue where automated tests in the restaurant point-of-sale module were running three times unnecessarily, wasting testing time and resources. The fix reorganizes the test code structure to eliminate this duplication while maintaining the same test coverage.
Original PR description
Currently since TestFrontend has test methods and is imported/inherited, the same test is executed three times. Fixing it by extracting setup to an utility class
Miscellaneous changes
The domain set on the list datasource did not exclude the draft and cancelled invoices as it was for the other datasources. task-3999225 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182624
Original PR description
The domain set on the list datasource did not exclude the draft and cancelled invoices as it was for the other datasources. task-3999225 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182624
With this commit, the test test_ui is imported and runs smoothly. task-4143417 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181761
Original PR description
With this commit, the test test_ui is imported and runs smoothly. task-4143417 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#181761
## Description of the issue/feature this PR addresses: Prior to this commit, the health route is responding with a 200 status even when the database server is down or unreachable. In deployment scenario (CI/CD), this route (/web/health) is (can be) used in order to get the deployement state. This is actually the only one that can be used in order to check it without an active session or credentials or master password. Including the optional db_server_status arg will allow integrating th
Original PR description
## Description of the issue/feature this PR addresses: Prior to this commit, the health route is responding with a 200 status even when the database server is down or unreachable. In deployment…
## Description of the issue/feature this PR addresses: Prior to this commit, the health route is responding with a 200 status even when the database server is down or unreachable. In deployment scenario (CI/CD), this route (/web/health) is (can be) used in order to get the deployement state. This is actually the only one that can be used in order to check it without an active session or credentials or master password. Including the optional db_server_status arg will allow integrating the postgresql server state without breaking any eventual existing overrides. ## Current behavior before PR: When the postgresql database is not up / not reachable the route is returning a 200 code. ## Desired behavior after PR is merged: When the postgresql database is not up / not reachable the route is returning a 500 code. As we are in stable, an optional argument has been added to the route in order not to break any potential existing overrides. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182537
Before this commit, a regular expression was restricting the input units to `[A-Za-z%-]` characters. It made sense initially because those units were limited to technical terms with an untranslated name. But this makes "human" units such as "days" not recognized when using languages where the translated name either contains accents, or is not made of latin alphabet letters at all. This commit adapts the regular expression to consider a sequence of non-blank characters as the unit instead.
Original PR description
Before this commit, a regular expression was restricting the input units to `[A-Za-z%-]` characters. It made sense initially because those units were limited to technical terms with an untranslated name. But this makes "human" units such as "days" not recognized when using languages where the translated name either contains accents, or is not made of latin alphabet letters at all. This commit adapts the regular expression to consider a sequence of non-blank characters as the unit instead. Steps to reproduce: - Install Website - Drop a Popup inside the homepage - Switch user to Spanish - Edit the popup => The "Ocultar para" option did not display its value because "días" contains an accent. - Switch user to Japanese - Edit the popup => The "次のものに非表示" option did not display its value because "日" is not an alphabet letter. opw-4200520 Forward-Port-Of: odoo/odoo#182637
This commit fixes an error appearing on the password reset page when no password field is present (cf. the first step asking for the user's email). Steps to reproduce: - with the `auth_password_policy_signup` module installed - from the login page, click on "reset password" - the page asking for the user email is displayed => `TypeError: Cannot read properties of null (reading 'getAttribute')` opw-4184038 --- I confirm I have signed the C
Original PR description
This commit fixes an error appearing on the password reset page when no
password field is present (cf. the first step asking for the user's email).
Steps to reproduce:
- with the `auth_password_policy_signup` module installed
- from the login page, click on "reset password"
- the page asking for the user email is displayed
=> `TypeError: Cannot read properties of null (reading 'getAttribute')`
opw-4184038
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#180139