Monday, October 14, 2024
7 changes · saas-17.4
Resolved issues and error corrections
The Print & Send wizard now chooses the default Peppol sending option independently from warning messages. This prevents invoices from being automatically marked for Peppol sending when they should not be, reducing the risk of incorrect automated delivery.
Original PR description
…eckbox The default value of the Peppol checkbox in the Print & Send wizard depends on the presence/absence of warnings. In [the refactoring of warnings][1], we broke the previous behavior. We decided to show the warnings only when relevant, thus only when the checkbox is selected. Since the computation of the "checked" valued is based on the warnings, there is kind of a bad cyclic dependency. The warnings won't be set, therefore the checkbox will be checked on invoices where it shouldn't. This is particularly problematic for automatic flows. It was a bad design to have a computation that depends on the warnings, both shouldn't be directly linked. [1]: <https://github.com/odoo/odoo/commit/7dbcdd24cd3d8e0b6744847234a983f3361e296a> task-no
Fixes an error that could occur when users searched for or entered an optional product. This keeps product configuration workflows running smoothly and prevents users from being blocked by a technical traceback.
Original PR description
Currently, a traceback will occur when the user tries to give a value in the optional product.
Error:-
```
Invalid field product.template.product_tmpl_id in leaf ('product_tmpl_id', '!=', 6043)
```
This is because of the changes from the commit:-
https://github.com/odoo/odoo/pull/111575/commits/6fce58ead5185157339e98d7281ab338d38560ed
Here product_domain is getting the value from domain.copy().
```
We know that in python list, copy() creates a reference to the original object.
If you change the copied object - you change the original object
```
https://github.com/odoo/odoo/blob/0faca9ff9e1f35d5ed863d7daf61b71217015b01/addons/product/models/product_template.py#L541-L545
which means if we change the value of `product_domain` the value of the `domain` will also change.
So the domain will contain `product_tmpl_id` instead of `id`
and it leads to a traceback when searching `product_tmpl_id` from `product.template`.
sentry-5804120310Kitchen order tickets now print with complete and accurate details when kiosk self-order is used with online payment. The ticket layout was also adjusted with better spacing, making it easier for kitchen staff to read and fulfill orders correctly.
Original PR description
Before this commit: =================== - The kitchen order ticket was not printing correctly when the kiosk was configured with online payment, the ticket printed with incomplete or incorrect details. After this ticket: ================ - The kitchen order ticket now prints correctly when using kiosk self order. - Ticket layout has been improved, with proper margin and padding adjustments for better readability. Task- 4182015
Shop pages now display the comparison or strikethrough price when it is enabled, matching the behavior already seen on individual product pages. This helps shoppers clearly see discounts while browsing product listings, improving price transparency and promotional visibility.
Original PR description
**Issue:** On the main product page of the client’s shop, only the current price is displayed, and the strikethrough price (comparison price) is not shown. This issue arises even when comparison prices are enabled on the website. **Cause:** At first it was decided that the base price should be given priority over compare price and hence if base price was already set, compare price shouldn't be shown. **Fix:** This commit modifies the condition that gives priority to compare price over base price. **Before this commit:** The comparison price was shown in the individual product but wasn't shown on the shop page with all products **After this commit:** The comparison price is shown even for the shop page. **Affected version**: saas-17.4~master **opw**-4191727
Sales reporting now shows the average unit price when multiple order lines for the same product are grouped together. This prevents inflated unit price totals and gives users a more accurate view of product pricing in Sales and POS-related sales reports.
Original PR description
Steps: - Install sales app. - Create an order with 2 lines containing same products. - Go to Reporting list view. Issue: - Price unit should not display sum of all price unit it should be avg. e.g. A line with 10 quantity and 100 amount and other with same product 10 quantity with 200 amount price unit should be avg of both lines 150 not 300 sum of both lines. Cause: - Wrong method used in PR: https://github.com/odoo/odoo/pull/162554 Fix: - Use AVG method instead of SUM. opw-4188030
Closing a Point of Sale session now correctly starts replenishment checks for sold products. This helps ensure needed purchase or manufacturing orders are created automatically, reducing stockout follow-up work.
Original PR description
When closing the PoS the reordering rules where not triggered correctly Steps to reproduce: ------------------- * Create a product and add a reordering rules to it. (min_qty 1) * Make sure the product has no quantity on hand * Sell the product in PoS, and close the session > Observation: No purchase order is made Why the fix: ------------ When closing the session we make sure to trigger the scheduler that will create required purchase order and manufacturing orders. opw-4133635 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Invoices created from the Point of Sale in Peru are now signed with the government before the PDF is generated. This ensures the required QR code appears on the invoice and avoids duplicate signing attempts later.
Original PR description
When invoicing an order from the PoS the invoice was not signed by the government before rendering the pdf of the invoice. This lead to a missing QR Code on the invoice. Steps to reproduce: ------------------- * Install l10n_pe_edi_pos module * Open the PoS * Make an order and invoice it > Observation: The invoice should contains a QR Code attesting that the document has been signed by the government but it's not Why the fix: ------------ The issue was that the invoice was sent to the government after the invoice was rendered. To fix it we make the call to the government manually instead of waiting for the CRON to send it. We also cancel the CRON for this specific invoice so that it is not called twice. This is based on what is done here : https://github.com/odoo/odoo/blob/647197c0eae7ef786fa3d1aeafeafd1d14fe0fae/addons/l10n_es_pos_tbai/models/pos_order.py#L18-L29 opw-4165399