Wednesday, October 16, 2024
4 changes · saas-17.2
Resolved issues and error corrections
UAE reporting modules now install automatically when the related accounting and UAE localization setup is used. This prevents missing tax reporting fields and avoids installation or test errors that could block UAE accounting workflows.
Original PR description
Before this commit, when installing the account_reports and l10n_ae modules, the l10n_ae_reports and corporate_tax_report modules were not installed, even though they depended on these modules. This caused an issue during an account report test, as the necessary field was not created, leading to an "Invalid field" error: ('l10n_ae_tax_report_liabilities_account' on model 'res.company')
By removing the countries field from the manifest, the modules now auto-install as expected, and the test no longer fails. But why? If a module depends on another module that has the countries attribute, there’s no need to include it back; the auto-installation will only be triggered if there is a company that belongs to that country.This update corrects how subscription-related automated tests are skipped and how amount comparisons are checked. It helps ensure test results are accurate and prevents avoidable failures in validation pipelines, without changing customer-facing behavior.
Original PR description
Before this commit, tests were skipped without using self.skipTest which is not a good practice. Moreover, assertAlmostEqual was not properly used in an older version. ssertAlmostEqual should be used to compare amounts but it can be called with place, delta and message. The named argument should be used correctly. See https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertAlmostEqual The msg parameter should be explicitely named. Runbots: https://runbot.odoo.com/web/#id=102838&view_type=form&model=runbot.build.error&menu_id=405&cids=1 https://runbot.odoo.com/web/#id=102837&view_type=form&model=runbot.build.error&menu_id=405&cids=1 https://runbot.odoo.com/web/#id=102836&view_type=form&model=runbot.build.error&menu_id=405&cids=1 https://runbot.odoo.com/web/#id=102835&view_type=form&model=runbot.build.error&menu_id=405&cids=1 https://runbot.odoo.com/web/#id=102834&view_type=form&model=runbot.build.error&menu_id=405&cids=1
This fixes internal subscription payment tests so they handle expected payment statuses and optional demo payment setup correctly. It helps keep subscription payment checks stable without changing customer-facing behavior.
Original PR description
1. Use `skipTest` if `payment_demo` isn't installed 2. Allow `paid` as well as `in_payment` as valid states 3. Name message parameter with `msg` in `assertAlmostEqual` opw-4152257
When adding new content to an online course with multiple sections, the system now automatically selects the most recently created section if no section was chosen. This reduces extra clicks and helps course editors continue adding content in chronological order.
Original PR description
Purpose ======= When users are editing course content and created multiple sections they are most likely working "chronologically" adding content to sections one after the other. It seems the fix to preselect last section by default when many exist to populate new content is in regression. How to fix ========== Whenever a channel has sections and users has not selected one: make the last section as the default one. task-4109586 see odoo#132934 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr