Daily updates from Odoo
Thursday, October 17, 2024
21 changes · 18.0
Resolved issues and error corrections
This fixes an internal issue where grouped list results could be ordered incorrectly when custom field sorting logic contained spaces or line breaks. The change makes ordering more reliable for customized Odoo models and adds tests to prevent regressions.
Original PR description
`_read_group_orderby` used `cr.mogrify`, `split(",")` and `split()[0]` for the
result coming from the `_order_to_sql` which may come from `_field_to_sql`
As a side effect, SQL code after a space/newline not adjacent to a comma will
be dropped after `split()[0]`. So the mogrified customized `_field_to_sql`
shoudn't have any space/newline not adjacent to a comma if the field is used
for `Model._order`.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe customer portal invoice preview now better matches the invoice layout selected during Print & Send. If a customer has a custom invoice template setting, the portal uses it instead of always showing the default Odoo invoice format.
Original PR description
In the Print & Send, it is possible to use a different report template than the Odoo default one ('account.account_invoices'). This is not reflected in the portal preview.
Solution:
Which template has been used for an invoice is not an information that is saved in Odoo so we can't do something 100% accurate. When an invoice is generated with a different report than Odoo's one we save that as a setting on the partner.
We will render the portal preview with that template if it is set, to try to be closer to what should be shown.
task-no (approved by CHKL)This fixes an issue where the correct PDF report option was not always shown in the accounting Print & Send flow. It helps users reliably select and send the intended document without confusion or extra manual steps.
Original PR description
The display_pdf_report_id is not correctly computed. task-no
This update fixes several user-visible issues, including point of sale rescue sessions failing to open, website Facebook snippets breaking editing, and mailing cover images not appearing correctly. It also improves spreadsheet dashboards by adding favorites and better small-screen layout, while adding invoice list information for fapiao support.
This fixes the placement of editor action buttons when using right-to-left languages such as Arabic. It makes editing content smoother for users working in those languages by respecting the direction set on the main editable area.
Original PR description
Description of the issue this PR addresses: Previously, the positioning of powerbuttons only considered the `dir` attribute on the closest block element. However for true RTL languages like Arabic, the `dir` attribute is applied to the editable container, not the individual nodes. This commit makes sure that `dir` attribute of editable is taken into account when the closest block does not have its own `dir` attribute. task-4259040 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This pull request addresses several user-facing issues across Odoo, including duplicate email attachments, incorrect dropshipping delivery slip descriptions, misplaced table tools in email editing, currency conversion errors in shipping, missing RPC header support, and overly broad calendar email recipients. These fixes help improve accuracy, reduce customer confusion, and prevent unnecessary notifications.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a website issue where pages could unexpectedly jump back to the top when a popup appeared while animations were running. The change keeps visitors in the right place on the page, improving the browsing experience for animated website pages.
Original PR description
Since this commit [1], from which the scrolling element is no longer '#wrapwrap' but HTML, test 'snippet_popup_and_animations' fails. Because during animations 'overflow-x: hidden' is added on the…
Since this commit [1], from which the scrolling element is no longer '#wrapwrap' but HTML, test 'snippet_popup_and_animations' fails. Because during animations 'overflow-x: hidden' is added on the scrolling element (HTML). And a the time of a modal show, a 'overflow: hidden' style is added brievly on the 'body' element. Wich cause the page scroll to top when a modal sho while an animation is playing on the page. To fix this, unwanted behavior, we moved the 'overflow-x: hidden' rule added during animations from the HTML the the body. Since this commit [1], from which the scrolling element is no longer '#wrapwrap' but HTML, the test 'snippet_popup_and_animations' fails. This is because during animations, 'overflow-x: hidden' is added to the scrolling element (HTML). At the time a modal shows, an 'overflow: hidden' style is briefly added to the 'body' element, which causes the page to scroll to the top when a modal shows while an animation is playing on the page. To fix this unwanted behavior, we moved the 'overflow-x: hidden' rule added during animations from the HTML to the body." [1]: https://github.com/odoo/odoo/commit/189a7c96e6e26825dc05c0c6466576fe63aa091e task-4185877
Sales users will no longer see a general warning when changing a product's type on sales-related products. This reduces unnecessary interruptions while existing safeguards still block changes when they are not allowed.
Original PR description
Before the commit: Previously, when the product type of an item in a sales order was changed, a warning would be displayed, but users were still allowed to make the change. Although there are other checks in place to prevent changes to the product type under certain conditions, the general warnings were unnecessary. After the commit: Now, there will be no general warning when changing a product's type.
This fix makes the interactive sales walkthrough more reliable by ensuring guidance appears at the right time, users can continue after editing a line price without extra clicks, and the walkthrough does not fail when no document layout setup is needed. It helps users complete the sales flow with fewer interruptions during guided onboarding or training.
Original PR description
This change fixes the following issues, which occured when running the tour interactively: - The tooltip prompting the user to select or create a product wasn't shown, - After setting the SOL's price, the user had to click on the SOL again to trigger the next step (whereas they should be able to click anywhere), - If there was no document layout to configure, the tour would fail.
The Print & Send wizard now shows sending method names in the user's selected language instead of always showing English labels. This improves clarity for multilingual users and helps reduce confusion when sending accounting documents.
Original PR description
The sending methods displayed in the Print & Send wizard were populated using the selection field's `selection` field. This only gave the English terms as defined in the code. This commit fixes that by using another method that gets the values in the current user's language.
This update corrects how accrual carry-over validity is shown in Time Off settings. It prevents an unset validity value from appearing to users and fixes a related display widget name, reducing confusion when configuring leave accrual rules.
Original PR description
in this commit, fixes a issue where carry over validity isn't set value is still visible in view. task-4207945 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents the Calendar app from creating user settings records when they are not actually needed. It reduces unnecessary background data creation, helping keep user data cleaner without changing the visible calendar experience.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where action buttons in list views were missing on mobile devices. Those buttons now appear in the mobile cog menu, making important list actions accessible for users on smaller screens.
Original PR description
When we create a list view with a header buttons, the buttons didn't displayed in the DOM, but it should have been shift inside the cog menus. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When accounting accounts are merged, their translated names are now preserved instead of being lost. This helps multilingual companies keep accurate account labels for users working in different languages.
Original PR description
At the moment, when we merge accounts, we don't merge the account name's translations. This is a bit annoying since one account might have been called 'Account Receivable' in English, and another one might have been called 'Clientes' in Spanish. At the moment, the translations of the other accounts are lost. This commit makes us merge the translations when merging the accounts. taskid: 4210775
Fixes an issue that prevented portal users from previewing quotations for Brazilian companies. This ensures sales documents can be viewed reliably without an error interrupting the customer or sales workflow.
Original PR description
Currently, you view quotations in the portal with a Brazilian company.
### Steps to reproduce
* install `l10n_br_sales`
* switch to a Brazilian company
* attempt to "Preview" a quotation
You should be met with the following traceback:
```
AttributeError: 'NoneType' object has no attribute 'decimal_places'
Template: l10n_br_sales.document_tax_totals_brazil
Path: /t/tr[2]/td[2]/strong
Node: <strong t-out="tax_totals[\'total_amount_currency\']" t-options="{"widget": "monetary", "display_currency": currency}"/>
```
opw-4247492This fix ensures project forecast users see the correct error messages when something needs their attention. Clearer messages reduce confusion and help users understand what action to take.
Original PR description
Fixed incorrect error messages that were previously displayed. task-4193991
The barcode app now shows the appropriate manufacturing orders when entering a manufacturing operation type, focusing on items that are ready or still to do. New manufacturing orders created from a scanned operation type are now assigned to that same operation type, preventing confusion and misrouting in warehouse workflows.
Original PR description
In this commit: ================== - Replace the domain that applied when we enter the manufacturing operation type from the barcode application to domain 'To Do and MO ready'; - Use the right operation type when a new MO is created from the barcode app, regardless it was created by scanning the MO's product or using the form view. task-3925741
The worksheet button on field service task portal pages now appears in the same navigation area as related options like Task and History. This keeps the page layout consistent and prevents the button from looking out of place for customers using the portal.
Original PR description
Before this commit, the worksheet button is wrongly placed in the navbar of the portal form view of a task and so, it will lead to a wrong design for that button. This commit moves that button in the right place to be sure to have the same style than the other nav buttons (this is, `Task`, `History`,...) task-4251535
Manufacturing planning now correctly includes component consumption when calculating starting inventory. This helps planners see more accurate stock levels for components that are also tracked in the Master Production Schedule.
Original PR description
When a MO consumes components that have a MPS record, the MPS does not take the consumption moves into account for the starting quantity of the MPS record. This PR removes that condition to make sure the starting inventory is correctly computed.
Subscription quotations can now be previewed in the customer portal for Brazilian companies without triggering an error. This prevents a blocker for reviewing subscription offers and improves the portal experience for affected customers.
Original PR description
Currently, you view subscription quotations in the portal with a Brazilian company.
### Steps to reproduce
* install `l10n_br_sales`
* switch to a Brazilian company
* attempt to "Preview" the subscription quotation
You should be met with the following traceback:
```
AttributeError: 'NoneType' object has no attribute 'decimal_places'
Template: l10n_br_sales.document_tax_totals_brazil
Path: /t/tr[2]/td[2]/strong
Node: <strong t-out="tax_totals[\'total_amount_currency\']" t-options="{"widget": "monetary", "display_currency": currency}"/>
```
opw-4247492The customer portal now shows the correct upcoming invoice amount for subscriptions instead of zero. This prevents customers from seeing misleading billing information when previewing a sales order.
Original PR description
Version: - 18.0 Steps to reproduce: - Install the sale_subscription module - Create a Sales Order and preview it in the portal Issue: - The next billing amount in the portal shows as zero. Cause: - The wrong amount value is being used in the condition. Solution: - Use the correct total_amount to fix the issue. task-4247106