Thursday, October 17, 2024
6 changes · saas-17.4
Resolved issues and error corrections
This change makes an internal mail test more reliable by avoiding dependence on timing-sensitive scrolling events. It helps reduce false test failures, supporting smoother maintenance and release validation without changing end-user behavior.
Original PR description
The `scroll to the first unread message (slow ref registration)` test checks that clicking the unread message banner scrolls to the first unread message, even with delayed message loading. Previously, the test expected three `scrollend` events: - Scroll to top - Scroll to unread message - Minor scroll from highlight effect However, the highlight scroll sometimes fails to trigger if it starts before the second scroll ends, causing a missing `scrollend`. This PR resolves the issue by enhancing the `isInViewportOf` helper to listen for scroll events and assert directly, without relying on specific steps. runbot-69429739 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes an accounting test independent from changes made by other tests by ensuring the test company partner and fiscal positions use the same country. It helps keep automated validation reliable, reducing false failures in the release process without changing customer-facing behavior.
Original PR description
The test_get_first_fiscal_position() was failing on the runbot since its addition. The failure occurred because the company's partner in the environment either had no country set or a different country from the two fiscal positions defined in the test. This led to incorrect or missing fiscal positions being selected in _get_fiscal_position(). The issue arose because other test classes modified the company’s country. To resolve this, the test partner is now explicitly assigned a country, and the fiscal positions are defined with the same country to maintain consistent priority levels compared to existing fiscal positions. This ensures the test remains isolated from external factors, verifying that when two fiscal positions have identical attributes except for sequence, the one with the lowest sequence is prioritized. Runbot issue: 98910 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue in the Indian Point of Sale flow where adding certain products to an order could cause an error if their HSN code was missing. Sales staff can now add those products without interruption, reducing checkout disruptions.
Original PR description
Before this commit, adding a product without the l10n_in_hsn_code field to an order would cause an error, as the system expected this field to be a string. opw-4254897 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents website pages from failing when a table of contents section is removed before it has fully loaded, especially on mobile or pages with hidden content. It helps keep affected website pages stable while a deeper underlying issue is investigated.
Original PR description
A previous commit [1] fixed a bug where multiple "table of content" snippets were hidden in "mobile" view on a page (see commit message). However, this did not fix all cases. It is likely that with even more hidden elements on the page, the problem remains unresolved. We thought that await the start would solve the issue, but in some cases, the start wasn't even triggered by the time we reached the destroy. This commit fixes the issue by checking that the "this._scrollTarget" variable is initialized before removing its listener in the destroy. This bug requires more investigation, but this fix solves the issue for now. [1]: https://github.com/odoo/odoo/commit/ac5e9fe93c2158be1e8555de3da1419c69f543e5 task-4160033 opw-4228666 opw-4220959 opw-4226783
PDF generation no longer creates misleading device history entries such as “Linux - Safari” caused by the internal PDF tool. This keeps user device logs cleaner and avoids confusion when reviewing account activity.
Original PR description
During pdf generation, `wkhtmltopdf` creates device logs via a request whose user agent is: `Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.34 (KHTML, like Gecko) wkhtmltopdf Safari/534.34`. The result is that a `Linux - Safari` device log is created. This must be prevented (using the `_disable_trace` server-side mechanism of the session object).
This fix updates the demo setup for Colombia DIAN support documents so testing the DIAN web service no longer requires an extra manual step. It helps make validation smoother and reduces the chance of setup mistakes during testing.
Original PR description
This avoids a manual operation when testing DIAN's webservice for support documents. no task