Thursday, October 17, 2024
15 changes
1 change
Resolved issues and error corrections
This update simplifies how the system checks and opens files inside zipped documents such as spreadsheets and Mexican e-invoicing downloads. It avoids relying on internal software details, making these tests and related file handling more reliable over time.
Original PR description
Checking the filelist size before checking for existence based on `NamedToInfo` is unnecessarily convoluted, we can just compare the list of expected filenames to the `namelist()`. And using entry positions to open them is pretty much insane, just address the files by name, that's both clearer and more reliable. *Technically* for xlsx files we should probably go through `[Content_Types].xml` to retrieve the actual path to the shared strings file, but accessing that file directly is already an improvement I think.
12 changes
Resolved issues and error corrections
This fixes an internal issue where grouped list results could be ordered incorrectly when custom field sorting logic contained spaces or line breaks. The change makes ordering more reliable for customized Odoo models and adds tests to prevent regressions.
Original PR description
`_read_group_orderby` used `cr.mogrify`, `split(",")` and `split()[0]` for the
result coming from the `_order_to_sql` which may come from `_field_to_sql`
As a side effect, SQL code after a space/newline not adjacent to a comma will
be dropped after `split()[0]`. So the mogrified customized `_field_to_sql`
shoudn't have any space/newline not adjacent to a comma if the field is used
for `Model._order`.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr2 changes
Resolved issues and error corrections
This update ensures that the Documents field in projects displays a consistent label across all installations. Previously, the label would vary depending on which modules were installed, which could cause confusion. Now it will always show "Documents" for clarity and consistency.
Original PR description
Before this commit, when documents_project module is installed on a fresh DB the label of `Use Documents` and when documents_fsm module is installed the label is updated to be `Documents`. This commit makes sure the label of that field will always be `Documents` in all cases. task-4250848 Forward-Port-Of: odoo/enterprise#71741
This fixes an issue where the correct PDF report option was not always shown in the accounting Print & Send flow. It helps users reliably select and send the intended document without confusion or extra manual steps.
Original PR description
The display_pdf_report_id is not correctly computed. task-no
This fixes the placement of editor action buttons when using right-to-left languages such as Arabic. It makes editing content smoother for users working in those languages by respecting the direction set on the main editable area.
Original PR description
Description of the issue this PR addresses: Previously, the positioning of powerbuttons only considered the `dir` attribute on the closest block element. However for true RTL languages like Arabic, the `dir` attribute is applied to the editable container, not the individual nodes. This commit makes sure that `dir` attribute of editable is taken into account when the closest block does not have its own `dir` attribute. task-4259040 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Sales users will no longer see a general warning when changing a product's type on sales-related products. This reduces unnecessary interruptions while existing safeguards still block changes when they are not allowed.
Original PR description
Before the commit: Previously, when the product type of an item in a sales order was changed, a warning would be displayed, but users were still allowed to make the change. Although there are other checks in place to prevent changes to the product type under certain conditions, the general warnings were unnecessary. After the commit: Now, there will be no general warning when changing a product's type.
This fix makes the interactive sales walkthrough more reliable by ensuring guidance appears at the right time, users can continue after editing a line price without extra clicks, and the walkthrough does not fail when no document layout setup is needed. It helps users complete the sales flow with fewer interruptions during guided onboarding or training.
Original PR description
This change fixes the following issues, which occured when running the tour interactively: - The tooltip prompting the user to select or create a product wasn't shown, - After setting the SOL's price, the user had to click on the SOL again to trigger the next step (whereas they should be able to click anywhere), - If there was no document layout to configure, the tour would fail.
The Print & Send wizard now shows sending method names in the user's selected language instead of always showing English labels. This improves clarity for multilingual users and helps reduce confusion when sending accounting documents.
Original PR description
The sending methods displayed in the Print & Send wizard were populated using the selection field's `selection` field. This only gave the English terms as defined in the code. This commit fixes that by using another method that gets the values in the current user's language.
This update corrects how accrual carry-over validity is shown in Time Off settings. It prevents an unset validity value from appearing to users and fixes a related display widget name, reducing confusion when configuring leave accrual rules.
Original PR description
in this commit, fixes a issue where carry over validity isn't set value is still visible in view. task-4207945 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents the Calendar app from creating user settings records when they are not actually needed. It reduces unnecessary background data creation, helping keep user data cleaner without changing the visible calendar experience.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When accounting accounts are merged, their translated names are now preserved instead of being lost. This helps multilingual companies keep accurate account labels for users working in different languages.
Original PR description
At the moment, when we merge accounts, we don't merge the account name's translations. This is a bit annoying since one account might have been called 'Account Receivable' in English, and another one might have been called 'Clientes' in Spanish. At the moment, the translations of the other accounts are lost. This commit makes us merge the translations when merging the accounts. taskid: 4210775
This fix ensures project forecast users see the correct error messages when something needs their attention. Clearer messages reduce confusion and help users understand what action to take.
Original PR description
Fixed incorrect error messages that were previously displayed. task-4193991
The worksheet button on field service task portal pages now appears in the same navigation area as related options like Task and History. This keeps the page layout consistent and prevents the button from looking out of place for customers using the portal.
Original PR description
Before this commit, the worksheet button is wrongly placed in the navbar of the portal form view of a task and so, it will lead to a wrong design for that button. This commit moves that button in the right place to be sure to have the same style than the other nav buttons (this is, `Task`, `History`,...) task-4251535
The customer portal now shows the correct upcoming invoice amount for subscriptions instead of zero. This prevents customers from seeing misleading billing information when previewing a sales order.
Original PR description
Version: - 18.0 Steps to reproduce: - Install the sale_subscription module - Create a Sales Order and preview it in the portal Issue: - The next billing amount in the portal shows as zero. Cause: - The wrong amount value is being used in the condition. Solution: - Use the correct total_amount to fix the issue. task-4247106
This update corrects and cleans up translations in German localization modules for account follow-up and field service management. These improvements ensure that German-speaking users see accurate and consistent text throughout the application, enhancing the overall user experience.
Original PR description
*l10n_din5008_account_followup, l10n_din5008_industry_fsm Related to: https://github.com/odoo/odoo/pull/183268 Forward-Port-Of: odoo/enterprise#71710