Friday, October 18, 2024
5 changes · 17.0
Resolved issues and error corrections
Users who try to enable desktop notifications in Brave will now see a helpful message instead of an unexpected error. The message explains the browser setting needed for Brave, while other browsers receive a general failure message.
Original PR description
A known issue in Brave (https://github.com/brave/brave-browser/issues/2362#issuecomment-571775236) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying a more helpful message, suggesting enabling Google Services when using Brave, or showing a generic error for other browsers. task-4191214
This fix makes advanced automation rule filters visible in debug mode and clarifies when certain filters apply. It helps prevent emails or other automated actions from running for the wrong records when users configure conditions on record creation.
Original PR description
Versions -------- - 17.0+ Steps ----- 1. Enter debug mode; 2. create an Automation Rule; 3. select Task as model; 4. set trigger to Stage is set to New; 5. set domain to a specific customer; 6. add…
Versions -------- - 17.0+ Steps ----- 1. Enter debug mode; 2. create an Automation Rule; 3. select Task as model; 4. set trigger to Stage is set to New; 5. set domain to a specific customer; 6. add send email as action; 7. create a task. Issue ----- Email is sent after task creation, regardless of the customer. Cause ----- The triggers added to 0a744accc2aa automatically compute the `filter_domain` value, and hide the field in view. With debug mode enabled, the `filter_pre_domain` field is still visible & editable. The newly added triggers are applied on both create & update, while `filter_pre_domain` is only applied on update. This leads to confusion when clients add a domain which appears to be ignored, as the selected trigger is immediately hit on creation. Solution -------- 1. Specify in the help string that `filter_pre_domain` is ignored on creation. 2. When entering debug mode, also show the `filter_domain` field, allowing users to further modify the domain computed by the selected trigger, and helping to distinguish itself from `filter_pre_domain`. opw-3928082
The expense form now shows the Total label only when it is relevant: for single-currency expenses with a product cost. This avoids repeated or missing labels, making the expense entry screen clearer for users.
Original PR description
Updated the label for `total_amount` to display `Total` when the expense is not in multiple currencies and the product has a cost, and to show an empty label in the other previously considered cases. This change ensures that the label is displayed correctly without repetitions or omissions in the relevant scenarios. Current behavior before PR: <img width="438" alt="Screenshot 2024-10-10 at 11 05 52 PM" src="https://github.com/user-attachments/assets/af93e767-bc0f-487b-bb35-49ad4602f0ba"> Desired behavior after PR is merged: <img width="450" alt="Screenshot 2024-10-10 at 11 04 51 PM" src="https://github.com/user-attachments/assets/40f531a8-0d79-4eb6-a3d6-cd80abcb145c"> --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a bug that could block updates to manufacturing bills of materials when their order sequence was changed. The change helps users save BOM updates reliably and avoids an unexpected system error in manufacturing workflows.
Original PR description
Issue: if 'sequence' in vals and self and self[-1].id == self._prefetch_ids[-1]: TypeError: 'PrefetchX2many' object is not subscriptable Cause of the issue: PrefetchX2many object does not have __getitem__ method, only __iter__ --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Opening some bank journal items no longer triggers an error caused by a file name check on binary fields. This makes the journal item form more reliable for accounting users and avoids interruption during review workflows.
Original PR description
* STEP TO REPRODUCE: install account -> journals -> Bank journal -> View Journal Items -> Click on any bank journal item -> traceback * REASON: When click on Bank journal item, system take use to account.bank.statement.line form view , there we have some field for example needed_terms is binary so the system try to retreive filename for it but it fails because when using this.props.record.data[this.props.name] it will return a proxy object which is not a string * SOLUTION: check the return value if a string we do a slice for it else return empty string Video reproduce on runbot (17/10/2024): https://github.com/user-attachments/assets/b520e27a-09db-4f55-9b6d-4a2ef202047e --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr