Tuesday, October 22, 2024
5 changes · saas-17.4
Resolved issues and error corrections
Splitting a restaurant bill no longer sends the already prepared order back to the kitchen display. This prevents kitchen staff from preparing the same meal twice and reduces confusion during table service.
Original PR description
Prior to this commit, splitting an order would create a new order, causing it to appear again on the preparation display. This could lead to the kitchen preparing the same order twice. The sequence of events was as follows: 1. The order is placed. 2. The kitchen receives and prepares the order. 3. The waiter delivers the order to the table. 4. The client receives the bill and requests a split. At the point of splitting, a new order is created. This duplicate order should not be sent to the kitchen as it represents a meal that has already been prepared and consumed. This commit resolves this issue by preventing display of duplicate orders to the kitchen during order splitting. Enterprise PR: https://github.com/odoo/enterprise/pull/68039 opw-4089558 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents invoice posting from failing when the Peruvian POS electronic invoicing module is installed and the user does not have Point of Sale access. It ensures accounting users can post invoices without needing unrelated POS or inventory permissions.
Original PR description
Context: an AccessError is raised while running test `TestAccountMove.test_add_followers_on_post` and having `l10n_pe_edi_pos` installed: ``` odoo.exceptions.AccessError: You are not allowed to access 'Point of Sale Orders' (pos.order) records. This operation is allowed for the following groups: - Inventory/User - Point of Sale/User Contact your administrator to request access if necessary. ``` Reason: commit 3045807f9a318fed810095fc5746c0e7bbdb0063 extended the `_post` method on `account.move`, and is reading the field `pos_order_ids`. But one may post an invoice without having sufficient security groups to access `pos.order` records (Inventory/User, Point of Sale/User). runbot-102743
This fix prevents a payroll traceback when reimbursable expenses are processed on a payslip structure that does not include the required expense salary rule. Expenses are no longer linked automatically in that case, and users now receive a clear error if they try to add one manually, reducing confusion during payroll processing.
Original PR description
Steps to reproduce: - Expenses > New > Mitchell Admin; Paid by employee (to reimburse) - Create report > Submit to Manager > Approve > Report in Next Payslip - Payroll app > Payslips > To Pay > New >…
Steps to reproduce: - Expenses > New > Mitchell Admin; Paid by employee (to reimburse) - Create report > Submit to Manager > Approve > Report in Next Payslip - Payroll app > Payslips > To Pay > New > Mitchell Admin - Set structure to 'Worker Pay' (Or any other with no expense rule) - Compute sheet > Create draft entry > Journal entry (Draft) button - Post > Traceback The traceback is caused by 'KeyError expense_report_name', this happens because e65511ac69131b048da5d11afd00f3cfe91db474 changed the move creation process to ease reconciliation of expense compensated on the employee's payslip. We would have previously had access to expense_report_name=move.expense_sheet_id.name, which we do not in saas-17.4 and onwards. This causes the traceback when trying to display the error message which still depends on this inaccessible variable. We instead expect expenses not to be linked when creating payslips with a structure containing no expense rule, and a proper error if the user attempts to add an expense by hand on such a payslip. opw-4222515
Field Service users on mobile can now open planning tasks in the Gantt view without seeing an error. The fix ensures the app correctly identifies the View/Edit action when multiple buttons are present in the task popover.
Original PR description
Steps to Reproduce: - Open Field Service in mobile view. - Change to Gantt View. - Click on any planning task in gantt view. Issue: - You get a traceback. Reason: - After the PR https://github.com/odoo/enterprise/pull/54292 we can have multiple buttons in gantt popover. - Here we try to add a onClick to button Edit/View. - Code was not adapted for multiple buttons being available. Fix: - Adapted code to work with multiple buttons and find the View/Edit button and add onClick. task-4204936
Splitting a bill after an order has already been prepared no longer sends the same items back to the kitchen display. This helps avoid duplicate preparation, reduces waste, and prevents confusion between waiters and kitchen staff.
Original PR description
Prior to this commit, splitting an order would create a new order, causing it to appear again on the preparation display. This could lead to the kitchen preparing the same order twice. The sequence of events was as follows: 1. The order is placed. 2. The kitchen receives and prepares the order. 3. The waiter delivers the order to the table. 4. The client receives the bill and requests a split. At the point of splitting, a new order is created. This duplicate order should not be sent to the kitchen as it represents a meal that has already been prepared and consumed. This commit resolves this issue by preventing display of duplicate orders to the kitchen during order splitting. Community PR: https://github.com/odoo/odoo/pull/175878 opw-4089558