Thursday, October 24, 2024
7 changes · saas-17.4
Resolved issues and error corrections
Guest checkout will no longer link newly created delivery contacts to the generic Public User account as their company. This keeps customer contact records cleaner and avoids confusion for staff reviewing orders created through express checkout.
Original PR description
Versions -------- - saas-17.4 Fixed in 18.0+ via #174073 Steps ----- 1. Enable Demo payment w/ express checkout; 2. as anonymous user, add a deliverable product to cart; 3. go to checkout; 4. finalize order using the "Pay with Demo" button; 6. on the back-end, check the newly created contact for the order. Issue ----- Newly created contact has "Public User" listed as company. Cause ----- The `_complete_address_values` method introced by 453cfab758505 avoids adding "Public User" as `parent_id` value for addresses of type 'billing' but overlooked taking the same precaution for the 'shipping' address type. This was inadvertently fixed in 087c48c4ed2ef, which modified the method to add Click & Collect. Solution -------- Avoid adding the archived "Public User" as `parent_id`, regardless of address type. opw-4235452
Missing sample data was added so Point of Sale automated tests run successfully when the Peruvian POS localization is installed. This helps keep release validation reliable and reduces false test failures during quality checks.
Original PR description
How to reproduce: 1. install l10n_pe_edi_pos 2. run `test_pos_js` The following traceback is obtained: ``` Error received after termination: QUnit test failed: point_of_sale > Chrome > test unsynch data error filtering : message: "Promise rejected during "test unsynch data error filtering": Cannot read properties of undefined (reading 'code')" ``` Adding demo data fixes the error. runbot-73446
The Discuss app now keeps unread message counts aligned between the sidebar and the unread message banner. This prevents users from seeing conflicting counts when messages are marked unread or received across active sessions.
Original PR description
Discuss displays an unread counter for the user to keep track of unread messages. This counter is notably shown in the sidebar and in the unread messages banner. However, these counters sometimes have different values, which is inconsistent. Steps to reproduce: - Open two browsers (admin/demo). - Send enough messages from demo to admin to get a scrollbar. - Scroll to the top with admin, mark the first message as unread. - Focus the composer: only the banner remains. - Send another message from demo. - The sidebar displays 1 unread message while the banner still shows the same value. To better indicate unread messages, the banner/indicator remains until the user returns to the thread. As a result, server and local values can sometimes become desynced. This PR ensures both counters account for this desync, adding the local counter to the server one when necessary.
The Activities kanban view no longer shows a New button that could not create anything. This removes a confusing, non-working action and makes the interface clearer for users managing activities.
Original PR description
Current behaviour: --- When being on the kanban view of "my activities", the new button is visible but doesn't do anything. Expected behaviour: --- The button shouldn't be visible, because you shouldn't be able to create activities in the kanban view. Steps to reproduce: --- 1. Install contacts 2. Go to contacts 3. Click on the clock in the upper right 4. Click on "View all activities" 5. Switch to kanban view 6. Click on "New" 7. Nothing happens Fix: --- Disabled the "new" button opw-4210619 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The restaurant point-of-sale flow no longer repeats an order setup step that is already handled by the main point-of-sale system. This keeps the process cleaner and helps avoid unnecessary duplicate work without changing how users operate the restaurant POS.
Original PR description
Description of the issue/feature this PR addresses: - Rremove redundant call to `addPendingOrder`. Current behavior before PR: - Currently, `addPendingOrder` is invoked once by the `point_of_sale` module, and immediately again by `pos_restaurant` [when](https://github.com/odoo/odoo/blob/875ea840b913fd31ef73df9e10e4426df6195bfc/addons/pos_restaurant/static/src/overrides/components/product_screen/product_screen.js#L16-L18) the ProductScreen component mounts. Desired behavior after PR is merged: - Following the fix for #182495, the 'addPendingOrder' call in pos_restaurant becomes redundant and is no longer necessary. - As now we call the same function in root component. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue in the Sign app where clicking a date field during signing inserted “undefined” instead of today’s date. This ensures signers see the correct date automatically, reducing confusion and avoiding manual corrections.
Original PR description
Steps to reproduce: - Sign app > Upload a PDF & Sign - Add a Date field > Sign Now > Sign Now - Click the date field The value 'undefined' fills the field instead of today's date. This was caused by an oversight when resolving a conflict in https://github.com/odoo/enterprise/pull/71864, the query selector should have grabbed the date from the HTML document but didn't. opw-4278391
Deleting a measure used to sort a pivot table could make the spreadsheet side panel crash. This fix clears the affected sort setting when that measure is removed or changed, keeping pivot editing stable for users.
Original PR description
When deleting the measure on which the pivot is sorted, the side panel would crash. This commit fixes this issue by removing the sortedColumn from the pivot when the measure is deleted. Task: [4154831](https://www.odoo.com/web#id=4154831&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)