Thursday, October 24, 2024
4 changes · saas-17.4
Resolved issues and error corrections
This fix prevents product variants from showing up twice in the Point of Sale product list when they are loaded during attribute processing. It helps cashiers see a cleaner, more accurate product catalog and avoids confusion during sales.
Original PR description
Before this commit, product variants not initially loaded but fetched during the processing of product attributes would remain visible, leading to duplicate product displays. opw-4246879 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update refreshes the spreadsheet component with fixes that improve chart readability and accuracy. Business users should see correct tooltip values when chart data is zero, less overlap in chart labels, and quieter background logging for performance details.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/c82d9c104 [REL] 17.4.10 Task: 0 https://github.com/odoo/o-spreadsheet/commit/ec02c46a2 [FIX] Charts: Fix tooltip value…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/c82d9c104 [REL] 17.4.10 Task: 0 https://github.com/odoo/o-spreadsheet/commit/ec02c46a2 [FIX] Charts: Fix tooltip value when data is zero Task: 4251681 https://github.com/odoo/o-spreadsheet/commit/890f74235 [FIX] test: skipped test in `renderer_plugin.test.ts` Task: 4276968 https://github.com/odoo/o-spreadsheet/commit/504b90736 [FIX] logs: log performance information at debug level Task: 0 https://github.com/odoo/o-spreadsheet/commit/75906d42c [FIX] chart: avoid overlapping values on charts Task: 4207889 Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
This fixes an issue where Point of Sale promo codes linked to a specific pricelist were incorrectly rejected, even when that pricelist was selected. Businesses can now apply eligible loyalty promotions reliably at checkout when using flexible pricelists.
Original PR description
## Issue: When we create a loyalty program with promo code on a specific pricelist and try using the code in pos it gives the error "That promo code program requires a specific pricelist." even if we…
## Issue: When we create a loyalty program with promo code on a specific pricelist and try using the code in pos it gives the error "That promo code program requires a specific pricelist." even if we select that pricelist on pos, and put it on default. ## Steps to reproduce: - Go to pos settings and enable flexible pricelists - under the Available Field pick some pricelist and also set it as default - create a loyalty program with a promo code and set the pricelist you picked before as it's pricelist - open a pos session, add some products and try applying the promo code - a popup will show saying "That promo code program requires a specific pricelist." ## Solution: - While debugging the `activateCode` method, I found that the issue occurred because the code was using `.includes()` to check if `order.pricelist_id.id` was in `program_pricelists`, a list of objects. Since `.includes()` compares values directly, it couldn’t match an ID with objects, leading to it always returning False. - The fix uses the `.some()` method, which checks whether any object in the `program_pricelists` array has an id matching `order.pricelist_id.id`. This ensures that the comparison is made correctly on the id property of the objects. If a match is found, it returns true, and the validation proceeds as expected. OPW-4149335 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents users from triggering an error when inserting pivot view data into a spreadsheet dashboard without the required access. It also ensures the related automated test is actually executed, reducing the risk of this issue returning.
Original PR description
Steps to reproduce: - install Documents and CRM - login as Marc Demo - go to any pivot view - click on "Insert in spreadsheet" - select the Dashboards tab and confirm => boom Task: 4273554